Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8a206950-6208-fd21-daba-681a9818bfb7@intel.com>
Date:   Wed, 7 Sep 2022 12:26:31 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [Intel-gfx] [PATCH v8 14/16] mei: debugfs: add pxp mode to
 devstate in debugfs
Content-Language: en-US
To:     Tomas Winkler <tomas.winkler@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>
CC:     <intel-gfx@lists.freedesktop.org>,
        Alexander Usyskin <alexander.usyskin@intel.com>,
        <linux-kernel@vger.kernel.org>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        Vitaly Lubart <vitaly.lubart@intel.com>
References: <20220907155813.1427526-1-tomas.winkler@intel.com>
 <20220907155813.1427526-15-tomas.winkler@intel.com>
From:   "Ceraolo Spurio, Daniele" <daniele.ceraolospurio@intel.com>
In-Reply-To: <20220907155813.1427526-15-tomas.winkler@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NVdHU1ZBMVFwMU5PZmFDd3laRkVsUzF6TVNsZ28vNlFRV09pVkltd1A4NE9z?=
 =?utf-8?B?N25iQ010UUU5TjNzeW9oMmo5eFZwVzREeEJtN05VMWhlVzVPd3UwaWVGaTZC?=
 =?utf-8?B?eitoS0V1a1YrNVA3SjIwbDlZR2FRQXAxc051eDVtbmR4WjdCdG9Cbm1TNXE4?=
 =?utf-8?B?SUxVdHRqcmZkSkNnb2pNS2xzQTl5QW9ObDhuY09MbXhPaGRKTGNUVGg3YmtT?=
 =?utf-8?B?Ym9YWTIrc2NINlpoQ1RjbHJNUElJd2RMT2o5cGMxQ0xkdG1Ic3luS2RRTEN1?=
 =?utf-8?B?eUwrUjBmNUozMlc2MUV3TmZFbkJOSFdJZFhRZEx6dXowTlBCdW4xakFSSG9T?=
 =?utf-8?B?MEFEVE0xZDh5ck1MQ20wL3l4aGowcmhFYVdDVURJN3FuNTBRMXhvaTNFYlp5?=
 =?utf-8?B?ZktvcVh5VkpidXpQQTcvaC9RNElpbmNWck1QWGE0NVc1WUtScmlGS0wyTTZI?=
 =?utf-8?B?QkNTMlRDZHBYU1g2U2lyK1VVR1RySzE0eVYxa3QzY3ZaYkJLRWpSSGhyQlY4?=
 =?utf-8?B?cE53QWxpdmp5KzZBUDRveW54c2dDUWZ0UzBkZXhFUVVlOFBMZVloSzN5Qll4?=
 =?utf-8?B?TzhFRS9ZdUNxdlVnZEoyUHU2K3l1NjVpTUxYOHhoRGxta2dkcHhVU0JTOXNL?=
 =?utf-8?B?eUpZUnpWOUZFUXJQWVJCQnRDRmNvaE9jVStMQURKbzF0SkM5S2FHZ1BEK1RG?=
 =?utf-8?B?eGJZN0RyczFBb2pEemZrazVJQ3RLTEdTQ25jcHJmdkQ4aHN1a1BHS1BPODI1?=
 =?utf-8?B?Q2xJVGVlYmRzeVRFYlRUQ1lINVZoQ1dOTDMrcWpSVngyQStoNnNYZFlYVFBk?=
 =?utf-8?B?WkN1UTZLRjM5SGpMQUJjVUdTRmF0OWwwYWNoRTltd3UvbE1SeWRoY0ZrTjNt?=
 =?utf-8?B?VFhvaU5pdFZiUmZLamlIVjdCYkFIcitVMU04T1lpd0p1b25VeE1Oa0ZDVnFi?=
 =?utf-8?B?cU9xeU51QUUxQ0NrbG5OcStZTHhRS1h3UGp2cWx2cFhTMmdyOWEwU1dkV1JF?=
 =?utf-8?B?U0FUd3AzemJCeCtmbmE5Z0FaT2FCckQ4K1hBUDUxOGV0S1B0ZUNac0V5clhN?=
 =?utf-8?B?WGhmWkdIMDN0QllQT1JWNEhkU2ZId2tNZGNsTlRIbXhUbmhEbGRiWHpTNTdj?=
 =?utf-8?B?MHdYczZpRXR5WDFOc2ZqNlJPU2xxTWM3eE1yUHo0SGY0M1oxZi9QNXJFTUJm?=
 =?utf-8?B?T0JGSlgxOURsdFF3bHJnSTNETjZyVTZCc0FxTXpEQnM0dnFVY3JvdGFkT05j?=
 =?utf-8?B?eHpUYlNDRzUzVHI2bm9ER2tYeXorMTQzYmJYRkNIWnkxYWJva3MvZlc3TjRF?=
 =?utf-8?B?MDNReUNDeDc3YVdUK3JXOEJPY0dIVi9XdWdVMFVocEJ6Yjd6UW8wOGJuYzdu?=
 =?utf-8?B?UjJ3YzBWRDlaNWQ4d094MUNBa2Z3d2VCUTdHcDVXTlQrMmtrRWpaaFMzQ2U2?=
 =?utf-8?B?ZXhSZnk4d203QWJGVjlETmIxUXowaXArbzVHS0UzdkZTNy8zdnNQNmg0YUtZ?=
 =?utf-8?B?MmU1UTFMR2g5TzZWQTlOaTJIUDM1bVBjcGtNVVhMS0Y0c2pzTndtakx6c0hm?=
 =?utf-8?B?QVE4S3ltNDJORVVHeDJrUWYraWFCcVd5VmhOWm1uN1ZaaDE2WlE5eTBpNVlh?=
 =?utf-8?B?NXBRVmpnSjRSdlM4ODB1Ym9sL0JTbm5LUFk5ZlBQV3FKcWhSTlI1RHZVUjBM?=
 =?utf-8?B?dWd2am9jNHlMUko1MUUybGJ2eWJibnNQVTFONmJsVVB1ZDczYnE5YWcvRTBW?=
 =?utf-8?B?V2pQVVZHWk9mc3Q0K3A1TDJKREJ4d1BMblVCWDlVRURhSmJsSlg2SkltYlM0?=
 =?utf-8?B?bHRVOXVXYWNxaHhqMGduMmM3cnVhdDd6ZWkrRmZjTTR1bFpUM2xmemYvUkd6?=
 =?utf-8?B?QUtuWUZZL2FUYzF4Wk1mNlo2ZVpTM3FoMEl3UXd2a1Z1WThlcWo2UktNSG9j?=
 =?utf-8?B?THcvSFVlWXRWRzNsSkc2eFlSM0tyWm1ZNDlHTDdUSklRemlqL09IUzY3QUpW?=
 =?utf-8?B?b2d4QUxJeGQ4QWwwZUdqRTlaWXR1a3FyQ2FmaytxMGFqVGRaUWoyRm1PdHEx?=
 =?utf-8?B?dTRVaFozUkRxMlhQN1RLdjlpdzlZUVMzTzlqVEVRZmJiMUtUSTNDdStwa1p1?=
 =?utf-8?B?UVNlUERCWTgrY2R3SENsR0hWTWtxTjRvN0gwOG9BTDAxRDJ2Wm5JRDJidkNT?=
 =?utf-8?Q?6jsdWaUgo4nl67CpVQbl81g=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 94ec8c3f-9462-4634-8456-08da9106e1d8
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5488.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 19:26:37.2490
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xxAlCtzKahmgK6uZgZw9b77qHE7tcY5hLMC0OMeLbnS/NYI/GtdG2ARySFWnzjdVINf1gHXCziDYSEDjwAbV4yBMjIVA/ABX7Fe1YVVoKgM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5085
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-8.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 9/7/2022 8:58 AM, Tomas Winkler wrote:
> Add pxp mode devstate to debugfs to monitor pxp state machine progress.
> This is useful to debug issues in scenarios in which the pxp state
> needs to be re-initialized, like during power transitions such as
> suspend/resume. With this debugfs the state could be monitored
> to ensure that pxp is in the ready state.
>
> CC: Vitaly Lubart <vitaly.lubart@intel.com>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>

This is unchanged from the previously reviewed rev (apart from the 
header update), so this still applies:

Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

Daniele

> ---
>   drivers/misc/mei/debugfs.c | 19 ++++++++++++++++++-
>   1 file changed, 18 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/misc/mei/debugfs.c b/drivers/misc/mei/debugfs.c
> index 1ce61e9e24fc..3b098d4c8e3d 100644
> --- a/drivers/misc/mei/debugfs.c
> +++ b/drivers/misc/mei/debugfs.c
> @@ -1,6 +1,6 @@
>   // SPDX-License-Identifier: GPL-2.0
>   /*
> - * Copyright (c) 2012-2016, Intel Corporation. All rights reserved
> + * Copyright (c) 2012-2022, Intel Corporation. All rights reserved
>    * Intel Management Engine Interface (Intel MEI) Linux driver
>    */
>   
> @@ -86,6 +86,20 @@ static int mei_dbgfs_active_show(struct seq_file *m, void *unused)
>   }
>   DEFINE_SHOW_ATTRIBUTE(mei_dbgfs_active);
>   
> +static const char *mei_dev_pxp_mode_str(enum mei_dev_pxp_mode state)
> +{
> +#define MEI_PXP_MODE(state) case MEI_DEV_PXP_##state: return #state
> +	switch (state) {
> +	MEI_PXP_MODE(DEFAULT);
> +	MEI_PXP_MODE(INIT);
> +	MEI_PXP_MODE(SETUP);
> +	MEI_PXP_MODE(READY);
> +	default:
> +		return "unknown";
> +	}
> +#undef MEI_PXP_MODE
> +}
> +
>   static int mei_dbgfs_devstate_show(struct seq_file *m, void *unused)
>   {
>   	struct mei_device *dev = m->private;
> @@ -112,6 +126,9 @@ static int mei_dbgfs_devstate_show(struct seq_file *m, void *unused)
>   	seq_printf(m, "pg:  %s, %s\n",
>   		   mei_pg_is_enabled(dev) ? "ENABLED" : "DISABLED",
>   		   mei_pg_state_str(mei_pg_state(dev)));
> +
> +	seq_printf(m, "pxp: %s\n", mei_dev_pxp_mode_str(dev->pxp_mode));
> +
>   	return 0;
>   }
>   DEFINE_SHOW_ATTRIBUTE(mei_dbgfs_devstate);