Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <24c64113-f815-f3f5-708f-340a758f781a@amd.com>
Date:   Wed, 7 Sep 2022 14:59:26 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Reply-To: babu.moger@amd.com
Subject: Re: [PATCH v4 05/13] x86/cpufeatures: Add Bandwidth Monitoring Event
 Configuration feature flag
Content-Language: en-US
To:     Daniel Sneddon <daniel.sneddon@linux.intel.com>, corbet@lwn.net,
        reinette.chatre@intel.com, tglx@linutronix.de, mingo@redhat.com,
        bp@alien8.de
Cc:     fenghua.yu@intel.com, dave.hansen@linux.intel.com, x86@kernel.org,
        hpa@zytor.com, paulmck@kernel.org, akpm@linux-foundation.org,
        quic_neeraju@quicinc.com, rdunlap@infradead.org,
        damien.lemoal@opensource.wdc.com, songmuchun@bytedance.com,
        peterz@infradead.org, jpoimboe@kernel.org, pbonzini@redhat.com,
        chang.seok.bae@intel.com, pawan.kumar.gupta@linux.intel.com,
        jmattson@google.com, sandipan.das@amd.com, tony.luck@intel.com,
        james.morse@arm.com, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org, bagasdotme@gmail.com,
        eranian@google.com
References: <166257348081.1043018.11227924488792315932.stgit@bmoger-ubuntu>
 <166257363444.1043018.17384356050516925226.stgit@bmoger-ubuntu>
 <ec61c77f-260f-d9b1-a85a-1888fc45545d@linux.intel.com>
From:   "Moger, Babu" <babu.moger@amd.com>
In-Reply-To: <ec61c77f-260f-d9b1-a85a-1888fc45545d@linux.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OElQRCtMMGw0UGhJTVpyanVNTjlTdm5Yd0laZjFIYTJFQU15MEZCWkRwa2xS?=
 =?utf-8?B?ZEtJbCs0M3RSZnJpQWZHZnBZQVVaRVRDMitUVTZZcnpHODNtL255M0gxL01B?=
 =?utf-8?B?aTVacG5XUzVFVGdKQlFXQ1RUTzJTVVdDMDBGdmcyWUV0UDNCK1ZFblhaNndx?=
 =?utf-8?B?SmRsd1ZXMjM2bkd1S2hpY2kvRkU4SEJNQkFKd05ld0dSeGJtZElZVElyOGNw?=
 =?utf-8?B?TWZUVkJQSFN5aml4UVMyUWU3eERVRURFL1NORUVpTXRXU1lkWGsxNGlYeitO?=
 =?utf-8?B?Q3drOHJ4cThlblQ2czl0ZmhwQytORWxlUHdJTWlnbXJOaFdqTnhHNHdwc0t0?=
 =?utf-8?B?Vk9UNFk2RFpISjYxZEl2dUZFWm01eEdycm1CR3VGTU5hSUpCc0hOVEJtc1oy?=
 =?utf-8?B?dm5JVS9iUTNzcnhVMnREaXR2Vi8xUzAxcFlHR01QdE5md3RQZVFnQ05qK2FR?=
 =?utf-8?B?L0lNcy9LaDNVS0g1YVUxMkxzYmlpRHZxL3pVOUxMczB0KzR1TnBkZTRuOG02?=
 =?utf-8?B?OEhQSTlzSHFrOEVXdTVkMkJwUlFUb1JpTEVaa1dQNFhaL01SaU5vdTdhRDVs?=
 =?utf-8?B?SlVRK2ptdVNOV0plak0rK3V1Q1E5UXdQQi9NS25KdHZuUXJ2WjYyMmo0OS8x?=
 =?utf-8?B?RDhVZ3gwVFlGQ0lMdEp2RCtEb0NqV2FwdFZnc0dsMzRzbk9sWXlLTXBFSU01?=
 =?utf-8?B?dnVPWlZNaGJ6WVZwWHN4NXNVK1Q0SHhhU0tNRG9GaGtucjZCakZHWThaMnBl?=
 =?utf-8?B?NXl4bFVKYmlMYWtiN3pKTGRQWDVHNjVGd1ltVExnTk54Y2dBaTZxQU5yNmQ3?=
 =?utf-8?B?aUJValA3QkJJTWNNMFFLNjlVVG9Ob0NDL2c4YzVEeDU3dGRqSHUzcTdUL3Z6?=
 =?utf-8?B?M0JGRmJRL1psd0tUMHZRZG1qNFZSMW5IalFGRE81dDRhcGNzT2ZZaXhHcjN4?=
 =?utf-8?B?dGI1blJIeTJrakVsSERqK0l3a2NMdnd0cW5pbFJJbVdsQTdyL1l2ZU5uei8z?=
 =?utf-8?B?SU14bkZCVkdjNlIyOW9yUVBmVldRQnd4MkdRWkJvK1M0TU9FTVRhY1hpdUNE?=
 =?utf-8?B?anI4U09EV1c0QVNnMzNhc1NVQUMwRUxwWmVLQUJyK2lIVGtZU3BnU05DNnpE?=
 =?utf-8?B?NXFyVVIvRmk4MkRScTR4d2lsZUlDWkU3MlNkNjV2cy9LZEVkbzZKQjBHanNr?=
 =?utf-8?B?RERMc21UV3NXakp3OVBualA3bVkyVGtUa0ZLdFo4aUxwMURPdzIzaVdsdzVY?=
 =?utf-8?B?UjBiZHIxdjB0VytraTVIb2R3WC9JV0VxRmNIRGlGeUZnUjMwaGkwYkJ0bHRP?=
 =?utf-8?B?T3Erb3FSVlU2WWVjUCtkaFhBWmMxR3hrWTZ6RW5oV0R6RElYV0JrSFJUN1VL?=
 =?utf-8?B?aGQzSGs2SkFNVVJlMGlBWmtlTno3dEtTbTVySGhWQWFpbk9vQTJWbVRQQ2Vy?=
 =?utf-8?B?MEpWWCtHL3JQZWZBekF5YlVVcUpKMXByTjhidWdtamhmY0xQK1h2WklnQit0?=
 =?utf-8?B?b0gyTWtEQjdUbzdDeHY0RVRxMFlEQmtIRG5COXZ6ZkdkSExvTTBhbUF1MVhx?=
 =?utf-8?B?M25kNEYwVUVjbkgxZ3NGTkRGbENIbTlPTUtIdi8vVkJaV3JYait0UjFvaHB6?=
 =?utf-8?B?ZFZsem1ONVA5VEtwUTRWcEdFTjdZc1JnOFgrbUVqcG45akhWSnNTakpoZFFD?=
 =?utf-8?B?bVZvMDNyRURCYjI1QU1Zbmx2MldDZWM4SnJ2MUxnazVwakFILzV5dUs3RzR6?=
 =?utf-8?B?TCtvUkphZjNLMTc2R0tlYWEvVDFwSlIzU0dPckZIeDYyNGxrc1RMVi8wU00y?=
 =?utf-8?B?bzU1WFg2WmgvcDhvdnZUVzRBalFLREgxbWxqYVhjcjlQdnYzZEFpSlRmZUFO?=
 =?utf-8?B?WThIZG1uMXBtNEdKS1RIZHUxRUhWcHZBbGRkL2pEd0RXaGwveWhRVlY5dVJs?=
 =?utf-8?B?Rk92OHdxY3dmWWdUaGpiWDJoL0cxZXYwWjlsVUpoeUlsYWZaNW1nWENpS2RY?=
 =?utf-8?B?Z1pxazllUDEveGthUXhGajc4UTJlRTBtRzhpT1A5OFZ2eUdVZlJNbWxFdHZa?=
 =?utf-8?B?TWIyQjl3K1dDY3lTakZ3UEtodEJtczc5RnJMbGtFNnpjRXR6U2w4dm01VUlM?=
 =?utf-8?Q?EQscc0QNpBujqKSsfdlRxjIUZ?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 443e75a2-cc34-4fb1-70c2-08da910b7a6d
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 19:59:31.3350
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0n/SOIFRIcFhChfrAtSc1iRl/5BRNqHKccIPee4k6G3XmNEc+fsWpPp1zS4FB1Js
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6585
X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Daniel,

On 9/7/22 13:36, Daniel Sneddon wrote:
> On 9/7/22 11:00, Babu Moger wrote:
>>  #define X86_FEATURE_SMBA		(11*32+18) /* SLOW Memory Bandwidth Allocation */
>> +#define X86_FEATURE_BMEC		(11*32+18) /* AMD Bandwidth Monitoring Event Configuration (BMEC) */
> Shouldn't this be +19 instead?

Sorry. Missed that. Will fix it. 
Thanks
Babu Moger