Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 7 Sep 2022 23:04:40 +0200
From:   Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
        Linus Walleij <linus.walleij@linaro.org>,
        openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] pinctrl: wpcm450: Correct the fwnode_irq_get()
 return value check
Message-ID: <YxkHaBKtiO9zVuKM@probook>
References: <20220905191408.73794-1-andriy.shevchenko@linux.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="QyHwNmfZawVS5MLu"
Content-Disposition: inline
In-Reply-To: <20220905191408.73794-1-andriy.shevchenko@linux.intel.com>
Precedence: bulk


--QyHwNmfZawVS5MLu
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello,

On Mon, Sep 05, 2022 at 10:14:08PM +0300, Andy Shevchenko wrote:
> fwnode_irq_get() may return all possible signed values, such as Linux
> error code. Fix the code to handle this properly.

It would be good to note explicitly here what a return value of zero
means, i.e., as the documentation of of_irq_get says, "IRQ mapping
failure", and why it should result in skipping this IRQ.

> Fixes: a1d1e0e3d80a ("pinctrl: nuvoton: Add driver for WPCM450")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/pinctrl/nuvoton/pinctrl-wpcm450.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c b/drivers/pinctrl/=
nuvoton/pinctrl-wpcm450.c
> index 0dbeb91f0bf2..8193b92da403 100644
> --- a/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c
> +++ b/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c
> @@ -1081,10 +1081,13 @@ static int wpcm450_gpio_register(struct platform_=
device *pdev,
> =20
>  		girq->num_parents =3D 0;
>  		for (i =3D 0; i < WPCM450_NUM_GPIO_IRQS; i++) {
> -			int irq =3D fwnode_irq_get(child, i);
> +			int irq;
> =20
> +			irq =3D fwnode_irq_get(child, i);

(Unneccesary churn, but I'll allow it)

>  			if (irq < 0)
>  				break;
> +			if (!irq)
> +				continue;

Since irq =3D=3D 0 seems to be an error condition, the following seems fine
to me, and simpler:

-			if (irq < 0)
+			if (irq <=3D 0)
 				break;


Thanks,
Jonathan

--QyHwNmfZawVS5MLu
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEvHAHGBBjQPVy+qvDCDBEmo7zX9sFAmMZB0UACgkQCDBEmo7z
X9tvsA//ToHzTHoeMYZ0PQTlohG0yLPn60E96bE2iggwWBRQ5QU/nUHseXFgTin5
tGid5OfhqxHsnX8TDCFHq7S+29MPm+H1lmx7GKNeM73IK2HUjwdJ3hqG2jpcPIOa
5Og+hagJq1IrKcrD8Dmwb/7Hud/68gw8ry1b9W7faP0+16wiyYdm8+Pf8ZZ1QXca
YlQLIhqhL0WhxalEW7RGcBQW4n0vkxgmXVP8ZMUzFshJDTgk05vAp334US1n74xj
3qp7gsshpo0qJRGFN5znfgnc1EeqSQVJV1DNNP+sLVMTBVI+Yj3bHIhz601zORaY
Tvdh7KnouxCXLNaTHfUGUF0nXk6N8Ilyz4USDQG2B3+Jtyh4SxeJnBKp/WRMKRw2
+2GStxVtQoZSc3YvUTd4zgOIOI4Gs54lpy1grE4U0/9/RdK/2yYOtgww62qE50lb
nYnLkxwhkkgHLfAaWJwTOmj0qoxtQ3ANPMatY9573YHC0WTaLFl6W7qoUOYBB0q7
9L1Lz/HzL+Rta/1ujq1c9ElnmHGShH2mPBGUAxXslvxlSD52Z2yhPeMgrhJ2Zxx4
xKQcUxt3DY9H4R9RYseXUbpZt+27x0HYVuhkiXip0BHvFEpHtWxK2frKqvti8EdR
VF+Ggle0U21LXIBjZkRaH7Fj4/CdP2mvBdz/3yv++KgLwPwVVSY=
=u7tt
-----END PGP SIGNATURE-----

--QyHwNmfZawVS5MLu--