Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <94589646-d25c-538f-2513-4775c2c8551e@intel.com>
Date:   Wed, 7 Sep 2022 14:23:43 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [Intel-gfx] [PATCH v8 13/16] mei: drop ready bits check after
 start
Content-Language: en-US
To:     Tomas Winkler <tomas.winkler@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>
CC:     <intel-gfx@lists.freedesktop.org>,
        Alexander Usyskin <alexander.usyskin@intel.com>,
        <linux-kernel@vger.kernel.org>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        Vitaly Lubart <vitaly.lubart@intel.com>
References: <20220907155813.1427526-1-tomas.winkler@intel.com>
 <20220907155813.1427526-14-tomas.winkler@intel.com>
From:   "Ceraolo Spurio, Daniele" <daniele.ceraolospurio@intel.com>
In-Reply-To: <20220907155813.1427526-14-tomas.winkler@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dS9oN3ZkRlF3UTlVL0FGeU0ranJ2S2MzVFNVSjNTM3R4TEtlb1RIckI3eGVE?=
 =?utf-8?B?bjBMTW1WempMZEtHald0LzY5MjRMM1dJcG5Na1p3UTlIaURFb1ZzTnlleC9o?=
 =?utf-8?B?aDE4Yld0TXJZQjRtWFdDNnNOMWtXbUQ3c3B1Z2JIczJvMVRhMkkvZnUzK0Jw?=
 =?utf-8?B?c1NlcHpKSi9KT3FwQ014Mm8xRUxYQ0ZsSzU2RlZIRWxRY1RYcGRGVWQvdzJo?=
 =?utf-8?B?dzBmQVBVMXg4T1czNTNhbW5CbDltSDFHZDUvQzUvT1NVbVJHTGVXcy9Gd2ly?=
 =?utf-8?B?K1grWW04V3pGZHg4MVFlcGpsOU5qVEdSNFJGOWZHazlpOHhRaTlXNGxpS2lw?=
 =?utf-8?B?N1luTTdrYzBFUEExR0laVGIwaEkveVovQXBpM3QrS24vZm1lcW5vVk9zczRh?=
 =?utf-8?B?MHdtcDJvd2ozRU9KRWdCRFBLcnl6ZkZVMHVkOHl6ejE4VTlhSjJoWktaR2J0?=
 =?utf-8?B?ZUppOHJLdW9OSm1CWjBJRURLZGZINlhQNDBja1lvMGI2TUZpUFdEcHlrWjhB?=
 =?utf-8?B?TTR0cmh0UnZTLzExRW1xR21sdys3bFlJOGdDNEdEdVFURVRjV3dKNmhKdjNu?=
 =?utf-8?B?ZTZrOExNR3dmSmZTbDBwVFpEZTZpZnpSZElLTVZvREtnVVR3bC9VMVF6MTRp?=
 =?utf-8?B?c3ZNaFI5OEkzRU9TWDB2ekpHVHJBRy9UV0I5MjdYd0I0NHJuTTJhZGkzVzdQ?=
 =?utf-8?B?Und5TFpSTkJjcW9aM1J1MmNHT2VjTzZsTmwrTVR0Wmpsdkk4RnozanVWRWNJ?=
 =?utf-8?B?R0RPMkRLbnptK21nOWhnR3Rwd1N2aGE5WkpON2w3Y1RZTXorY1RtbkNud2R2?=
 =?utf-8?B?VkUvQVhwa0F4Um56WWxIWnBvbEMvT05ocHhyMzNQNS90RDZ5K2xhUnlvRzlX?=
 =?utf-8?B?Q0sveXJEQUxhOVVsN2s2MU5sV1diOG1aeklMc2JxZ1VGWUdrL2ZwMzVPeG4v?=
 =?utf-8?B?NWkxTGxwMFFWbGpWT3pvS1MwSU04VmM5S2ZSWWhZdmpVVmhDNStNNjZXK3cy?=
 =?utf-8?B?ckEyUldqcmFDbjVxMVc4MXVpRE0vVm5SbTFTRHVzdVZUMHM3WWFhVnlVSnN5?=
 =?utf-8?B?b2FCQTNqSk84blErd3l5aHh6amVDNmRwTUVjcmxyUzJwem8vUU5tc1lYa2pj?=
 =?utf-8?B?UXZaY3NwMVNMbkcvVlVqTTRUVkZRL1lOaU5aYUxyVU9ueHQ1YkxvaVlSQ3hS?=
 =?utf-8?B?S01VMVhqWFF2cUEzNmFDTVl3UWJOQkwvbWVtdURjbTEwQWNOZHV0eU8vN203?=
 =?utf-8?B?VHREUzRNNll6dWwxcC9BK3AvbmpRRzNRc0huWkNWRnFkbnV1cm9xQm9HRGx5?=
 =?utf-8?B?aUM2UU1MY2dJK1RrQ2J5WmNZd1RlK1JSbFpYdVpIZW1sNnBKaXZtekJiVmFH?=
 =?utf-8?B?MGZoTzBNN3dKd2UyK3RVNnlESnVYRHFVc2xpQm92UmlOaHB5blkwNVJTNXBy?=
 =?utf-8?B?RENVYlBkczJWc052Wno0cHB5L2M4WDRXQlhTbUd1YXB1Vy9PY0pGNUNiRmUy?=
 =?utf-8?B?V2VTck1EcVBSM2QrV2ttclowWG1jNVY0bC9POUE0SVM4TjNDTUtTVUJWMkx6?=
 =?utf-8?B?akRpMS9BVWJ0NXFkdkhhdVdaeFhnb21ZcEp1eGhrM1Yxd21tVjVlcVRWSHMz?=
 =?utf-8?B?WXRBRDA2VG1VdGhzQ2VhOFJrVVVLOHJ5Q2drOG1oRVAydytGTERMcmlNWTE0?=
 =?utf-8?B?S05UV081VSt4T3RjdzI1Q296R0lCODZyVDJ2djhIQjU0YnBaUHNYa3UzdU10?=
 =?utf-8?B?V2xIU0c5em8wRjRsLzZuQm82K2tnVkFXbU85NGdhT09jcmJKT3FRV0E5MGNh?=
 =?utf-8?B?ai9zbXl2RjRxdUxmMFloMjVEVGJhb2pwdGR3TjBEd1hzaFp0amgrczAwa1Ix?=
 =?utf-8?B?SzFKTS8vK0F2R3F1U3lPNUNPL0VXRGZSb0g0ZEVDYjNGcXFUaklMYmVKNlJX?=
 =?utf-8?B?cW5INjBxOHpvbC9LdndtT29UcVo5cW1RMzM1dUZnZDcxSjdHVU5zSjRHM0Vv?=
 =?utf-8?B?YjEzcStrak81ZEZ1SkJPV3J6VW15MzVlWktKeUJwSVZpbk9HMEROM0RzWXdX?=
 =?utf-8?B?YjhMU09Mbm93WEprRHIyVkRLL1gxSERlTExFSlhWeDhpTzhaNkVVbVZSQTAy?=
 =?utf-8?B?YnVKa3lhdUpsY2JMdWRuQllyaTkwbjNUNGJwTDZ0U1d4S2wrNy96RnZkeDJV?=
 =?utf-8?Q?6lQMi73LvxhFYiSlNdd8Gxs=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 17d1051d-845e-490f-9967-08da91173f09
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5488.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 21:23:45.5621
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5f6d1bqPiQSa5D/zaltqRzxsD1KQQkRi7/ssquQfDiyOGEJVrnsKqIXaumkrq8yfy+d6GRSx5l4VROR/boZtqEsYr+uMcld0BUhxhkimd34=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1942
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-8.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 9/7/2022 8:58 AM, Tomas Winkler wrote:
> From: Alexander Usyskin <alexander.usyskin@intel.com>
>
> The check that hardware and host ready bits are set after start
> is redundant and may fail and disable driver if there is
> back-to-back link reset issued right after start.
> This happens during pxp mode transitions when firmware
> undergo reset. Remove these checks to eliminate such failures.
>
> Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>

Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

Daniele

> ---
>   drivers/misc/mei/init.c | 10 ----------
>   1 file changed, 10 deletions(-)
>
> diff --git a/drivers/misc/mei/init.c b/drivers/misc/mei/init.c
> index 1b4d5d7870b9..bac8852aad51 100644
> --- a/drivers/misc/mei/init.c
> +++ b/drivers/misc/mei/init.c
> @@ -218,16 +218,6 @@ int mei_start(struct mei_device *dev)
>   		goto err;
>   	}
>   
> -	if (!mei_host_is_ready(dev)) {
> -		dev_err(dev->dev, "host is not ready.\n");
> -		goto err;
> -	}
> -
> -	if (!mei_hw_is_ready(dev)) {
> -		dev_err(dev->dev, "ME is not ready.\n");
> -		goto err;
> -	}
> -
>   	if (!mei_hbm_version_is_supported(dev)) {
>   		dev_dbg(dev->dev, "MEI start failed.\n");
>   		goto err;