Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Asmaa Mnebhi <asmaa@nvidia.com>
To:     Wolfram Sang <wsa+renesas@sang-engineering.com>
CC:     "robh@kernel.org" <robh@kernel.org>,
        "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 0/9] i2c-mlxbf.c: bug fixes and new feature support
Thread-Topic: [PATCH v2 0/9] i2c-mlxbf.c: bug fixes and new feature support
Thread-Index: AQHYtmFspLN7eEXzUE2AAJMrZ0F9+63GXGUAgAAEL0CADjbMAIAAAHDQ
Date:   Wed, 7 Sep 2022 21:42:53 +0000
Message-ID: <CH2PR12MB38951D3E64BCF82A2A0F3FFBD7419@CH2PR12MB3895.namprd12.prod.outlook.com>
References: <20220822195725.12656-1-asmaa@nvidia.com>
 <Yw0fNuOWtJbe/OT1@shikoro>
 <CH2PR12MB38951B9B8F189E1B991A7950D7769@CH2PR12MB3895.namprd12.prod.outlook.com>
 <YxkPKpPNXg8wEIDf@shikoro>
In-Reply-To: <YxkPKpPNXg8wEIDf@shikoro>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?pGx2oJYegq3uc+N/zLqtC/UZG53d3zCuQks7LHThF3Bn/bm0KYLXr1ue3+iu?=
 =?us-ascii?Q?pFBYkfn9JM6qBRA26Fk/25YcmFl5nk3VFlSCfxPxYxCDYOIdUWiOZK8yMI6e?=
 =?us-ascii?Q?0dc3j4B2jicl868eMEunxoHFoHDL6erxjjkNEa6FQVmWGdp1apx44rj8q2Di?=
 =?us-ascii?Q?JqV0w1eFG5MPHqiTvkoi95dIrJzpCBVRm0hd5cy4G0Es7mNBg4E7k1HNxYk0?=
 =?us-ascii?Q?M1jP9j/xCHpDIVgeF/iTFAtrk2wR1CdpoSMSk0Spn+0YVSCrJ75v824f0V+7?=
 =?us-ascii?Q?hEBGatPvSH81CuqoO6VzlX0kbk8kwe094AUoChcUOcBlDzwo1DId4QDNH/Zb?=
 =?us-ascii?Q?xWHDveILV2/BxuIxuqI0hCjd/P/lDLNTfvNNG1sPDNwtYpiAySVql00ZxIf6?=
 =?us-ascii?Q?2/zi5PUTkIVJear+7CbioXF8+Qm5jGd/OumIFbrI8kSWeu9LLGs0RK0WcCil?=
 =?us-ascii?Q?+pVlRRB1+jY9MPjMLbtE9foiDZGqhK+nQzTSVETnFT0+V2yuS9EiZQF6ZFks?=
 =?us-ascii?Q?+nJ5HZAzoEwV5jYj4L8k6m4Hnz+cD2D8nLZvpUN8gbMDzPuWBFtcwpQJIPTp?=
 =?us-ascii?Q?LQvQJGq10mQEcp4JSeDbbfIqcoq2R6qxwaSGyuQikVWiDcSeV2M8akQV6msx?=
 =?us-ascii?Q?nvRYK0fMt525lLOQGtxi2CD8CQUgkPxahg1l7taq9Ey7qMM1HjT+Y2eEPLG4?=
 =?us-ascii?Q?B5UzPG3QCxnpJxeuy2I5LA4Inq22DHR4ed7DQmQ7/cNpyV3ZxGDfukKOLTFF?=
 =?us-ascii?Q?jXF8jNL48UH8P9BIM5bvK3VGc6COUEhBNe3Lv/d0HVz3z9NjZEFcggRW3T6Y?=
 =?us-ascii?Q?mEKqqatA/JB2MxMTVFmB0WY/XDhWe5kuXtkxc/HZFFffRvzqkn7ByvBvhlNj?=
 =?us-ascii?Q?+Ceo25iYAPhTeYV7yKsKCZWco7IlaS83yC/9PnluL13T9WUY6ojeoHiYoobw?=
 =?us-ascii?Q?vhGhLpLP/Dy8iJnY9IXiQZVhSryDJQccrMVfLUBL+I+2N1LvXX+FgSqtc88h?=
 =?us-ascii?Q?tCE9vRZudItKoFN9h9qAuy8RWgcgPeED276dTIYHGlH0qCfLBBpreCglzw+W?=
 =?us-ascii?Q?uFmR/63dHBcilypis7WYd2WJcIi1Q5CE/hE3r9AQMfQzlzdB7eqQOYS44NKy?=
 =?us-ascii?Q?sXZR4px0aQv//UXRAfMQBJ7yjZQYgNs7pJMgpSrIQraa8loJ9ODsYQc/v6Hj?=
 =?us-ascii?Q?x0DxsCvHAq9Nc4kEtHYUTpCAZOAaNpt+77ApAwib+D+qGJR/t2Eiu9npuGf1?=
 =?us-ascii?Q?LpOCPHD/DgMifETBw30g98qxsC566KDnOJ9dvs+QBXhNKhm035Q4BeRa9IPm?=
 =?us-ascii?Q?P6SGaIrNBgAWVoLYQX9+8bj4I2NOqCpB4mo6BmXGFitj0GE3SgAnGg1GlIoX?=
 =?us-ascii?Q?EO3raVK8seR8GITjZFno10hgK1W8zVl4BF/vmCZQpsxDYU1OXelukmAC9U7P?=
 =?us-ascii?Q?hvJDI31y0M+dPO4FCDmJONrPxGkWXM8eevU0RLaUy87r6RK5vG4ETUaQII5h?=
 =?us-ascii?Q?9i55UKYXLGyEOIv4bL1anDKLZoOVILUO31mDI2yK3n+F87DQJPTy4GMfq5zQ?=
 =?us-ascii?Q?lg8UmHxBQZf9NpX4fQ0=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3895.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 99e2431b-5616-4fbd-696f-08da9119eb9a
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2022 21:42:53.8696
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: zp6oaYCcpl9Rr/fV96Z4A6ntrXgZgsWpCPh6iMlR5N7OJYamvSZHBtrurxBSVppYdCwQOOYCsoqVCnpGE2g7SA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4377
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> What did change since v1 and where did Khalil's Rev-by tags go?
>=20
> Khalil told me to remove the rev-by : ) since it is supposed to be reserv=
ed for the reviewers.

But he reviewed the patches, or? Which makes him a reviewer? I mean he is t=
he maintainer of the driver, so I basically a Rev-by from him.

Yes he did review the patch internally so I will add the Rev-by in v3

> I will add it back and describe what has changed in my next set of patche=
s.

So, you are planning a v3 already?

I was going to send a v3 patch after I get some feedback on the other patch=
es unless you'd prefer I send it now?=20

> As a note , this is what changed from v1->v2:

Cool, thank you for doing that.

> I think this is a bug fix because we have an i2c driver also in UEFI=20
> so we need this lock mechanism to avoid race conditions over acquiring=20
> the i2c bus. Not using this lock resulted in unexpected behavior.

OK, thank you!