Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp229179rwn; Wed, 7 Sep 2022 15:40:47 -0700 (PDT) X-Google-Smtp-Source: AA6agR5n9TxF7VxnQh/Qg5rtyWCflUpkJ6mY+41GaUiwhYqoeAzF+Xp/cMQwWhQcuBmkq7lx9QbR X-Received: by 2002:a05:6402:354d:b0:448:1f80:e737 with SMTP id f13-20020a056402354d00b004481f80e737mr4891813edd.69.1662590447167; Wed, 07 Sep 2022 15:40:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662590447; cv=none; d=google.com; s=arc-20160816; b=Kr2W6KyXWqJOkNb8sO3IH/O6WeGvL0CpEQ3IiTYGscBFv5spmN/aoFxwA66tLLq7OY OlD2wWWGpj3zAOtZaqtpd0rV51VjQXMhj7VzamPIOOqNfqhD1GgDV2IHNpHRLA2lcRUq E/5meeJAQZpxJd2TR/zidq0kOMq9zLC93vEkwZKP5rOBGnyjj9T1XP/OY+c/AHc46CB/ aclEfDr03fgP0Xm52yd4gZTp1m7pEDgBm7NhyqJdei1Ra0ot0MYK5kLlbhQJm19grtA1 zZ2KQzobTae6RrjtGdEldbsAfM16Caod4O4y+J0QctmzM7i7UQS5HXdULDC8TwzgBY3T GTkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=MS3Uxo+w/jAK7SrARsIiTzw3H7ee1suExD6tDkbZR+Y=; b=QSBQFg1d8IRVhdeMMPgfAZXmQaVMfmdGSwXXiNoDWoe9rEEFEY6cv2PiCDecCJ1vDy KuY35zW5PfFHjVQRRibU0TfQXFR2HOPpWOaQggDS0W1XfNswips8sua/kzxU4xatbwsF uwz94CSKiGavCOkyYDcejuYIvqR4zS9XLbckv23Ysh/SNA2xKu/9vpaqFiHIiDMzcicn Q4hftIT8JIJzt7WZ+hblNDIzDe/D2Q0NyjQD4TO9Q4IlyUe+0mE0mrKtG3mMLSxqoVjx afurx2sRMEWsEBAgYRm+zlTPNydCo8blzzX3n0chZyZVbZqmRAnR29cWa3HpGcVDxBMR 8kIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=I8fEiVnY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id le1-20020a170907170100b0073d7de9711dsi553453ejc.650.2022.09.07.15.40.22; Wed, 07 Sep 2022 15:40:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=I8fEiVnY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229656AbiIGWaX (ORCPT + 99 others); Wed, 7 Sep 2022 18:30:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229552AbiIGWaV (ORCPT ); Wed, 7 Sep 2022 18:30:21 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57BB554CA2; Wed, 7 Sep 2022 15:30:20 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 11896B81F27; Wed, 7 Sep 2022 22:30:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 495D9C433D6; Wed, 7 Sep 2022 22:30:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1662589817; bh=icUrwow2CfL0XBxzTtlHd9U90jN+X9EkDzy9xW2u15w=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=I8fEiVnYdONLg4RYOnaYni7CG0VvoCxIZn0T6K99IIfhvScjtIRaOt19syHlKmEil t8eQLP01qbrGEqu2bL0WD40A1KOvexY13ymExhqqa3bh7c6D2qonaIVG5EYYhH1nsG d1GHZ79kMApd+lcxU46r0rUc7wauR0AJL3bJiUf4= Date: Wed, 7 Sep 2022 15:30:16 -0700 From: Andrew Morton To: Davidlohr Bueso Cc: dan.j.williams@intel.com, x86@kernel.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, peterz@infradead.org, bp@alien8.de, dave.jiang@intel.com, Jonathan.Cameron@huawei.com, vishal.l.verma@intel.com, ira.weiny@intel.com, a.manzanares@samsung.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] memregion: Add arch_flush_memregion() interface Message-Id: <20220907153016.f7cd4f42a337fedae8319f28@linux-foundation.org> In-Reply-To: <20220829212918.4039240-1-dave@stgolabs.net> References: <20220829212918.4039240-1-dave@stgolabs.net> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I really dislike the term "flush". Sometimes it means writeback, sometimes it means invalidate. Perhaps at other times it means both. Can we please be very clear in comments and changelogs about exactly what this "flush" does. With bonus points for being more specific in the function naming?