Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp230565rwn; Wed, 7 Sep 2022 15:42:26 -0700 (PDT) X-Google-Smtp-Source: AA6agR7rRCHRBK7TYKYu62bnZNsoS4yTIKDn0NBokNc92Er0EO+jicXr/fM9A9cC/MmjyospbWij X-Received: by 2002:a17:907:7612:b0:771:db66:7b77 with SMTP id jx18-20020a170907761200b00771db667b77mr1630348ejc.228.1662590546660; Wed, 07 Sep 2022 15:42:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662590546; cv=none; d=google.com; s=arc-20160816; b=iIPq56Z3RmjEn9EyQlpJ3dupul50sXYSatu9fVwz9n6emwMFE9zUW1s0N2WRYYq38x ToqSXpGRUDGAWMbYZE5IulvT+S+LCAVDIhHH6iNnrbHZFCpCfpVFBAOIJht2wOf1+YJP Hmj2lX3favj9i9i5fbItGNSSF2MmI2qwxIsm7y80h3HJUWFLtgInFRV4xq4aINgVThYo FpPe/o63ba07iNhHj5TvTmv4dKsKbiZ2ANbPOhWeAduUP+iHdvPa1L8QebREHXsG18D0 sF4cm+h5/kBqYGXSfFMPi02t5RoT4O9K5ozNs4ggzGE6yhwk9b1aLgZzZ6nHFUUBuuGp sPFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=YY/QSe6wcb/X43Gze7vJsi9EKzGe9m7q2r72MyQ7vf8=; b=J4PYFJmJenJYg162FCAI1Jp1Ty4oiGhd2nimEXp7j42Dp7+5juEssyaxNhMgkLDuRK 5E1WLQsKc92MHxYGCO+YobP6+yRHR+2v0UoyBGbS3C+6iQhtEU1NvsncacfXPq5Hvmzp ubw50t09agfREHim4ym8gIba7ilpUkt2UoLfAICwtU8yRW1bmeyv4+DIsfkW3Q3Fn43e suIkisnBO5h4AzG6klerZUOfAIFP/9oIoi3Y3V4vwNzQtdEE2mvB3wbf2m1qo/1eYfOO DzEppQwhuE7D4sFbTcYIazNW7RW8CpEKEB0iRTKLoMjnqJEeR92tt2f85H66mdqEiHQB xBRg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=nq03Gq3r; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u11-20020a170906c40b00b0073d97252ac7si474955ejz.49.2022.09.07.15.42.02; Wed, 07 Sep 2022 15:42:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=nq03Gq3r; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230473AbiIGVwj (ORCPT + 99 others); Wed, 7 Sep 2022 17:52:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46224 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230370AbiIGVw1 (ORCPT ); Wed, 7 Sep 2022 17:52:27 -0400 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A53DC1679 for ; Wed, 7 Sep 2022 14:52:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662587542; x=1694123542; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=0Oosr1efZEAk/bzGsBCuZvDxX6WE7t3HGnW7Kpt3NhY=; b=nq03Gq3rIC7xLm/iQUgcvt6sUHq444sA6Kr+qRAE/t715MfQBMoyMgio 4ExntogdfjkH7x53rqr+OYnliDbexap6BqsTEsY5cWT2gfxCrZ1ah7+WY npjWgbo1LHA4wcp/Ww+BHX0fj8ISnfmvrcS+LHbaD5cW0PhvPraemgiSh Agm3l5fF0yXBSKL98KGmJAhWDcDBelRBeF5IExh1qnzCX9AuZp5xnLZLC z9tJLBND65tB68aF3TLxJMi1+0dmu1XIlpnp4VRqYYnd5fta9v2OxaYBt 5mpEEMbxXhZTidIJwoDhJKap/Uv1c8qBuzoWVhpklfCkBlDKR8mRAAJ42 g==; X-IronPort-AV: E=McAfee;i="6500,9779,10463"; a="295740375" X-IronPort-AV: E=Sophos;i="5.93,298,1654585200"; d="scan'208";a="295740375" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2022 14:52:21 -0700 X-IronPort-AV: E=Sophos;i="5.93,298,1654585200"; d="scan'208";a="790208060" Received: from twinkler-lnx.jer.intel.com ([10.12.87.143]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2022 14:52:18 -0700 From: Tomas Winkler To: Greg Kroah-Hartman , David Airlie , Daniel Vetter Cc: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, Tomas Winkler , Alexander Usyskin , Vitaly Lubart , Daniele Ceraolo Spurio Subject: [PATCH v9 13/16] mei: drop ready bits check after start Date: Thu, 8 Sep 2022 00:51:10 +0300 Message-Id: <20220907215113.1596567-14-tomas.winkler@intel.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220907215113.1596567-1-tomas.winkler@intel.com> References: <20220907215113.1596567-1-tomas.winkler@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alexander Usyskin The check that hardware and host ready bits are set after start is redundant and may fail and disable driver if there is back-to-back link reset issued right after start. This happens during pxp mode transitions when firmware undergo reset. Remove these checks to eliminate such failures. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler Reviewed-by: Daniele Ceraolo Spurio --- V8: New in the series V9: Rebase drivers/misc/mei/init.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/misc/mei/init.c b/drivers/misc/mei/init.c index 1b4d5d7870b9..bac8852aad51 100644 --- a/drivers/misc/mei/init.c +++ b/drivers/misc/mei/init.c @@ -218,16 +218,6 @@ int mei_start(struct mei_device *dev) goto err; } - if (!mei_host_is_ready(dev)) { - dev_err(dev->dev, "host is not ready.\n"); - goto err; - } - - if (!mei_hw_is_ready(dev)) { - dev_err(dev->dev, "ME is not ready.\n"); - goto err; - } - if (!mei_hbm_version_is_supported(dev)) { dev_dbg(dev->dev, "MEI start failed.\n"); goto err; -- 2.37.2