Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 8 Sep 2022 09:01:00 +1000
From:   Stephen Rothwell <sfr@canb.auug.org.au>
To:     Joe Perches <joe@perches.com>
Cc:     Philippe Schenker <dev@pschenker.ch>,
        Andy Whitcroft <apw@canonical.com>,
        linux-kernel@vger.kernel.org,
        Dwaipayan Ray <dwaipayanray1@gmail.com>,
        Lukas Bulwahn <lukas.bulwahn@gmail.com>,
        Shawn Guo <shawnguo@kernel.org>,
        Philippe Schenker <philippe.schenker@toradex.com>
Subject: Re: [PATCH] checkpatch: add check for fixes: tag
Message-ID: <20220908090100.155b9b26@canb.auug.org.au>
In-Reply-To: <1125e8a68a709e18b594f74fc9b25b9992b1582f.camel@perches.com>
References: <20220907123547.138646-1-dev@pschenker.ch>
        <1125e8a68a709e18b594f74fc9b25b9992b1582f.camel@perches.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/4QkMvq3jH8bTS8yvUfk=d4X";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Precedence: bulk

--Sig_/4QkMvq3jH8bTS8yvUfk=d4X
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi Joe,

On Wed, 07 Sep 2022 08:18:31 -0700 Joe Perches <joe@perches.com> wrote:
>
> I think the test better if it checks for a SHA1 after fixes.
>=20
> And IMO
>=20
> 	!(foo =3D~ /bar.../)
>=20
> is better written as
>=20
> 	foo !~ /bar.../
>=20
> so
>=20
> 		if ($in_commit_log &&
> 		    $line =3D~ /^\s*Fixes:?\s*[0-9a-f]{5,}\b/i &&
> 		    $line !~ /^Fixes: [0-9a-f]{12,40} \(\".*\"\)/)) {
>=20
> Though it's arguable that the SHA1 should _only_ be length 12
> and not longer.

It should be allowed to be longer - eventaully we will need to move on
from 12 as the repo gets bigger.  Also, any line matching /^\s*Fixes:/i
should be checked, because people do add extra words before the SHA1
and sometimes just other text.  You will get some hits that are not
meant to be Fixes tags, but very few.

--=20
Cheers,
Stephen Rothwell

--Sig_/4QkMvq3jH8bTS8yvUfk=d4X
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAmMZIqwACgkQAVBC80lX
0GxfEAgAlmSKNCC4+GTKCuPH2rpvpobiLBlnVyFGAJymO53KD9GKtRPWU/W2aRsa
PzynD1DkVxlwYhSyIwejvmuMUiEvpfLYxDGhXGU/EJwBB8CZIX6ZKcSBA6W0iDgN
o6r26Dx9pb4vACBGJKTEKprWURRsb2VVxYxE75G3vpsq5trfgvTh3qJeWD5KpyuM
Rdkg5hrsTwrgzDoEkKfrEffk/7GXxoU8GXrxnf0lBjg12/XVqCL1SDO0r5iNT+O7
aFnR9lO01UEcv3Vj8Q9Cl6yF6bYGrWQqLv/yXf8HBld7jH6tEzT60ibGkxFQuYJp
qnEeQhfQaP9TuMcZjSwoxMxU82fp0Q==
=JT6S
-----END PGP SIGNATURE-----

--Sig_/4QkMvq3jH8bTS8yvUfk=d4X--