Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 07 Sep 2022 20:47:52 -0300
From:   Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To:     Ian Rogers <irogers@google.com>, Jiri Olsa <olsajiri@gmail.com>
CC:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Namhyung Kim <namhyung@kernel.org>,
        James Clark <james.clark@arm.com>,
        Kees Cook <keescook@chromium.org>,
        "Gustavo A. R. Silva" <gustavoars@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Riccardo Mancini <rickyman7@gmail.com>,
        German Gomez <german.gomez@arm.com>,
        Colin Ian King <colin.king@intel.com>,
        Song Liu <songliubraving@fb.com>,
        Dave Marchevsky <davemarchevsky@fb.com>,
        Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
        Alexey Bayduraev <alexey.v.bayduraev@linux.intel.com>,
        Leo Yan <leo.yan@linaro.org>, linux-perf-users@vger.kernel.org,
        linux-kernel@vger.kernel.org, Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH v2 6/6] perf cpumap: Add range data encoding
User-Agent: K-9 Mail for Android
In-Reply-To: <CAP-5=fWVN4Fig5GEwyWwwUc9_iZyZ5rObTFkyNcuFp1GApy4tg@mail.gmail.com>
References: <20220614143353.1559597-1-irogers@google.com> <20220614143353.1559597-7-irogers@google.com> <YuZ4CEnken8U4HO5@krava> <CAP-5=fVczMiasS15UovH8kzOaNw=TC_adeqjC+xBzv8jVJ3DTQ@mail.gmail.com> <CAP-5=fWVN4Fig5GEwyWwwUc9_iZyZ5rObTFkyNcuFp1GApy4tg@mail.gmail.com>
Message-ID: <9B5AEBE0-D000-4D58-94BA-85153C5CD66F@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


On September 7, 2022 7:41:19 PM GMT-03:00, Ian Rogers <irogers@google=2Eco=
m> wrote:
>On Thu, Aug 4, 2022 at 12:30 PM Ian Rogers <irogers@google=2Ecom> wrote:
>>
>> On Sun, Jul 31, 2022 at 5:39 AM Jiri Olsa <olsajiri@gmail=2Ecom> wrote:
>> >
>> > On Tue, Jun 14, 2022 at 07:33:53AM -0700, Ian Rogers wrote:
>> >
>> > SNIP
>> >
>> > > +     event =3D cpu_map_data__alloc(&syn_data, sizeof(struct perf_e=
vent_header));
>> > >       if (!event)
>> > >               return NULL;
>> > >
>> > > +     syn_data=2Edata =3D &event->data;
>> > >       event->header=2Etype =3D PERF_RECORD_CPU_MAP;
>> > > -     event->header=2Esize =3D size;
>> > > -     event->data=2Etype   =3D type;
>> > > -
>> > > -     cpu_map_data__synthesize(&event->data, map, type, max);
>> > > +     event->header=2Esize =3D syn_data=2Esize;
>> > > +     cpu_map_data__synthesize(&syn_data);
>> > >       return event;
>> > >  }
>> > >
>> > > +
>> > >  int perf_event__synthesize_cpu_map(struct perf_tool *tool,
>> > >                                  const struct perf_cpu_map *map,
>> > >                                  perf_event__handler_t process,
>> > > @@ -1891,24 +1894,20 @@ int perf_event__synthesize_event_update_nam=
e(struct perf_tool *tool, struct evse
>> > >  int perf_event__synthesize_event_update_cpus(struct perf_tool *too=
l, struct evsel *evsel,
>> > >                                            perf_event__handler_t pr=
ocess)
>> > >  {
>> > > -     size_t size =3D sizeof(struct perf_event_header) + sizeof(u64=
) + sizeof(u64);
>> > > +     struct synthesize_cpu_map_data syn_data =3D { =2Emap =3D evse=
l->core=2Eown_cpus };
>> > >       struct perf_record_event_update *ev;
>> > > -     int max, err;
>> > > -     u16 type;
>> > > -
>> > > -     if (!evsel->core=2Eown_cpus)
>> > > -             return 0;
>> >
>> > all seems fine, just looks like we no longer do this check,
>> > might not be needed anymore, as that changed in past
>>
>> This function is called in a test and in this file=2E The caller alread=
y
>> does this test and so the check is redundant plus a little confusing:
>> https://git=2Ekernel=2Eorg/pub/scm/linux/kernel/git/acme/linux=2Egit/tr=
ee/tools/perf/util/synthetic-events=2Ec?h=3Dperf/core#n2062
>> As you say, it wasn't needed any more and so I removed it=2E
>>
>> Thanks,
>> Ian
>
>Would be nice to land this imo=2E Anything outstanding?

I'll check first hour tomorrow, today was a holiday down here=2E

- Arnaldo

>
>Thanks,
>Ian
>
>> > thanks,
>> > jirka
>> >
>> > > +     int err;
>> > >
>> > > -     ev =3D cpu_map_data__alloc(evsel->core=2Eown_cpus, &size, &ty=
pe, &max);
>> > > +     ev =3D cpu_map_data__alloc(&syn_data, sizeof(struct perf_even=
t_header) + 2 * sizeof(u64));
>> > >       if (!ev)
>> > >               return -ENOMEM;
>> > >
>> > > +     syn_data=2Edata =3D &ev->cpus=2Ecpus;
>> > >       ev->header=2Etype =3D PERF_RECORD_EVENT_UPDATE;
>> > > -     ev->header=2Esize =3D (u16)size;
>> > > +     ev->header=2Esize =3D (u16)syn_data=2Esize;
>> > >       ev->type        =3D PERF_EVENT_UPDATE__CPUS;
>> > >       ev->id          =3D evsel->core=2Eid[0];
>> > > -
>> > > -     cpu_map_data__synthesize(&ev->cpus=2Ecpus, evsel->core=2Eown_=
cpus, type, max);
>> > > +     cpu_map_data__synthesize(&syn_data);
>> > >
>> > >       err =3D process(tool, (union perf_event *)ev, NULL, NULL);
>> > >       free(ev);
>> > > --
>> > > 2=2E36=2E1=2E476=2Eg0c4daa206d-goog
>> > >