Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Kani, Toshi" <toshi.kani@hpe.com>
To:     Jia He <justin.he@arm.com>, Len Brown <lenb@kernel.org>,
        James Morse <james.morse@arm.com>,
        Tony Luck <tony.luck@intel.com>,
        Borislav Petkov <bp@alien8.de>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Robert Richter <rric@kernel.org>,
        Robert Moore <robert.moore@intel.com>,
        Qiuxu Zhuo <qiuxu.zhuo@intel.com>,
        Yazen Ghannam <yazen.ghannam@amd.com>,
        Jan Luebbe <jlu@pengutronix.de>,
        Khuong Dinh <khuong@os.amperecomputing.com>
CC:     Ard Biesheuvel <ardb@kernel.org>,
        "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
        "devel@acpica.org" <devel@acpica.org>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        Shuai Xue <xueshuai@linux.alibaba.com>,
        Jarkko Sakkinen <jarkko@kernel.org>,
        "linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
        "nd@arm.com" <nd@arm.com>
Subject: RE: [PATCH v5 3/8] EDAC:ghes: Move ghes_edac.force_load to ghes
 module parameter
Thread-Topic: [PATCH v5 3/8] EDAC:ghes: Move ghes_edac.force_load to ghes
 module parameter
Thread-Index: AQHYwTvGbABQAB55v0iGhuvI/sLGGa3UrWrg
Date:   Thu, 8 Sep 2022 00:15:49 +0000
Message-ID: <MW4PR84MB1849ECCAA0F67451B369FBF882409@MW4PR84MB1849.NAMPRD84.PROD.OUTLOOK.COM>
References: <20220905152439.77770-1-justin.he@arm.com>
 <20220905152439.77770-4-justin.he@arm.com>
In-Reply-To: <20220905152439.77770-4-justin.he@arm.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?EpkVpTZp/TTZsOMKIx1oPcMk9U2Ax2tl2zs/TT17+t1ggoSGSKUatj1rn11D?=
 =?us-ascii?Q?ksYjxS2inqgpzSNWwWq0shonv0/AxaH3Zgesoq2z/Y+H6W8vOZfZBG7rhEF6?=
 =?us-ascii?Q?0FCIDp1KhHc9LbL5E/FnVv518eppSq6/MfnerrhXFlOOOFfqAnvOhX7c2HCn?=
 =?us-ascii?Q?egbgIXwrvYzOcycwb+WJwZg7X1MiE1yLUFT7kowDSp14lpUwSslq7cY6ARmk?=
 =?us-ascii?Q?3J+SfQ6zjCMPMevx/KhGdSccPL6q746XonMsfKB7uVgHdQ9ClN58t6Mt4Imi?=
 =?us-ascii?Q?fP+FCbg6+XbioIuz2D+pqLILhFLbACvnaX0aeq7caA70UAH1W/3oM1txdc3a?=
 =?us-ascii?Q?//w8aQoAtAyiOgYryZ7to5lvvxjbTb7glfTgBU/ArW5XGVwQUcsC/IZ4sp17?=
 =?us-ascii?Q?ySOwgLv0tlMii1jhI7jhvisJjSuo8/kiKdR/mLHiFM4bZ7rHSue8o0Mi4bTK?=
 =?us-ascii?Q?abYHjscmtUgyYHQlrwrrsJHtu7GtcDpK0hqDSlYhlhosXdgKin8UChvqOYMO?=
 =?us-ascii?Q?Ecl0S3ApniI4FvMspeOv6tSI8MmgmsvTtAYOZnmpwZXoiPPFKNLfh9myaVA1?=
 =?us-ascii?Q?ih9iWB4Kp/bTeH5qs5Ko6yrAJPUcOTyN9WnyihbSx+vxrG+JDGLegycvbc60?=
 =?us-ascii?Q?LJ3fqFHUmm+yKL7Ys5Wcf8xkhnejd+q+pAFbIB/MOUavB4V3Y4nEgBtXSoDu?=
 =?us-ascii?Q?xsldB9Wxhd9dMNX+oT6a9Eo7SwdTPVLrJVDU7y+KtpM3JGk/WSPNXRy7aDkQ?=
 =?us-ascii?Q?fEzZXNgMrIIfLNm/jooLQnm1+6MUd87t2CZybkZjTXmmYUMFeQHACwFT70e/?=
 =?us-ascii?Q?xHLDH7Ym76jUmVDR696ULr0qTMeDxZZC33b9neVNahxW6BTUFGFDMUZJMzZo?=
 =?us-ascii?Q?3A4wetEmE0IaYetJ+H0HzPUkTEijz02HmOZ11s+ntYoIYoFt1u5BPWrWRehN?=
 =?us-ascii?Q?GkfzQ7VL4uqvVSolerslUbu6Fcn+LOPmCC+3wnRMW0YORWFhtLzK5ekDILIO?=
 =?us-ascii?Q?doP34hPrbCM3KFOOMXtb66ZKUUmb0TaMU+8GMFlEnJSBClWR4GwDKgf1/gT2?=
 =?us-ascii?Q?27c0wUdkZpnnPuYq0LtNwH5S59n0APD4r+0b7+bACu1elHODcaPpNoHmzF0d?=
 =?us-ascii?Q?Idu7D6J+mzjAFtJYmfSPXcI8TBpvLqfix4z1YjNUtxP5za+dr4E55KKNoTAy?=
 =?us-ascii?Q?o+JbKEYncRYzFapEaBcOFYbNHyPpalS/u902yHIE1xq/n20p3SWC8fg59PD8?=
 =?us-ascii?Q?LWSbAvtAbPf0PbzoTwGt7cUbhRCWtDC+IJgx5mzyR0F4rao+Hwn/5YV9FlNq?=
 =?us-ascii?Q?yLpmarZFYzCClAGsQwAgdsUPT2ky2OfBLlathUeX6h+OZMCXUynC9mLMvdai?=
 =?us-ascii?Q?bQMWkOvOfNUXboqFIloCOeSkW6oOeAAxdkGaEWHWmlK0cFE9Vqe70umhhybA?=
 =?us-ascii?Q?U/SJlfjzt1IncvE8ObbNkvDl/z62sX5v5gHNlnvOkckwhliWiC7ETlCZXbCo?=
 =?us-ascii?Q?kHp/jpThSIAtPkl2/9TIonJFirw4W683riHTWgr2VRgzjDwtCiULNY4DEVCa?=
 =?us-ascii?Q?Qa3r6dq/ercQwsIsWThW3Q0fnvp/y3GksmM/rUhR?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW4PR84MB1849.NAMPRD84.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: 6f1ad294-8dbf-4128-9895-08da912f48d9
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Sep 2022 00:15:49.7901
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: J6VwSNyC3QA2QRWreAGgfnAtinBH82Gsy7AMHA0OdwTGj4DwlQt/2i9UquILCZ/mGpwUm5Mgh2ApM0Lc9M2ssA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR84MB1500
X-OriginatorOrg: hpe.com
X-Proofpoint-GUID: zsu6p8GAXtFn_dm-hx3F2AbiGMaWzRS4
X-Proofpoint-ORIG-GUID: zsu6p8GAXtFn_dm-hx3F2AbiGMaWzRS4
X-HPE-SCL: -1
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-09-07_10,2022-09-07_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0
 mlxlogscore=999 adultscore=0 spamscore=0 phishscore=0 suspectscore=0
 mlxscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 malwarescore=0
 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2207270000 definitions=main-2209070089
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Monday, September 5, 2022 9:25 AM, Jia He wrote:
> diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
> index 8cb65f757d06..b0a6445c6da2 100644
> --- a/drivers/acpi/apei/ghes.c
> +++ b/drivers/acpi/apei/ghes.c
> @@ -109,6 +109,14 @@ static inline bool is_hest_type_generic_v2(struct
> ghes *ghes)
>  bool ghes_disable;
>  module_param_named(disable, ghes_disable, bool, 0);
>=20
> +/*
> + * "ghes.edac_force_enable" forcibly enables ghes_edac and skips the
> platform
> + * check.
> + */
> +bool ghes_edac_force_enable;
> +EXPORT_SYMBOL(ghes_edac_force_enable);
> +module_param_named(edac_force_enable, ghes_edac_force_enable,
> bool, 0);

Thanks for the update.  It looks good to me.
Reviewed-by: Toshi Kani <toshi.kani@hpe.com>

Toshi