Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-Data: A9a23:x/Uc1KjXQFnoVdVdklJ3fwsCX161lBAKZh0ujC45NGQN5FlHY01je
 htvWjvQPv6OZTb0LthyOoy38xlS6J7SnYJmSQFury42Fn5jpJueD7x1DKtf0wB+jyHnZBg6h
 ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKkYAL/En03FFQMpBsJ00o5wbZo2tEw3LBVPivU0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pDTU2FFEYUd6EPdgKMq
 0kv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOjzAazhHe3JrXO9I/NAB3shy4luxb4
 /kSvpifZCIABpzDzbF1vxlwS0mSPIVc87PBZHO4q8HWlhSAeHr3yPIoB0YzVWEa0r8oWicVq
 rpJc3ZUMk/ra+GemNpXTsFgj8IiIc30NasUu2prynfSCvNOrZXrEv6TvIMEgmZp7ixINfz5Z
 usrVCRrVg3FRUFSHV1KGbgMn9790xETdBUB+A7K+sLb+VP7yA13zaioM9fPfNGObdtak1zep
 W/c+Wn9RBYAO7S3xTeb83mhmvXCkAvlV48IUr617PhnhBuU3GN7IAcRX1v4reWRiUOkXd9bb
 UsO9UIGtaE06EGvT8K7Vhukp3iFuQM0WN1WCPA+6wbLwa3Riy6XHG8bRzhNLtgnr9MeSjkj1
 1vPlNTsbQGDq5WPQn6bs7yTtz73YHFTJm4ZbihCRgwAizX+nG0tpjGSCfZaOZ+8svfeNW77x
 x+niQEGtrpG2KbnyJ6H1VzAhjutoL3AQQg0+hjbUwqZAuVROdXNi2uAtAWz0BpQEGqKZgLb7
 SRbwaBy+MhLXM/SzHbSKAkYNOvxj8tpJgEwlrKG83MJzTWm+3e5cZtX5lmSz282b55UIFcFj
 KIv0D69CbdJN3esKKRweY/0Up1sxqn7HtOjXffRBjavXnSTXFLWlM2NTRfAt4wIrKTKufpjU
 Xt8WZ3wZUv28Yw9kFKLqx41iNfHPBwWy2LJXozcxB+6y7eYb3P9Ye5bbgHTMb1lt/ja8Vq9H
 zNj2y2ilkU3vArWP3m/zGLvBQxiwYUTXMqv8JUHKoZv3CI/RD1xYxMu/V/RU9U1w/sK/gs51
 nq8QURfgEHunmHKLB7iV5yQQO2HYHqLllpiZXZEFQ/xgxALON/zhI9BLMFfVed8q4ReIQtcE
 qNtlzOoWKofE1wqOl01MPHAkWCVXE3z2lrVZXT1OGNXklwJb1Whx+IItzDHrEEmZhdbf+Nuy
 1F8/ms3maY+ejk=
IronPort-HdrOrdr: A9a23:an81FqmNaqI7eoayaflwmlnZSE3pDfIX3DAbv31ZSRFFG/FwWf
 rAoB0+726QtN9xYgBDpTnuAsO9qB/nmKKdpLNhWYtKPzOW21dATrsC0WKK+VSJcBEWtNQ86U
 4KScZD4bPLYWSSpPyKhzVR170bsaC6GGfCv5a580tQ
Date:   Wed, 7 Sep 2022 17:35:10 -0700
From:   Daniel Walker <danielwa@cisco.com>
To:     Frank Rowand <frowand.list@gmail.com>
Cc:     Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
        Rob Herring <robh+dt@kernel.org>, xe-linux-external@cisco.com,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] driver: of: overlay: demote message to warning
Message-ID: <20220908003510.GE4320@zorba>
References: <20220907230709.271889-1-danielwa@cisco.com>
 <973f7127-8165-45f6-071f-04360046b7d7@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <973f7127-8165-45f6-071f-04360046b7d7@gmail.com>
Precedence: bulk

On Wed, Sep 07, 2022 at 06:54:02PM -0500, Frank Rowand wrote:
> On 9/7/22 18:07, Daniel Walker wrote:
> > This warning message shows by default on the vast majority of overlays
> > applied. Despite the text identifying this as a warning it is marked
> > with the loglevel for error. At Cisco we filter the loglevels to only
> > show error messages. We end up seeing this message but it's not really
> > an error.
> > 
> > For this reason it makes sense to demote the message to the warning
> > loglevel.
> > 
> > Cc: xe-linux-external@cisco.com
> > Signed-off-by: Daniel Walker <danielwa@cisco.com>
> > ---
> >  drivers/of/overlay.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c
> > index bd8ff4df723d..4ae276ed9a65 100644
> > --- a/drivers/of/overlay.c
> > +++ b/drivers/of/overlay.c
> > @@ -358,7 +358,7 @@ static int add_changeset_property(struct overlay_changeset *ovcs,
> >  	}
> >  
> >  	if (!of_node_check_flag(target->np, OF_OVERLAY))
> > -		pr_err("WARNING: memory leak will occur if overlay removed, property: %pOF/%s\n",
> > +		pr_warn("WARNING: memory leak will occur if overlay removed, property: %pOF/%s\n",
> >  		       target->np, new_prop->name);
> >  
> >  	if (ret) {
> 
> NACK
> 
> This is showing a real problem with the overlay.

What's the real problem ?

Daniel