Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <bc7518c8-eb89-f90b-ee99-f6082b180e2a@intel.com>
Date:   Wed, 7 Sep 2022 17:51:28 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH v9 10/16] mei: mkhi: add memory ready command
Content-Language: en-US
To:     Tomas Winkler <tomas.winkler@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>
CC:     Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        <intel-gfx@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
        "Alexander Usyskin" <alexander.usyskin@intel.com>,
        Vitaly Lubart <vitaly.lubart@intel.com>
References: <20220907215113.1596567-1-tomas.winkler@intel.com>
 <20220907215113.1596567-11-tomas.winkler@intel.com>
From:   "Ceraolo Spurio, Daniele" <daniele.ceraolospurio@intel.com>
In-Reply-To: <20220907215113.1596567-11-tomas.winkler@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZVNuSEFGRUNHQkdTcHZJN0t6SFVPV21JTklXSkhEaW9Ed2N2TVJCenhZZnBJ?=
 =?utf-8?B?WVE4bDdBeHd6SUtFU2lLNmRrcXpqbG1vK2tiNHB3N244TkZ0M0VGaXY5bGVv?=
 =?utf-8?B?dXNUeCtBWTc1c1JIbXM1ek5Pa0lFZVlmT1VPdGFjektGUVBWQ0c4b0E4U0pQ?=
 =?utf-8?B?VjNYazZOWE44WEVDaWVMVkxDditveXZyUlZ4T0xndVRSNWs3TlpmZzlBZDRW?=
 =?utf-8?B?NFBhcTlramhMOG9PTjgwaERQNVIzbWF3Y3lXbm1lcm13clhzVnZHd3Y3TURM?=
 =?utf-8?B?bHAvSzlsdE9uOVJMZncyV3JUUEV6UGlRZUNRMWh6UDBvVWY5anBOSmNiWU5W?=
 =?utf-8?B?ZE9pVUhvUlRGSXlFdHFzaHowVjEydlBkYjNRWFZMRFdrZlpnd0VraGtiTkRW?=
 =?utf-8?B?UUs5VUxBRit5UjhvZXlqZXFNMFFWOUp4em8rNzdkN215TWhzZnh3N2N6Zk9E?=
 =?utf-8?B?dlptZWxFTng2VVdqWkppSzRyUXJ1c2xKSktQSHRmOFVvZjl2WVFITHA4RVkz?=
 =?utf-8?B?WXpIVDI2S2lpU0c5L0tTa3REM2sxcUNITklRV2o5c09GMWI1eFRYYzlZUEY1?=
 =?utf-8?B?cTByR0xvV1F4cDNjb1daeDNpVGJrc01vb1RjZS9UUXpXelIwcTVYV3pCQU4z?=
 =?utf-8?B?U05GZW9MYVlOaEJDRHRPM0xOVktmRitTVlU4Ukh4TFZKZzQ2MlduOXE4Q0RO?=
 =?utf-8?B?YXpzQktHYjdrdG1SNXRkSkcyT3A0blA0YXIxd0c2aXVyR2oyZmFOYXhaaUtM?=
 =?utf-8?B?dUlHUEVmVENLUTRMTGdHK0Myc2FoWTRVNm1DblRXbVpPcTlkTlFHWWh4SE5a?=
 =?utf-8?B?VEFEUURyelNZNUsyay9GWVNhdCs1TDdFRm04TEtpMmsyS1hwZmNtQnZvMGYw?=
 =?utf-8?B?ZmZ6YThid3Jqc2kxMlhuYXFCVG9UQk9Cbmpuc1VtZTFNRkRQVm50TElOUW1y?=
 =?utf-8?B?K2orSERIbzc1V01NZFpmRk90M2hHak8vTzZ2cEFsU3dHeHB4Z0cxMHh5a3RY?=
 =?utf-8?B?aElmQlpUMjlwMGJaSkJSQnFPNXI1UVpsZ0wvUzYyVmwyc244MitVVERrWjJz?=
 =?utf-8?B?WmNNOHpoOEhWNDlUY2RBaGJwdFlXRmZpQ3hpd3R3U2FERzVBUjhRN0JwRkF1?=
 =?utf-8?B?OWRhdU1RcFc3WVVMN3V1amVhaWFMcEVMTWhGdHlwM2QzeXVqUFBGTzAxMFNB?=
 =?utf-8?B?VTBzbjRvYk1WNlAwOG5YOVZpV3BFVDVlMWZrVkw1dFNJUEVYM0hhMWxPanpH?=
 =?utf-8?B?bmJkZFpBR0p2aWNXMi9NdUpibVkyS1d3TGxzeEoxL3kraTlzekpNTTVlUlQr?=
 =?utf-8?B?K3BEYlpQbnpQUkNONWk0REQ4R2ZSOVRFdUdqWlpGUnNhNlJWUS8vVjRJUXFR?=
 =?utf-8?B?NmxpY2poWkRlU2VPM1hYN21sU2hVOWlXVVVmVzVZRE5hbEZrYWFacVJkdlVz?=
 =?utf-8?B?OEhoaVpraWVNU2Z0RmVaeHgzQXhkeDRRcTZQanJhRURDWG9RczI4OFpSd2FG?=
 =?utf-8?B?cUIzODdtZDRWNzAwM3FlN0dSdVhFRGhPOWxycndGRmR2clJRTUVyUCszb2sv?=
 =?utf-8?B?SXBjUUxoUHZLMmEwbGtERmxadVUwM3M3VU1oZGxOc1kyZmlVMjA0aDFpdzR0?=
 =?utf-8?B?NmR3OTBwMUhQOFVIMlN5cElxM1p4MVRzbldiM1NsaWRBRG9FM1V4aWlzTzdY?=
 =?utf-8?B?TlRhOE1MOWZsWEZoc21JSUk3N0lzbHVzd3UzYkZKY0h6UEltN2gvb2FBVEtX?=
 =?utf-8?B?aGc1QzgwK0ttS3lZZ3VBOGtUaW9HQThhVHpxbkM4KzZsamJ6eThtSVVyQm1t?=
 =?utf-8?B?bCtDdHhkRlVVS29jVmFsYVJPdUJuVmVidUJyalFkUHRMeTNMT1BkT1FsVmdR?=
 =?utf-8?B?cXYreGRUREdnT3l1cnFHNEJMa0Z0RG1qd2RBaVF2TjF1U1NLeEdIcjNRQUZO?=
 =?utf-8?B?MDBNZFJzd0lCWlpQeTBvelFJbStRSXlzQkpwcUhhZ2NkeHdXdXlrM2U4ZCtq?=
 =?utf-8?B?NVIxZ2cyYjB4ZG1CcU1xSHNaS0tuYmhJTEkrZmxCRGR1dGJxVHFFV0ZzN2Uz?=
 =?utf-8?B?TjRPUVk1OVl2Y1ZjR0pwNlpVN2tOUzl3Zm1EVTg1M2FGeGhvNnRhUlBVOE94?=
 =?utf-8?B?R3BpN0hXcXd5Mnhkd3VmaWxjMVo3VUgxemREcDBXcnk0NTY4WVd4UEVZczJG?=
 =?utf-8?Q?XZqomjGuxmaWeuYOa4M59A0=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: dbf8e115-9c55-4fe8-ac9e-08da91344516
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5488.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2022 00:51:31.1206
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lgX8sszdH2K4D+/I1mYj39FW3E6X13VK4mIQBmID+Yr8nc0KhNT/EKMNxNRJg8jWHX+9vxNFmM9liUg0F98yXyx9vUSeRdDBmM8sdfQdvys=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4717
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_HI,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 9/7/2022 2:51 PM, Tomas Winkler wrote:
> Add GSC memory ready command.
> The command indicates to the firmware that extend operation
> memory was setup and the firmware may enter PXP mode.
>
> CC: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>

Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

Daniele

> ---
> V9: Fix duplicated defines caused by wrong --amend
>
>   drivers/misc/mei/mkhi.h | 12 ++++++++++++
>   1 file changed, 12 insertions(+)
>
> diff --git a/drivers/misc/mei/mkhi.h b/drivers/misc/mei/mkhi.h
> index c3fa3c5d5cb6..1473ea489666 100644
> --- a/drivers/misc/mei/mkhi.h
> +++ b/drivers/misc/mei/mkhi.h
> @@ -16,6 +16,13 @@
>   #define MKHI_GEN_GROUP_ID 0xFF
>   #define MKHI_GEN_GET_FW_VERSION_CMD 0x2
>   
> +#define MKHI_GROUP_ID_GFX              0x30
> +#define MKHI_GFX_RESET_WARN_CMD_REQ    0x0
> +#define MKHI_GFX_MEMORY_READY_CMD_REQ  0x1
> +
> +/* Allow transition to PXP mode without approval */
> +#define MKHI_GFX_MEM_READY_PXP_ALLOWED  0x1
> +
>   struct mkhi_rule_id {
>   	__le16 rule_type;
>   	u8 feature_id;
> @@ -40,4 +47,9 @@ struct mkhi_msg {
>   	u8 data[];
>   } __packed;
>   
> +struct mkhi_gfx_mem_ready {
> +	struct mkhi_msg_hdr hdr;
> +	u32    flags;
> +} __packed;
> +
>   #endif /* _MEI_MKHI_H_ */