Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Kani, Toshi" <toshi.kani@hpe.com>
To:     Jia He <justin.he@arm.com>, Len Brown <lenb@kernel.org>,
        James Morse <james.morse@arm.com>,
        Tony Luck <tony.luck@intel.com>,
        Borislav Petkov <bp@alien8.de>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Robert Richter <rric@kernel.org>,
        Robert Moore <robert.moore@intel.com>,
        Qiuxu Zhuo <qiuxu.zhuo@intel.com>,
        Yazen Ghannam <yazen.ghannam@amd.com>,
        Jan Luebbe <jlu@pengutronix.de>,
        Khuong Dinh <khuong@os.amperecomputing.com>
CC:     Ard Biesheuvel <ardb@kernel.org>,
        "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
        "devel@acpica.org" <devel@acpica.org>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        Shuai Xue <xueshuai@linux.alibaba.com>,
        Jarkko Sakkinen <jarkko@kernel.org>,
        "linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
        "nd@arm.com" <nd@arm.com>
Subject: RE: [PATCH v5 5/8] EDAC/ghes: Make ghes_edac a proper module to
 remove the dependency on ghes
Thread-Topic: [PATCH v5 5/8] EDAC/ghes: Make ghes_edac a proper module to
 remove the dependency on ghes
Thread-Index: AQHYwTvPhGTT0EVTLkKX2LSEZ7veqK3Urj8Q
Date:   Thu, 8 Sep 2022 00:31:18 +0000
Message-ID: <MW4PR84MB184996C9B94E6F5DA3EBB11E82409@MW4PR84MB1849.NAMPRD84.PROD.OUTLOOK.COM>
References: <20220905152439.77770-1-justin.he@arm.com>
 <20220905152439.77770-6-justin.he@arm.com>
In-Reply-To: <20220905152439.77770-6-justin.he@arm.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1Fdtw9YsS0YB8cnTovG91n53E3At8xa0dw7m3r1cNKJlrgIOAB4wRmJCdzAb?=
 =?us-ascii?Q?yqjEdQO2U8WZqyoEu0MwBkSnXBV0GLlgEh1fNl7mMzssUiSRy0eu0iAi5qGy?=
 =?us-ascii?Q?Vxyoge86SgGNRJzF7q6f19qgeCnMZ+AMBAQHjRGg6Z9pT8XOwFlXD/njNJMp?=
 =?us-ascii?Q?250H1h0wY01KbFcd/d+NXyExSsXUfrTnknkp2TVLtYRORviFg8uWGe8HZ9jd?=
 =?us-ascii?Q?SIgmKQACuGaE3kP1/wZ38+W83fKaSk2jnunCUXeVPehWq50t7oCSM/+bHjoU?=
 =?us-ascii?Q?UyU8XgfWQxC1RJrHrkfYPnpx00+y6gcV6esleK/uuFopELiK0R5yKlw3GdkT?=
 =?us-ascii?Q?TS4Pu9pCOXG0LuPViqy7kvSpyuvSBtwX3R4tOWpdwP9S+yLZedGZHi/MACPT?=
 =?us-ascii?Q?s69i4siuLj89vv0jHD2R6JhPo2GbvFJvAYJK8kRySsRlS5HeEGMgpaVS+9d5?=
 =?us-ascii?Q?5FbTfBJbJ6PtQySZtRzLGxYHmc65L7zGijoPlGPbD1/E098Qxg7WCQjpZdam?=
 =?us-ascii?Q?xHCl8EeXLRRmv5HW2frgTK03q+b1w40pOb3YKgnmzzAtuFP+14xZBsKMqocY?=
 =?us-ascii?Q?OK/KLPy3ukmEssx0GtXpQZP5b4VpimzpIN+U7iS2n7kKTQlpAUi523BCU4KS?=
 =?us-ascii?Q?IeO8KSYBCgCu55/nPhpyfvIs1HcMO+8eMhMcVfvmQm1H+ZwfLjXYmM5LAWRZ?=
 =?us-ascii?Q?jgsRh2hUEHM72C5sQHAlMvrjoOH9MvSh9kc7pcfFZcFjSJWicnSIojgw1xEM?=
 =?us-ascii?Q?Crn4I95jAC9udzsaU8dP+GYQ2aEOwG+Mg76iva8GMFDRLrGjIXh0swEbtgIL?=
 =?us-ascii?Q?ATHoxm9G19WiWs0p/mnfQ9NE1t/gQmYDK/uOwATQcPNvlXIjuK5W8aOZjS5C?=
 =?us-ascii?Q?W83cTQ11F/NkBnb03qvS6Zw+1b0vdFVsxh1xD4kLiVRxqwAJq6y1DhST63Ng?=
 =?us-ascii?Q?4hmZqfHDKN80GuC7D8FrEZLyUDJHsPkYWdwGxS69iLxOkzTDmudHkAs1dmvz?=
 =?us-ascii?Q?hh3e6BiReOHYB4zQiXNkwwVtwZYdlsGi2t+4V0bLy2Yix5nqTO10KrPogdFk?=
 =?us-ascii?Q?ruuWBTCUK4gSRuJqSeBDw6sUPSJiBv1vt/IFmC3HJmp5uNodW36eRQ2GoIbp?=
 =?us-ascii?Q?5UZVP6AoYErm9U2Oy3hWYSo2wFKHxdO6Yd1jAUM0BErzFsbVIK85hOWN1cJj?=
 =?us-ascii?Q?3HPR3CcyehgfjY4gYj0zqwUaxy3gSaswulaumjJRi6uTFqY3K2ijtnDxYd6H?=
 =?us-ascii?Q?vd5BXmptBnRF5ybKBi+4yMGc7Qcx05gBIrMHfy44HS9clP+Q8aeHVhIEJ3KY?=
 =?us-ascii?Q?/FN5iI5Pb/H4J57DOep4rpRUv9R64ojX0NkRNGBBq3szq/PtEFs+2sRDNFSM?=
 =?us-ascii?Q?DkJXyb7J+B9CgyW1jNa7pxdde7M+DmD28jh2/S1cV4jL/U59qZWZDXzS4uwN?=
 =?us-ascii?Q?Kvx8XL2qJ8NBARpW2oGLO7Eb1Rha2RyZiXkhUEJuUivr6nXNoH53/7347ALk?=
 =?us-ascii?Q?ryLdzCb8tItvh9dot0aX4DixJPLte0xYZEPEBoRVXr2tZ0h/+fHVddv07Jef?=
 =?us-ascii?Q?Dd0+kiAHu19tRDY/09zZuy74cnRsceVqu2tOCeUu?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW4PR84MB1849.NAMPRD84.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: 69defecd-dbd4-4a8e-5101-08da913172a6
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Sep 2022 00:31:18.9118
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: AQNALoTtZYi9xm4ltvO0t//BOQIWdo78/KllyTdZgVn9s2DeHdAAPQSX6ZB3+yD+nmz7HhPOW4noZX37gf9IVQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR84MB1811
X-OriginatorOrg: hpe.com
X-Proofpoint-GUID: m8ed0dglT98T6lL-UUukz1cjYd7_ayuq
X-Proofpoint-ORIG-GUID: m8ed0dglT98T6lL-UUukz1cjYd7_ayuq
X-HPE-SCL: -1
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-09-07_10,2022-09-07_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0
 mlxlogscore=824 adultscore=0 spamscore=0 phishscore=0 suspectscore=0
 mlxscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 malwarescore=0
 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2207270000 definitions=main-2209080000
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Monday, September 5, 2022 9:25 AM, Jia He wrote:
> -void ghes_edac_unregister(struct ghes *ghes)
> +static void ghes_edac_unregister(struct ghes *ghes)
>  {
>  	struct mem_ctl_info *mci;
>  	unsigned long flags;
>=20
> -	if (!ghes_edac_force_enable)
> -		return;
> -

I am not familiar with this original check.  Assuming it is safe to
delete it now (as you mentioned in other email w/o description),
I suggest adding some description to the commit log.

At high-level, the patch looks good to me.
Acked-by: Toshi Kani <toshi.kani@hpe.com>

Toshi