Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 8 Sep 2022 09:18:32 +0800
From:   Huang Rui <ray.huang@amd.com>
To:     "Meng, Li (Jassmine)" <Li.Meng@amd.com>
Cc:     Shuah Khan <skhan@linuxfoundation.org>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
        "Fontenot, Nathan" <Nathan.Fontenot@amd.com>,
        "Sharma, Deepak" <Deepak.Sharma@amd.com>,
        "Deucher, Alexander" <Alexander.Deucher@amd.com>,
        "Limonciello, Mario" <Mario.Limonciello@amd.com>,
        "Su, Jinzhou (Joe)" <Jinzhou.Su@amd.com>,
        "Yuan, Perry" <Perry.Yuan@amd.com>,
        "Du, Xiaojian" <Xiaojian.Du@amd.com>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Borislav Petkov <bp@alien8.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RESEND PATCH] cpufreq: amd-pstate: Add explanation for
 X86_AMD_PSTATE_UT
Message-ID: <YxlC6F8NVeY1Gv27@amd.com>
References: <20220908002821.1648880-1-li.meng@amd.com>
 <20220908002821.1648880-2-li.meng@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220908002821.1648880-2-li.meng@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2RZaE/A4DmvS2J1PHCfmGifdSGLZjYc4wyrFU6pxET2FnCtFDmjo3d0NQx+X?=
 =?us-ascii?Q?uPs2UVjGdr5iIbW5A/5/Br8WKo8KJheoWrtMiSiN5sNmfG62j3XzlkfG2puE?=
 =?us-ascii?Q?Mb2+Ga71oB47Q/8tQlW2Ki8iIb55WJhT2O4QPFRrT6MTkI8K+POY11/4DowI?=
 =?us-ascii?Q?CeEzrOTXw9+g0s+YY9mdUb6Uz236WxfRKBEOYLx+Pi+YhMg6BipS4uxLVcr+?=
 =?us-ascii?Q?8R/aOrhnstvsZwl5tMNzV3tddlJwmYMKA5ru2QX5zbREaxnavSRbrBK7PoiF?=
 =?us-ascii?Q?pgBbXBY52+fLNudZBfI723oKUDBvCYDP4VMZdgJshqpYaSBmYtAKo+ddHh2g?=
 =?us-ascii?Q?yPvk68pcraYS5ZEoaTjW4GNd6ALUdtSw5tFK6MK+gPYBhatlw+dcnMjLEaEd?=
 =?us-ascii?Q?n/Yh/6L9/z+s0z6lbGSIyUmRCeVV96iDaEEn6eybExt13A3sZEnfPJevnSoi?=
 =?us-ascii?Q?v0APy9s9ajAtvs+1h0pxABsbIHcwbyUrxeO3JGJtKFHYbI7KYjxGgirpbX1D?=
 =?us-ascii?Q?STp7fF/Ue4VIZ5IzJCDcqorwbwKkuRa5yTmylyykAywY1/dba+CXV9Lk6+Jr?=
 =?us-ascii?Q?zTAU/3TI/WbcmFkLMryXN2rqG/RNiN9btvSttAsiEGZPABHwIT0Kdd9qyN7k?=
 =?us-ascii?Q?JSV583R938orBJ3n9yfWfVVrtbvcp3tA6J3VfPbfbswYedYvCVwEbFbIHAlD?=
 =?us-ascii?Q?mfTur8at/ihw61dali1GieMdVo84EYAIBdK5LjXkDskAT79xPUXlTB45UnMn?=
 =?us-ascii?Q?QSJdp8CBROIE88A7XiNsUAOu4LtaV/xPQhViftDTkpXJzqWjy0NZ98E2c06D?=
 =?us-ascii?Q?3/d+KfAzqf0SmLGfwOGjfxvsQ5xB2bb4c4/ynr5FDGDeUaUs5EoA6gAznB+H?=
 =?us-ascii?Q?kQLLyZUxNWIxKoqwo2BEjv19bMnB4AE3NbqEHMrW/3f/C54LwHYp8ielkOra?=
 =?us-ascii?Q?239XZafGaEI4s77S1l21FnERFLbdCwJa4+0o4vSbPdrQVARh9huJf8XPfOOz?=
 =?us-ascii?Q?r3IMx7oyC+BI0AgHUQW0iFzvh3s40stiv9KqAqEbFG1j790j9RNYielIxTB5?=
 =?us-ascii?Q?FF3vB4B93MAp4YJHnk7XP7axMpJDuEydIivdAH1qN0e8+MFLwwlPSge1PMYC?=
 =?us-ascii?Q?+sf+csasiFXb1kPx7XPf32cvKA1ufe1S/i5Qqhqf853P4HiI/mgSF5d0jFw3?=
 =?us-ascii?Q?fPTUimZfJtXu0QtzgsFrG8xJeMcOPdK8EgWCa4lT9MmzKokHP30IAghWql6o?=
 =?us-ascii?Q?YQdy2LzvB3wpf/OAygl3YT2luruDWkxC/QoBS1pyhYQPmr5GWnYMYihh5JHh?=
 =?us-ascii?Q?AN2ecmvkktSfbv7xAOiW59otKj7Rfsoj7b3wroAKZI8lylZpfxjJufm5tpi3?=
 =?us-ascii?Q?XWHwu/mNmIfCTlKSLq1kr6qKu09y4rIxS9Axnm/2LMh+yZh/lJ80ISp/wzbq?=
 =?us-ascii?Q?Fz9n1R7e+8v9qw3CXe8HLWYw9x/hNXH98BNbOzX+XPgjjKsyws82W1tQGCZh?=
 =?us-ascii?Q?Bj7CWM1JgdAQOdZblxARymetmie7f3ltAidlGE1zTcDZvFzaH96uMcLZE6ye?=
 =?us-ascii?Q?m4yRt1aNmReZkbr1e95BnVQzP4oGYe3DkCqrQLVx?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 28f86d69-ae2a-4ff4-e28d-08da91381a82
X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB2504.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2022 01:18:57.6890
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: I7b65kxLAZ/nHBFIc/msKVe3CarnAZolvgS9QE92JKCGZmEjy3r1xvbpDVhBqU1Lc6u9g56p4o4Xrbpg3aR2nQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7154
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Sep 08, 2022 at 08:28:21AM +0800, Meng, Li (Jassmine) wrote:
> This kernel module is used for testing. It's safe to say M here.
> It can also be built-in without X86_AMD_PSTATE enabled.
> Currently, only tests for amd-pstate are supported. If X86_AMD_PSTATE
> is set disabled, it can tell the users test can only run on amd-pstate
> driver, please set X86_AMD_PSTATE enabled.
> In the future, comparison tests will be added. It can set amd-pstate
> disabled and set acpi-cpufreq enabled to run test cases, then compare
> the test results.
> 
> Suggested-by: Shuah Khan <skhan@linuxfoundation.org>
> Signed-off-by: Meng Li <li.meng@amd.com>

Patch looks very good for me. Please feel free to add

Acked-by: Huang Rui <ray.huang@amd.com>

> ---
>  drivers/cpufreq/Kconfig.x86                         | 8 ++++++++
>  tools/testing/selftests/amd-pstate/amd-pstate-ut.sh | 1 +
>  2 files changed, 9 insertions(+)
> 
> diff --git a/drivers/cpufreq/Kconfig.x86 b/drivers/cpufreq/Kconfig.x86
> index fdd819069d72..310779b07daf 100644
> --- a/drivers/cpufreq/Kconfig.x86
> +++ b/drivers/cpufreq/Kconfig.x86
> @@ -58,6 +58,14 @@ config X86_AMD_PSTATE_UT
>  	help
>  	  This kernel module is used for testing. It's safe to say M here.
>  
> +	  It can also be built-in without X86_AMD_PSTATE enabled.
> +	  Currently, only tests for amd-pstate are supported. If X86_AMD_PSTATE
> +	  is set disabled, it can tell the users test can only run on amd-pstate
> +	  driver, please set X86_AMD_PSTATE enabled.
> +	  In the future, comparison tests will be added. It can set amd-pstate
> +	  disabled and set acpi-cpufreq enabled to run test cases, then compare
> +	  the test results.
> +
>  config X86_ACPI_CPUFREQ
>  	tristate "ACPI Processor P-States driver"
>  	depends on ACPI_PROCESSOR
> diff --git a/tools/testing/selftests/amd-pstate/amd-pstate-ut.sh b/tools/testing/selftests/amd-pstate/amd-pstate-ut.sh
> index 273364650285..f8e82d91ffcf 100755
> --- a/tools/testing/selftests/amd-pstate/amd-pstate-ut.sh
> +++ b/tools/testing/selftests/amd-pstate/amd-pstate-ut.sh
> @@ -32,6 +32,7 @@ fi
>  scaling_driver=$(cat /sys/devices/system/cpu/cpufreq/policy0/scaling_driver)
>  if [ "$scaling_driver" != "amd-pstate" ]; then
>  	echo "$0 # Skipped: Test can only run on amd-pstate driver."
> +	echo "$0 # Please set X86_AMD_PSTATE enabled."
>  	echo "$0 # Current cpufreq scaling drvier is $scaling_driver."
>  	exit $ksft_skip
>  fi
> -- 
> 2.34.1
>