Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 7 Sep 2022 22:48:57 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Robert Richter <rrichter@amd.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        "Ira Weiny" <ira.weiny@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        Dan Williams <dan.j.williams@intel.com>
CC:     <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Len Brown <lenb@kernel.org>, Robert Richter <rrichter@amd.com>
Subject: RE: [PATCH 02/15] cxl/core: Check physical address before mapping it
 in devm_cxl_iomap_block()
Message-ID: <6319824968fa7_580162946f@dwillia2-xfh.jf.intel.com.notmuch>
References: <20220831081603.3415-1-rrichter@amd.com>
 <20220831081603.3415-3-rrichter@amd.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220831081603.3415-3-rrichter@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rp9G8EhOZLXV9pT6sQEWkoCNtSV/AIuOapr6/3TvBpdlPqu1+OZuM4IOJFqf?=
 =?us-ascii?Q?1SP9/I0ZNTJJiZ+Z57p0FPfbRx1DRBs3tGoMJ7CZ146ZO+2JM9jGXMDpFrYF?=
 =?us-ascii?Q?808rEStyk2RqNPcyXTrW8zEU3+vuI7T1dsfJNDMSoBzFoLYUipUxVSHqX/Sq?=
 =?us-ascii?Q?N0ErgxdYNtLQ9RRdCc9aZQxaQ83xDn1tcACD8mGZo9iu2cHlwTR/4wguZ4Aa?=
 =?us-ascii?Q?zOK+RtsZNZwBwVo5cq4HStZwnVlgJ3j+cZHZ1qhYZ5yKZ8F3KBSeCKux2KUK?=
 =?us-ascii?Q?i+u3N8h40VgQlSShSg8mnsiJZljsoveHVIzWBv7NorSUo+AonzrPAJ45WSt6?=
 =?us-ascii?Q?MJMU/45T4dQSvf3ZqYlWJS+o3iQJUwUDmQX0IMyweqIBD1gU/4jG8vzl2rvH?=
 =?us-ascii?Q?zNdLwEPYA/KWd4ZGBZOtQQru3M627JArK4u1RxihfBkXVDLy1LMYMHnDXqH7?=
 =?us-ascii?Q?vlh43L7ks2X5j0BbGc0mSuVlHYqJfFMha+B4fc/CxZoEa22gffmniHWnobr9?=
 =?us-ascii?Q?DPVC0/+ztydZJsU3l4YrRTfgof+GvbtbGnO5PKSxmHryqg8dhvM25mkE++fK?=
 =?us-ascii?Q?9ugIZm1T5Pf1+9pXwNCP+iD3o5g+ZZmDqnmZ9WgjyAXCVsA6P8gzefaf7HSN?=
 =?us-ascii?Q?x8+Hup01fjH4XTJz/iLqdnKLx5Gg/KTtGif6rM79kdA/3c7hMtnCV5CjplsR?=
 =?us-ascii?Q?PWNKpyc5rEpD0DrazzOrj5tCD3Ct4sROcrg42RhKFhOEgwj/ZLVuyQNIRQ18?=
 =?us-ascii?Q?qx4PTZYdSLNcDr7+KEOAjasjgN12pU9/ljchqg1+IAW2nTSDxdsTjlva0BrV?=
 =?us-ascii?Q?Bx6c4XJPqwcXNVM/LsKzcuG9tz57WPDKR8Z0GR+6QzrY8ARkUg9im09Bcpyu?=
 =?us-ascii?Q?wazsu3tOgUpGqHv2VK4DUUwuNYZ9rfFZRfaZTdZA82AeiHHVCnISSMrqljHQ?=
 =?us-ascii?Q?IbMqtmPiFcQyNSMPozADdpPrY/2SE1B6p38X0yjc0/MniBdqLqcxeUXbYTsl?=
 =?us-ascii?Q?qbg+tSEaYS3jqo9Y0hb+T2lyWmjiW8f1AyG5priJ6fOJVrd251AdtNorocBL?=
 =?us-ascii?Q?TO7werCa0Xh5usJov/ucoQR2mkghXSevKu8tIOLQvipcJqcd4w2vDh2iLZ1h?=
 =?us-ascii?Q?JYfWSmh/IInwVBmIQEFizm+UsBXrzBZol0RtCU1scPHVTgnAuNdjToc12toU?=
 =?us-ascii?Q?hDumR0l8guLzyDSmzgxATRW5nDRT4c5VceXC0pn9cbXUUT3z1D4NPE/G6u+e?=
 =?us-ascii?Q?TA/oLu2pPqYHlBNQq57zGaMVFop1aY1zhI3lRHlewwl81mkP4zUVi3stvgo9?=
 =?us-ascii?Q?8kNxj4w+GvsukskT/yHjH7t9TUuJuvNja0+m5B1Sn/LZ7MqJTMK+jpmy1s1R?=
 =?us-ascii?Q?vQp7SEzlQBBbdc+8WU0wd4wToCcnJnGQIUjZ/OUM8vM43pl2KbI19WtcEkf9?=
 =?us-ascii?Q?bpUciZmVCUenz3cWWhUq3AwpjWahuXcZv8jO1RPXdhds8xkO4tCNLP5VcCb1?=
 =?us-ascii?Q?bexz58MyuNzEQqTGA9ABAaYpIALm782FjZ+vAUP9JJ6DBL/irJGvzEyIAIdg?=
 =?us-ascii?Q?LiZPb9L5KVZ4CIQWpe7zBNz5w2OaS0qS6WOX661x5H3GR0ZPSjgzMAZMuF2x?=
 =?us-ascii?Q?/g=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2e9be781-4fd9-40aa-e673-08da915dd3dc
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2126.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2022 05:48:59.9895
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: y361tmUAk6fO0uztD36f9o6ycjRJHb8Rzjch+qaT3+N34bpVPGeOrizhhyoTy2Ek2F2NALVyWGXvNNgLalEys340seq2j5P/seGPklou8oA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB7032
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Robert Richter wrote:
> The physical base address of a CXL range can be invalid and is then
> set to CXL_RESOURCE_NONE. Early check this case before mapping a
> memory block in devm_cxl_iomap_block().
> 
> Signed-off-by: Robert Richter <rrichter@amd.com>
> ---
>  drivers/cxl/core/regs.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/cxl/core/regs.c b/drivers/cxl/core/regs.c
> index 39a129c57d40..f216c017a474 100644
> --- a/drivers/cxl/core/regs.c
> +++ b/drivers/cxl/core/regs.c
> @@ -165,6 +165,9 @@ void __iomem *devm_cxl_iomap_block(struct device *dev, resource_size_t addr,
>  	void __iomem *ret_val;
>  	struct resource *res;
>  
> +	if (addr == CXL_RESOURCE_NONE)
> +		return NULL;
> +
>  	res = devm_request_mem_region(dev, addr, length, dev_name(dev));
>  	if (!res) {
>  		resource_size_t end = addr + length - 1;
> -- 
> 2.30.2
> 

devm_request_mem_region() succeeds for you when this happens? More
details about the failure scenario please.