Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <Kumaravel.Thiagarajan@microchip.com>
To:     <weiyongjun@huaweicloud.com>, <arnd@arndb.de>,
        <gregkh@linuxfoundation.org>
CC:     <weiyongjun1@huawei.com>, <linux-gpio@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH -next v2 1/5] misc: microchip: pci1xxxx: fix error
 handling in gp_aux_bus_probe()
Thread-Topic: [PATCH -next v2 1/5] misc: microchip: pci1xxxx: fix error
 handling in gp_aux_bus_probe()
Thread-Index: AQHYwsfi2OCdGO+Jl0GHAVIhlnqa6q3VBr6Q
Date:   Thu, 8 Sep 2022 05:56:58 +0000
Message-ID: <BN8PR11MB3668709A318C10F19261FB6CE9409@BN8PR11MB3668.namprd11.prod.outlook.com>
References: <20220907145808.1789249-1-weiyongjun@huaweicloud.com>
In-Reply-To: <20220907145808.1789249-1-weiyongjun@huaweicloud.com>
Accept-Language: en-IN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?HQnJEI1zaFscss1A+kjWjgAg38MHW72YChsoNaton8SgFSFucAG/Syen7sYJ?=
 =?us-ascii?Q?8ozfdSz8KBqGERKfWycYAqn2BW94pGKnd//sJsY2TZ0NARF2VGzp/2VKc1kc?=
 =?us-ascii?Q?G1EooRymvouWn5U5+cgJbOVS4QTZjup8RNSgWI+pX7h00KLpK9uYcwE0bDMg?=
 =?us-ascii?Q?lYxZaf775W0Wq0rWbBSymxY5pqpRWEwue6kdl2ESkpBLz6WLBgcJIJUWUAzE?=
 =?us-ascii?Q?UkJLsizV5jctCcEWWOWqXqsDCQmAcDhRRuZSPmXXXplomepyDJbTW6oOIbAv?=
 =?us-ascii?Q?59sZEFPa1Y38l1pCpfw0eGsCvG06twfeQDxJ8Rjm6793P3L1R2ogjBEFxvrB?=
 =?us-ascii?Q?vmjPiE866fK/r+1m8dowHAnHM7Zb7KKKnjAAos6/L+pyg+Tk8vGS70DHLrFh?=
 =?us-ascii?Q?Pq44HNlrDVkxpgqbB+X0sZ2mXfLkK5ehKxxAxlGPBKpN/1oNsPMye9xxUU29?=
 =?us-ascii?Q?bVYahNF+iNFW+al1R/mrkYMyM5c1HNZmwY5HYP+M++O8qf0ljcT3k/NruaZq?=
 =?us-ascii?Q?A33EJL+ARZ0XGsNPfVryhL0GAYn71hhIEDgWplgMCkWN77UFwoQMi4inabo+?=
 =?us-ascii?Q?6flGtwhOoCSK7TG2HSfbkY6Tyq4dlExdz8gK3Cg8hpM8KAWKQQhWXgjuflQT?=
 =?us-ascii?Q?kdjBj3lT40HU3ODvgOd0wFtY7NmLjfbJme/zfEh7+R59YGUn+2VpHrwF56OK?=
 =?us-ascii?Q?SUhwXLjWqlp0bK5pEfCx7BfayM19XAZ2y5esHTN6bST6EShpWvvVH7UZGG77?=
 =?us-ascii?Q?57tVzE+3POovTyknaxt8wzZrAmLJAc1wltiUuAMVvomzDItNOvUod+JqRqWb?=
 =?us-ascii?Q?qUp1DRQaayAWa5OQliWrC8/wLuokZSCNm+bnItOrZ0YDFBVOBJMraanicfGG?=
 =?us-ascii?Q?iyUS+cXGd+wN5prKkT05YOxULsix/Xqvi/cLtHufoO/by6axHgd5SzkWCjzj?=
 =?us-ascii?Q?kseG3ZG4ygmqjiIpQkWeHi/jU2lbbhryuL8dMEG518I+poEjadPelB2aSDnv?=
 =?us-ascii?Q?RPUWTVDumbyhZp5roeweTKcGsatW1EU2w61XJPj/Bhs+jUVzmbJKRKvU+ZON?=
 =?us-ascii?Q?YIVHk9tX+7YhF8stHWKSXF8ig+M48EHHnZabnuoASg/mX958En0UVYncR3Ru?=
 =?us-ascii?Q?e/82DZMQ3VYasbnuCdYikEJHMxt/G4RpmczmBpa+FNnTMTiK/Qr0AqIzboJA?=
 =?us-ascii?Q?0FBONgBPTPhDtLDIJfHue6TAeHSqPnt+hWYvNyN7OVxSMYA1B5Rqs0jibZzY?=
 =?us-ascii?Q?Ic/8Kk/sxXh0OP5SY1GAeKDUxUH+SwWMrqveMUP3sgpvx+5Ga7BLL4H4DdA+?=
 =?us-ascii?Q?t1Trpk8L5Vkrh0P+3vFIMNjJh1yC6MCqyRNQl805RNjU/gByQ2uq0rqzyAoU?=
 =?us-ascii?Q?dLDWYf+7iYbuMy2Utl1cAUpT6UUIjq0rcFnDQIs4fChCPm1KHCFK26jtbHjR?=
 =?us-ascii?Q?eoOJhNN+tYpUW/N1JwpE9SnuQUWznAvbF8sFeWgLMOyT01bA2IcSrNzDiPr0?=
 =?us-ascii?Q?WebUqJ5k8A8WIOejb+L3zZIVibuJ09xO/gsv/cUOUn5ZWivHXdaD0MwHkIdi?=
 =?us-ascii?Q?6BoLo+6jyl5TvJvwnb0CwC0mTvNTm0z+5myTgIAMVGgttc29dPHPBLWshLsY?=
 =?us-ascii?Q?9Wt59ciVpCKwd+1Tw5vTD80=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3668.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 71bb0210-506a-4b43-b7ee-08da915ef15f
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Sep 2022 05:56:58.8413
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: EKk8PJK8BcWOMkIFswR5E0RCIkn8FYV1/l9Qdbg916xggYhj9HW3akgoUZLawSLvYSVLwxgFIBM1P6dKd73+O9IeurprZEvzc+Qw3gLI8aFHMPVVgzlmwd9vPcLMGQJs
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4119
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Wei Yongjun <weiyongjun@huaweicloud.com>
> Sent: Wednesday, September 7, 2022 8:28 PM
> To: Kumaravel Thiagarajan - I21417
> <Kumaravel.Thiagarajan@microchip.com>; Arnd Bergmann
> <arnd@arndb.de>; Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Wei Yongjun <weiyongjun1@huawei.com>; linux-gpio@vger.kernel.org;
> linux-kernel@vger.kernel.org
> Subject: [PATCH -next v2 1/5] misc: microchip: pci1xxxx: fix error handli=
ng in
> gp_aux_bus_probe()
>=20
>=20
> From: Wei Yongjun <weiyongjun1@huawei.com>
>=20
> In some error handling path, resoures alloced may not released.
> This patch fix them.
Greg, I have identified some more improvements necessary for the gp_aux_bus=
_probe function.
I am working on it.
But this patch can still be applied.

>=20
> Fixes: 393fc2f5948f ("misc: microchip: pci1xxxx: load auxiliary bus drive=
r for the PIO function in the multi-function endpoint of pci1xxxx device.")

Reviewed-by: Kumaravel Thiagarajan <kumaravel.thiagarajan@microchip.com>

> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> v1 - > v2: add fixes tag, fix pci_alloc_irq_vectors handing
> ---
>  drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
>=20
> diff --git a/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c
> b/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c
> index bfc03028b34d..11f79f239006 100644
> --- a/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c
> +++ b/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c
> @@ -87,12 +87,13 @@ static int gp_aux_bus_probe(struct pci_dev *pdev,
> const struct pci_device_id *id
>         retval =3D pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_ALL_TYPES);
>=20
>         if (retval < 0)
> -               return retval;
> +               goto err_aux_dev_init_1;
>=20
> -       pdev->irq =3D pci_irq_vector(pdev, 0);
> -       if (pdev->irq < 0)
> -               return retval;
> +       retval =3D pci_irq_vector(pdev, 0);
> +       if (retval < 0)
> +               goto err_aux_dev_init_1;
>=20
> +       pdev->irq =3D retval;
>         aux_bus->aux_device_wrapper[1]->gp_aux_data.irq_num =3D pdev->irq=
;
>=20
>         retval =3D auxiliary_device_init(&aux_bus->aux_device_wrapper[1]-
> >aux_dev);
> --
> 2.34.1