Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <Kumaravel.Thiagarajan@microchip.com>
To:     <weiyongjun@huaweicloud.com>, <arnd@arndb.de>,
        <gregkh@linuxfoundation.org>
CC:     <weiyongjun1@huawei.com>, <linux-gpio@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH -next v2 2/5] misc: microchip: pci1xxxx: Fix missing
 spin_lock_init()
Thread-Topic: [PATCH -next v2 2/5] misc: microchip: pci1xxxx: Fix missing
 spin_lock_init()
Thread-Index: AQHYwsfa7PMhHkHaRUuCegivBl1ESK3VCitA
Date:   Thu, 8 Sep 2022 05:59:11 +0000
Message-ID: <BN8PR11MB36687E0E06862C7C89E26DD0E9409@BN8PR11MB3668.namprd11.prod.outlook.com>
References: <20220907145808.1789249-1-weiyongjun@huaweicloud.com>
 <20220907145808.1789249-2-weiyongjun@huaweicloud.com>
In-Reply-To: <20220907145808.1789249-2-weiyongjun@huaweicloud.com>
Accept-Language: en-IN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?qjpFRr1vXvm+4qYiXLoqGGmAioWB77oZpmZ10kUWeofEH5NJTPc2XxqfWkpc?=
 =?us-ascii?Q?InevehMbGunuA8DjbmgVh82RlRbNK/MDu/VD00bCdJa3uk9wmlnYOAPL5t7H?=
 =?us-ascii?Q?TAbbDQlvNsbsZAc2189MXwLDQIU62tuGcNpbQef6vZPH1KjOMLPcOhrBm7u7?=
 =?us-ascii?Q?pBRpKALGrPVaweL01uMmsNoYSMOz5GLkDfLPdgvyzax9lC9JxtpshHnBFZZm?=
 =?us-ascii?Q?s7E2SKIDW+cJqDU3QlqCIMVLqFc3d597GaHjh1FPE+hqbFyPt8oebF33L2a6?=
 =?us-ascii?Q?LK4SH4/aujaeI7ykZhwIuMv6ag8XOb40p0BhEkXkrJ0l9w5yEQDAqt8rWL+3?=
 =?us-ascii?Q?+C0vbjavfy+F4vfzTR9LjkKouiHOqW1XvN6JUJCSTZI4QqYd1CxaIuqBaWkg?=
 =?us-ascii?Q?SIJD5nOIB/38ePymdx4uhq1nAefb7nsxe8A7MH3QxHfFnF7R1jqGy6zrYhA2?=
 =?us-ascii?Q?nK2nq4NuqI7dR/bq6N5PC45tl7+STqb7/ZbG/Ku7/ZZKCEr5ZO720kc7T2Lm?=
 =?us-ascii?Q?zSfS5+8PcS3r7pYSqzhNxRXzT/29GA76c10KB6xXFUlYIAnwQeww+X8Ssc1r?=
 =?us-ascii?Q?ISzywu8RHDUSbIDt4GUCSHzLHTlAhgZy90tUgZAc1CgZiDR0dErDy4cclOA9?=
 =?us-ascii?Q?vH4/QlXUi26i36MTFF7dq+GNTiODJYt2OftAplkDZuQ6TJpHHOVmtgp8Cf9T?=
 =?us-ascii?Q?mNTpd3LHaxtsJXxpXN5L7QKsXAefmTP1pRBR9G0TJr/Sp3lJfRvmr3jw+dt/?=
 =?us-ascii?Q?DDYhms1pJQB114fI8FsV8awg2JC1ni2FrHKDHp1noY6Arhu3b1XyvKTafg2E?=
 =?us-ascii?Q?vathMe0LIyVWY40y3IvxzLxKySKT9/he33ljrbfklLHrOj70K9snIwFYSeGd?=
 =?us-ascii?Q?zIvUTZMeOoSv3UqW4XlhXiQ5b3VIzaLTMr2uy2+4GIflyNKSvpB6eKGsT5Rk?=
 =?us-ascii?Q?8Vys1NudT9YgrVCcvYmezVywwL4bw14k3MXa94ukfDKlMUihv9MzeIQ4q9Tz?=
 =?us-ascii?Q?gSSOp0T+CDsAPPDB4mcWzm07e4+iLZ626I/3U3Z5s6jcNdFPVoyEumRFZzva?=
 =?us-ascii?Q?3KjTFR30IraXBfMSQx9Dwu3E+S+i2ceE2/sTnW+WQgJ3ul4g2sE1H+w4ZcCo?=
 =?us-ascii?Q?0pFgazC80VWDBgcVdmZSeDb77BMNSSpJgUm22P0WuSEIJju6o5Hr12rj+V3m?=
 =?us-ascii?Q?yEjWLulC72Voy7/sWlp6aP6cVX/JGRq5ofIzkud30hJk5zPat+2mkE8Aposr?=
 =?us-ascii?Q?OIvFr9UJX/2CcX/TUdqaHmXW/58FtQelQRv19wjGiXoclE7RfG3d5i2B8QaW?=
 =?us-ascii?Q?x0CinpjyIxU6gZF3NtzSD/NyX8p2x34nvT0P6GJr43oGUI8q5/LQMons3fUZ?=
 =?us-ascii?Q?DQaL4ID5VzLdYundmmg5WvBKibdyHDM6Ac7EkRZtSp9Q626Ssdei6wPFyxm/?=
 =?us-ascii?Q?CdEiDO2bsRRbxWPxJGGKqMwDGN0MOswDjmoHyLT/7N5GXnoF0A7h9t/CYCPX?=
 =?us-ascii?Q?g1ZXHXT1soG8bnrSCazthFRfQCg8bdjBzHzvF5rMxb/3MxJDvmBtmEeBRuNM?=
 =?us-ascii?Q?bAgzig4PDLxLTqXRMiDvdu/wWuqxOqiE+oSZG3ISWcYQVnzj+LW64QLDAlRH?=
 =?us-ascii?Q?huH/4h9/81dU/Uc0t6IKNUY=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3668.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4efddea2-ca28-4ae7-ff67-08da915f4093
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Sep 2022 05:59:11.7395
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: NHsc4v4QuXQmREfoAAh5dyVNTC6kzxISJ83szDfHqU9otqWIn2N8b9ziUxr/+dgdGxAeTzmn++okl08cBZz385qT+6uvJglzOeMNZ3a9+CdT56d3azgd7LSejTtpQid/
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4119
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Wei Yongjun <weiyongjun@huaweicloud.com>
> Sent: Wednesday, September 7, 2022 8:28 PM
> To: Kumaravel Thiagarajan - I21417
> <Kumaravel.Thiagarajan@microchip.com>; Arnd Bergmann
> <arnd@arndb.de>; Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Wei Yongjun <weiyongjun1@huawei.com>; linux-gpio@vger.kernel.org;
> linux-kernel@vger.kernel.org
> Subject: [PATCH -next v2 2/5] misc: microchip: pci1xxxx: Fix missing
> spin_lock_init()
>=20
> From: Wei Yongjun <weiyongjun1@huawei.com>
>=20
> The driver allocates the spinlock but not initialize it.
> Use spin_lock_init() on it to initialize it correctly.
>=20
> Fixes: 7d3e4d807df2 ("misc: microchip: pci1xxxx: load gpio driver for the=
 gpio controller auxiliary device enumerated by the auxiliary bus driver.")

Reviewed-by: Kumaravel Thiagarajan <kumaravel.thiagarajan@microchip.com>

> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> v1 -> v2: add fixes tag
> ---
>  drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c
> b/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c
> index 230503cca2ff..47e6e87938ae 100644
> --- a/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c
> +++ b/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c
> @@ -383,6 +383,7 @@ static int pci1xxxx_gpio_probe(struct auxiliary_devic=
e
> *aux_dev,
>         if (!priv)
>                 return -ENOMEM;
>=20
> +       spin_lock_init(&priv->lock);
>         priv->aux_dev =3D aux_dev;
>=20
>         if (!devm_request_mem_region(&aux_dev->dev, pdata->region_start,
> 0x800, aux_dev->name))
> --
> 2.34.1