Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 7 Sep 2022 23:11:58 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Robert Richter <rrichter@amd.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        "Ira Weiny" <ira.weiny@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        "Dan Williams" <dan.j.williams@intel.com>
CC:     <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Len Brown <lenb@kernel.org>, Robert Richter <rrichter@amd.com>
Subject: RE: [PATCH 07/15] cxl/acpi: Check RCH's PCIe Host Bridge ACPI ID
Message-ID: <631987aedd464_580162945b@dwillia2-xfh.jf.intel.com.notmuch>
References: <20220831081603.3415-1-rrichter@amd.com>
 <20220831081603.3415-8-rrichter@amd.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220831081603.3415-8-rrichter@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?iLwn9pOHIVObIZpMRHbixAnwFEtt3zIuQR40DLJP1exjjbjqGVHguJC7JynZ?=
 =?us-ascii?Q?tP0g5GQ41NJ5IRTmg+zJmmEvSbzUa8kGl3AX6sVzZCYiLsJx/Rn74Z+nMyTP?=
 =?us-ascii?Q?sPmskDTbvzqNtYCxs0M8s5E7icsutFuqS0uIfrmh2MIZbEyDl2WuWhdd6Cx4?=
 =?us-ascii?Q?+jpRrLWXegi/gXroQJoA7gDjSf47iK68KfKavIvtcWVclrgzZXWtuajpXpGr?=
 =?us-ascii?Q?S+PDyw3ItZIir5aXY0gkF+ieYkPy+WHMp5A6ItohzDLRSysM6133UWaYupyT?=
 =?us-ascii?Q?oRhlPBYs7QiDEkNCPMEJBfeSzAYxNu8dm/0VbFtx3AAYJgPr2vzoazv5MDic?=
 =?us-ascii?Q?ZEtKKFOI4oAMMKvAIOORcdGJge9CjH82rUJtcPRYrif5CA/GXYbnGCncs6gM?=
 =?us-ascii?Q?34ByKQYPHhs05ZsgAIN2rWyonulP18pYdD9eUlWTPKlzLfgn1T4o1qgwkCFa?=
 =?us-ascii?Q?sOLcyY7z8RL7bibjQJpMGVB829BfNOXXK6QiZqfCTt6glIP6yvD+rwLlogQP?=
 =?us-ascii?Q?UGa0H6jirmBMvErOP+3KzJ4vzKSqp1bGiu6dgAIGf7SBXxecmfTb/IZyoGPm?=
 =?us-ascii?Q?7mlEEyICWuAjuC2EA1oaj14Q0V2DOxgf4ohRutzd9OLQpzVYylOL8HlsO3zi?=
 =?us-ascii?Q?hVmDI0trVA1o3LYvBxKFXEqhDzVLk29u+sbe5OcByVrSHoh15XXSS+sfIJ4u?=
 =?us-ascii?Q?PWIdqpETZzMgWM0wA6xKQkODIs7rxDG31PMSSBNlU6tVCfmXihl8wyjeVCp2?=
 =?us-ascii?Q?aXFU+dxmDq3xgT9Q6Kvsfvm8eyT3ANi4Uwrj4EMBDJp4EdCvAyqOdsjRkCs+?=
 =?us-ascii?Q?p4AgVL0dFrtph8xMmAyCxzQ4q5/ZgTj/dnksZ7aF66Gmn46U4wolN28PcDT+?=
 =?us-ascii?Q?DeXjJA+ZfovWIuCHz7DxNmtL0N99M0jmukojfG5hzrvpyerMVknCIPuxrqYY?=
 =?us-ascii?Q?YtGAzIft848MOgJM9BTN4abSCjAl2emWHyvfOJ946fQdjY3pSrXoNjs3+b6E?=
 =?us-ascii?Q?bIVfwfqxOLsKi+cqHma6ylGfVxbNY+20eD98WxQi0vGLf+PEpU0dRpsa4HFv?=
 =?us-ascii?Q?+8UdfsEaZTkAOZ2lpHAYzA2LsCTdAvGn1XjO76cuFKUFHCZ7RYqkq8HnaYjg?=
 =?us-ascii?Q?kSuVpOyKA8JtwnieNg4XXL/baSY/uPIwzVAyxnPhJOWWLFyuzLd/AkFC+ZuX?=
 =?us-ascii?Q?IGe7mq3BjfYPA7G2I6Dszet0lF5dRIY/WAI7GaxZoJrtXfKr6WvLfX9SY24S?=
 =?us-ascii?Q?yg1H57MGFbILhmJ825OH2t4fuRaWKZXH3f+xcMwJmxIMuUYqEJ/LyPyCaYly?=
 =?us-ascii?Q?MrvbdLWOOjLOavB5JK0Neiqysnh76EYIEn0ZyB3cNmQIXZoU1cazHmD9v3la?=
 =?us-ascii?Q?1CcgTc/oUvWtncPIIwhs91YdKsAUSazKXU5NdXVdzb/xsjbpgYCbbQiUUX+F?=
 =?us-ascii?Q?+mHLpzk0Tmx77a0T0DTkKJzaWrrgfhDQ3j85i/UVqyAwc0EnNCmf3BgybIU/?=
 =?us-ascii?Q?e1P9t6mse7MEKYRhKd+TEUQWOsfi5/qHezyOFysTAXo4ogwAju5sPndoyzFj?=
 =?us-ascii?Q?vt3VLsW3SBFh2q1g86iAm9kFsel6zgyeTR3torX9OMGS10B0k/0x27QlvxFi?=
 =?us-ascii?Q?TQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 41f51791-7bc0-4d65-9326-08da91610b55
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2126.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2022 06:12:01.5452
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1y0GNhl29rf0Zm6HgOQgG/2t0zibZLDRsJ80hLZohIbfMhWWllNZ5oUhLPm3hs9mwwE6yibhuVgB9inGvXHWdChrtfMV9uOhV9arA5xgSn4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3056
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Robert Richter wrote:
> An RCH is a root bridge and has "PNP0A08" or "ACPI0016" ACPI ID set.
> Check this.
> 
> Signed-off-by: Robert Richter <rrichter@amd.com>
> ---
>  drivers/cxl/acpi.c | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/drivers/cxl/acpi.c b/drivers/cxl/acpi.c
> index a19e3154dd44..ffdf439adb87 100644
> --- a/drivers/cxl/acpi.c
> +++ b/drivers/cxl/acpi.c
> @@ -312,9 +312,16 @@ static int add_root_nvdimm_bridge(struct device *match, void *data)
>  	return 1;
>  }
>  
> +static const struct acpi_device_id cxl_host_ids[] = {
> +	{ "ACPI0016", 0 },
> +	{ "PNP0A08", 0 },
> +	{ },
> +};
> +
>  struct pci_host_bridge *cxl_find_next_rch(struct pci_host_bridge *host)
>  {
>  	struct pci_bus *bus = host ? host->bus : NULL;
> +	struct acpi_device *adev;
>  
>  	while ((bus = pci_find_next_bus(bus)) != NULL) {
>  		host = bus ? to_pci_host_bridge(bus->bridge) : NULL;
> @@ -323,6 +330,19 @@ struct pci_host_bridge *cxl_find_next_rch(struct pci_host_bridge *host)
>  
>  		dev_dbg(&host->dev, "PCI bridge found\n");
>  
> +		/* Must be a root bridge */
> +		if (host->bus->parent)
> +			continue;
> +
> +		dev_dbg(&host->dev, "PCI bridge is root bridge\n");
> +
> +		adev = ACPI_COMPANION(&host->dev);
> +		if (acpi_match_device_ids(adev, cxl_host_ids))
> +			continue;
> +
> +		dev_dbg(&host->dev, "PCI ACPI host found: %s\n",
> +			acpi_dev_name(adev));
> +

Again, finding all the ACPI0016 devices is add_host_bridge_dport()
already does.