Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 7 Sep 2022 23:18:03 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Robert Richter <rrichter@amd.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        "Ira Weiny" <ira.weiny@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        "Dan Williams" <dan.j.williams@intel.com>
CC:     <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Len Brown <lenb@kernel.org>, Robert Richter <rrichter@amd.com>
Subject: RE: [PATCH 08/15] cxl/acpi: Check RCH's CXL DVSEC capabilities
Message-ID: <6319891ba810b_58016294a1@dwillia2-xfh.jf.intel.com.notmuch>
References: <20220831081603.3415-1-rrichter@amd.com>
 <20220831081603.3415-9-rrichter@amd.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220831081603.3415-9-rrichter@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?D+ihIb4MjLX9Wwq0std8VPXXTSrSbLBlMJPyVm4Mhy6jI5oOibf6NZD7Y8A2?=
 =?us-ascii?Q?ELDBQGK2xxUQ/bsxwEWIIIE62Q/BB+BnRnazN1GNdRBq2GtGsD0KoOuKe6by?=
 =?us-ascii?Q?HF280s++1OxF0pySZvGTzZhe7890NbUoUunheHVcJsBu8F2ezIKqYWZ/tBuP?=
 =?us-ascii?Q?qWqxLdBTrbbp6yJy/cwnhHJd2Pr8eKHCW6Jqm94r95QwwFZX4ABVQ23vSWrZ?=
 =?us-ascii?Q?XHObry7OPs5YOxfwx6MVU8pncXLP2oPrauAiq5UX/ezOxFzHG/ikOKuN8p9P?=
 =?us-ascii?Q?bTBY7ouRlFDXDjQ+HB8I8Aj6HyyjpY9GPB51qvq5yknKCQprTDbDcor8nQEC?=
 =?us-ascii?Q?OHhRIOVuA3pdBVwKXyTTQSvt0a5BQ9FA/5J2jU2CBhp/AXHHi7m3r247ets2?=
 =?us-ascii?Q?/gDQxlwb5hLF9Z9FzIRfK3gcjkVT0kQT741daZm5HllKiGoPMjN40WDhJhRq?=
 =?us-ascii?Q?c88exipzaIslhroWgR0hp8GrM0XFBnuOERGxZ+GibTFjGtntOJoPQA6vluqr?=
 =?us-ascii?Q?ecu6fuv+F2UVWDoen6tdMZXUrB26F2NydqX4hGUsxkMDgAf6sPi+3BEs+Fli?=
 =?us-ascii?Q?7XH7r3ubfx+7GwhDO7pzWX+rJAAbU+7CnrS0mSyBLM57gpWQeGIXAsu5poMc?=
 =?us-ascii?Q?b3RJghhRnKpwPirz5r4xEK366mfLPOxpTWjAAOWDMqPSaIQVUibjbZO2ImYd?=
 =?us-ascii?Q?h885gPUeVY3FBfncTVhdDyqxos8WZNOY4UrchmUqo+W/tT2XHOQrxiK3dhvp?=
 =?us-ascii?Q?a8VLBWcSpqdCKkq4VtTd/+m9faGopMvHXgYhyWbIYIoH4v5xjbAZ8Hca82Mg?=
 =?us-ascii?Q?Dq6AtfyHa8XFlO0+YXuNo8B8jDO8YCsvpnrQbM8jAhzIvkhVCjdVcSE1RZuJ?=
 =?us-ascii?Q?JnX4IL5G4O8LFz4xUpS3rBmGD2On79rQsflLdlBOyVnz0mmg92XqN8mdu6cS?=
 =?us-ascii?Q?zrJ/BDPA3ygZ0sAzclpkjSFCHij7PxYTtBs1pOrQW6JaU7gJTUh23iEGcvPT?=
 =?us-ascii?Q?m3RzRUMF9RMKvOXzm/kOu6euCOLpXt7YZA8vy1r2WknozPBS3whBFkA5chz8?=
 =?us-ascii?Q?0w8jpbd0Wjh3wjcfLT/IaPpx9vEnkaWybFx5K1g2Jbpwrb2eqsDgmPAHzEEz?=
 =?us-ascii?Q?UlS2opXlz8dwzLPp7YfC3mzgExjpw3k+N7H92Z9/QSEnycFgnMjckNOAU8GX?=
 =?us-ascii?Q?HpNcv3B9kyOQektl41gTdF3OK9awE0wwWL6OxjOYg8CQKrLTLOjWc5SXPfQL?=
 =?us-ascii?Q?pXsZKvd9PTYvRQ8kh8UpAd27O4VsGW3Qluil+VO0VWEY9E8/6KQJjpKWTt//?=
 =?us-ascii?Q?GlbKI/BZbmXcCEyB72g7i0tKVWHNZGtvcL0ucCxcKzMLfzB6KsKJp6RAnYOs?=
 =?us-ascii?Q?PHteWlMKCZgzYJiRM5tfNRpRdhWpE5dXS/DDzJHR9U+ev/FL7fcJkitv+/Je?=
 =?us-ascii?Q?6GuyCwLDJKSTHrM9l69YRS3HmcNsuS/OJ2FjzjR5CAV2dSmyRzRBqGVpFxRK?=
 =?us-ascii?Q?JgVgDljMUI4/BGIZgsTDncXHe/zmtAxSK8KnguNMRpm1P3BNn8k+VvRfpblr?=
 =?us-ascii?Q?xB2ku6bO3QfZEMowouhPG7N6iegslx9475C3RhSXGoj/7LbUoNitI81bY4B8?=
 =?us-ascii?Q?MA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c1b47cbe-d35d-4d29-34a6-08da9161e500
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2126.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2022 06:18:06.7135
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LYTGTM6FJJVCUbuu65XR6NDWGVsXnj7uoYHdKLX1oKLYeuayomNn58lSsbBM4FuS+GU6+NWQvnJvGQyC8L04Pr3smVgh8vUYtBHN38jI9MM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5789
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Robert Richter wrote:
> An RCH has an RCiEP connected to it with CXL DVSEC capabilities
> present and the CXL PCIe DVSEC included. Check this.
> 
> Signed-off-by: Robert Richter <rrichter@amd.com>
> ---
>  drivers/cxl/acpi.c | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/drivers/cxl/acpi.c b/drivers/cxl/acpi.c
> index ffdf439adb87..f9cdf23a91a8 100644
> --- a/drivers/cxl/acpi.c
> +++ b/drivers/cxl/acpi.c
> @@ -322,6 +322,8 @@ struct pci_host_bridge *cxl_find_next_rch(struct pci_host_bridge *host)
>  {
>  	struct pci_bus *bus = host ? host->bus : NULL;
>  	struct acpi_device *adev;
> +	struct pci_dev *pdev;
> +	bool is_restricted_host;
>  
>  	while ((bus = pci_find_next_bus(bus)) != NULL) {
>  		host = bus ? to_pci_host_bridge(bus->bridge) : NULL;
> @@ -343,6 +345,20 @@ struct pci_host_bridge *cxl_find_next_rch(struct pci_host_bridge *host)
>  		dev_dbg(&host->dev, "PCI ACPI host found: %s\n",
>  			acpi_dev_name(adev));
>  
> +		/* Check CXL DVSEC of dev 0 func 0 */
> +		pdev = pci_get_slot(bus, PCI_DEVFN(0, 0));
> +		is_restricted_host = pdev
> +			&& (pci_pcie_type(pdev) == PCI_EXP_TYPE_RC_END)
> +			&& pci_find_dvsec_capability(pdev,
> +						PCI_DVSEC_VENDOR_ID_CXL,
> +						CXL_DVSEC_PCIE_DEVICE);

The check looks good, just the matter of integrating it into the
existing ACPI0016 device detection.