Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <Kumaravel.Thiagarajan@microchip.com>
To:     <weiyongjun@huaweicloud.com>, <arnd@arndb.de>,
        <gregkh@linuxfoundation.org>
CC:     <weiyongjun1@huawei.com>, <linux-gpio@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH -next v2 5/5] misc: microchip: pci1xxxx: use
 module_auxiliary_driver
Thread-Topic: [PATCH -next v2 5/5] misc: microchip: pci1xxxx: use
 module_auxiliary_driver
Thread-Index: AQHYwsfZfRni+0Ehb0+ISLIO7/D6eq3VDGVw
Date:   Thu, 8 Sep 2022 06:16:24 +0000
Message-ID: <BN8PR11MB366875590A4F506A398B3FCDE9409@BN8PR11MB3668.namprd11.prod.outlook.com>
References: <20220907145808.1789249-1-weiyongjun@huaweicloud.com>
 <20220907145808.1789249-5-weiyongjun@huaweicloud.com>
In-Reply-To: <20220907145808.1789249-5-weiyongjun@huaweicloud.com>
Accept-Language: en-IN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?o53gn52UWf3wXVhDpZ/8iV+5GDPZ0MeMR1gh49fkv+48jayhIHI8zKQ+4UeD?=
 =?us-ascii?Q?E9j0lxh8+6dtzGrR0GBz+MQeFoicGQ6b8MK7Mu92Bs5R8T+vdqgX6NVxSbBj?=
 =?us-ascii?Q?mX+2PRzuUoxY6QF3fqcGmGRmHuixMsMAlpyMYrUuaHdEyXwHi80YIeLuCkYF?=
 =?us-ascii?Q?V99us842SdaKqfDdQ976ji2grGiyLYsOJ1q/r0GwW3ESHL4Mec3AcMJPYr0g?=
 =?us-ascii?Q?fywEmnZYnnwtpJkxc2eLNr4TfJkUKw2/wamMeamtxM2xXPC6XX4WUMJzVRIB?=
 =?us-ascii?Q?7vBkMAM/YLpON5+akPzUZ4JOHWpCdDEweKIGdKNidl4BGTLhg2tr5zdNOKcm?=
 =?us-ascii?Q?WvgRvm8aVkGWTYsEJx1YkYJU4kiHtb67PlhWpKV2FjFZOXeJGSbGHFF6v9Sc?=
 =?us-ascii?Q?s2w7py46PGhJsXXoSd/LyBJhcYMe+GiAaL6Lxhkw2JUmfDuWaiqZ7PcMH2+i?=
 =?us-ascii?Q?A1KUtNROzSTiDD7lKTZtZ7ko0X7a83jzDdaZBlQvg+YzWBNoeBVZbe+t8WE9?=
 =?us-ascii?Q?Zz+fMbp2ckOz49LzU1mH/65/ekT3rJoKQswXtuqZl90shHm7z0IG2kH1Cneb?=
 =?us-ascii?Q?6iGc8k/LquG3uecBwrBCFaE/wMb3wCs1yaO1T5wnMTlXGpfXrpKZgWGw6EzU?=
 =?us-ascii?Q?wZDV/BvhrctO0zjj1YMuoi4l3lmiut4VLtxBdujfVir6qBZBwOh2dkCOXivI?=
 =?us-ascii?Q?46V6d5TIwKMlNCutkUpDm/t0vkCDq6I76gAQ7yr+bjhNbbVdeRzoG+6GVaz/?=
 =?us-ascii?Q?k6Pr78u5WX49BFfCUaXDe36JyMfNmEJjrZc6erbLoX6I9fbA7xg+1+ckcUt4?=
 =?us-ascii?Q?MYQT6hqqSwR0eJKfSoF5taRsqQAZ50kTNM9upiZCJxe0CvKZj+I+x2lBBnMY?=
 =?us-ascii?Q?vbtOZasS/Si9i6LktBBviKxqXpjaZEEtxS/kTe0bDy86zgOSw2dBnPVaIzaG?=
 =?us-ascii?Q?OP73OxAUJLev6vSoEJeKTfYcYW28iXKiAw4rw5TN/7MdAaOnvtE7fBObj8PX?=
 =?us-ascii?Q?FiXQN5rdJcDXu7qijKfgXuYtbgAaXQAUQhJ5d91Bo6omD4jfWUluVSaiL3eJ?=
 =?us-ascii?Q?RrZQ2kl2xr1cRRJf0x6/Ph2GMz8Io4quzsuWqxgJgs5u6yFLUi0PdX9KB58h?=
 =?us-ascii?Q?6/K27bL+9sdpNBbW5KI/Z7yJ51ojt4iTorJmMqgwrcM6bDt9r1J6kgXXqGym?=
 =?us-ascii?Q?cE5SUeZ9GVK4wkd6osD/RblnUDpbFnO03fjZGiZDAAIZBOuvFzP51iMECikf?=
 =?us-ascii?Q?bD79wWaNsJc8Hfi/SN2TgxEE00KxQSYatycvz5bM2Jl+bGV22rOLyCIixjw8?=
 =?us-ascii?Q?FZetFmmorGrhHWtS0LUhmICXEj1VsMzBHGri2r7y3JV6/j+f65J5nFPezi1+?=
 =?us-ascii?Q?jRwUww9dLucet0huwTmbDAFMWZOXSwH975FWjXvKnu4Cp/2hITmUmyQV7s7E?=
 =?us-ascii?Q?XQrresUxrkHBjgjAnx4xlaWASyBHgHGUtdNwCSM7tuvngEMCkCCSF7eRFTh8?=
 =?us-ascii?Q?yvKWopIjg9BJfYfk/jDeh5TqxxT/HK1GwLLdyoOmEv/nnPeAWQIFZpMlHhbo?=
 =?us-ascii?Q?RFzcW/GCRqFpxoJp1oIoyJf1o5UxUCsHDJoPJ3azysSobC11I6rqaIufZXUO?=
 =?us-ascii?Q?sftfRL9b36E8D+mB2mJrs7c=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3668.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9c2e5f73-d3f5-4ee2-a558-08da9161a860
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Sep 2022 06:16:24.8951
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: J7Z36R6n/EACoIHghpY5PpvzJVxQnqoZglhJ/7HEQgdzgl3ewZNNiL6qyTyFWHPlSBBnIIxkFqQVca8B1AxGnv95qymu7ILiFWRCC94fBemncvlNteFE7MizkuQ3M5Nd
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR11MB4440
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Wei Yongjun <weiyongjun@huaweicloud.com>
> Sent: Wednesday, September 7, 2022 8:28 PM
> To: Kumaravel Thiagarajan - I21417
> <Kumaravel.Thiagarajan@microchip.com>; Arnd Bergmann
> <arnd@arndb.de>; Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Wei Yongjun <weiyongjun1@huawei.com>; linux-gpio@vger.kernel.org;
> linux-kernel@vger.kernel.org
> Subject: [PATCH -next v2 5/5] misc: microchip: pci1xxxx: use
> module_auxiliary_driver
>=20
> From: Wei Yongjun <weiyongjun1@huawei.com>
>=20
> Use the module_auxiliary_driver() macro to make the code simpler by
> eliminating module_init and module_exit calls.
>=20
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Fixes: 7d3e4d807df2 ("misc: microchip: pci1xxxx: load gpio driver for the g=
pio controller auxiliary device enumerated by the auxiliary bus driver.")

Reviewed-by: Kumaravel Thiagarajan <kumaravel.thiagarajan@microchip.com>

> ---
>  drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c | 14 +-------------
>  1 file changed, 1 insertion(+), 13 deletions(-)
>=20
> diff --git a/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c
> b/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c
> index fa80a7788596..9cc771c604ed 100644
> --- a/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c
> +++ b/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c
> @@ -421,19 +421,7 @@ static struct auxiliary_driver pci1xxxx_gpio_driver =
=3D {
>         .probe =3D pci1xxxx_gpio_probe,
>         .id_table =3D pci1xxxx_gpio_auxiliary_id_table  };
> -
> -static int __init pci1xxxx_gpio_driver_init(void) -{
> -       return auxiliary_driver_register(&pci1xxxx_gpio_driver);
> -}
> -
> -static void __exit pci1xxxx_gpio_driver_exit(void) -{
> -       auxiliary_driver_unregister(&pci1xxxx_gpio_driver);
> -}
> -
> -module_init(pci1xxxx_gpio_driver_init);
> -module_exit(pci1xxxx_gpio_driver_exit);
> +module_auxiliary_driver(pci1xxxx_gpio_driver);
>=20
>  MODULE_DESCRIPTION("Microchip Technology Inc. PCI1xxxx GPIO
> controller");  MODULE_AUTHOR("Kumaravel Thiagarajan
> <kumaravel.thiagarajan@microchip.com>");
> --
> 2.34.1