Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 7 Sep 2022 23:53:31 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Borislav Petkov <bp@alien8.de>,
        Dan Williams <dan.j.williams@intel.com>
CC:     Davidlohr Bueso <dave@stgolabs.net>, <x86@kernel.org>,
        <nvdimm@lists.linux.dev>, <linux-cxl@vger.kernel.org>,
        <peterz@infradead.org>, <akpm@linux-foundation.org>,
        <dave.jiang@intel.com>, <Jonathan.Cameron@huawei.com>,
        <vishal.l.verma@intel.com>, <ira.weiny@intel.com>,
        <a.manzanares@samsung.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] memregion: Add arch_flush_memregion() interface
Message-ID: <6319916ba0f9d_5801629437@dwillia2-xfh.jf.intel.com.notmuch>
References: <20220829212918.4039240-1-dave@stgolabs.net>
 <YxjBSxtoav7PQVei@nazgul.tnic>
 <20220907162245.5ddexpmibjbanrho@offworld>
 <6318cc415161f_166f2941e@dwillia2-xfh.jf.intel.com.notmuch>
 <YxlxAFgW65w8wgPy@nazgul.tnic>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <YxlxAFgW65w8wgPy@nazgul.tnic>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Pdo1XfDaeVA8Lw7hCHwWA3FkCFlfQGNzPfCeSfVAhAQ+yPLUyPiHAW/E8k86?=
 =?us-ascii?Q?O0y+ZNV2+anN59RB/UOJDR+4teC9ZF10VC0p1IAo3z4cAw8ccf+M4rKMcn99?=
 =?us-ascii?Q?ey5d1Q2U/ti20QgBUQnRbtVrwoIytfU9KkspjolYJdr1xAssqXQu7ciI2QsY?=
 =?us-ascii?Q?jMvYu2BuN5tF4FnjNjXOJDK1uOCKH4lp4EWLb3fsgT8ReWFw+Vny9TEtRjf1?=
 =?us-ascii?Q?Qqi4f4HM3ndnzZ4VNChf5Ml4gsYjAnGntMz0RU+jdFOhTqWrt5HjSPGEldLV?=
 =?us-ascii?Q?bW/q+lpyMcZwK4bSUZiI1iSdHzYZjHrya097nRSiRxIrSjrmiFwn/fscdyZp?=
 =?us-ascii?Q?gS2S9LeqaduWWQL4WGrJ8eW12W/a7KoUvEQWQC+old5RJvHRsm45Br2qGKCZ?=
 =?us-ascii?Q?nF4+jYslc6sbpHGkb1moAXGlxD7a0nEM+Klg2ErUGZo4SHSosQyggV2KC1Os?=
 =?us-ascii?Q?FNLKR9s0umco1Nhed8HPuvYx8wnV6XlLN5blJWq3D4Vqvf+Em8+8yG97rVAa?=
 =?us-ascii?Q?Gh5CM1Pfe/cpFJZr7jScFuFVPaJiEB/OxotN18fR7Ayv0oOgE7HathadZveD?=
 =?us-ascii?Q?kRftIRZnYz/EpbOjxrDmTbKcK9tj477f61ysVLfYNFZYdpofeQ8bxfhQl7U9?=
 =?us-ascii?Q?cznZiP8rwlqn0Wl3xJcP3976bQwYDhD5kuTQBt8VZ1xF8iT5PM0ILuVWIUAJ?=
 =?us-ascii?Q?bVlxJo/Rj58pBdlVCsH6K3/gy8bd44OWOPbgUaObTzHI8YJBD2nGoH4t3Ozm?=
 =?us-ascii?Q?Z+8gB7z6bfOqbl6H0WW/dmTFOT4WukgayBKrY3zzuAft0/ZDCOSbtc0wyVkz?=
 =?us-ascii?Q?r1hx8igGVK6yhua/9A+Cc/csqZG87ivhRiZUoXdQ+JLH8Sju5RKCtGlQi7/W?=
 =?us-ascii?Q?FDG7xWQcnt9p1HseX58bIDWaOcrfo8zJiOOMe6xiyQBv8485MP8ZK7xJBN2s?=
 =?us-ascii?Q?tgcTukVLxmAdc2Bm+rKX5XVvmDkBHzcrvH0Ehafb1rVIbTPs3GLAHyv8JNmY?=
 =?us-ascii?Q?/eMUd082YftftaVhuxMYHum9umJ3b2PO3hLGWYY7JqNUYdQm3pfP3UqH4AP+?=
 =?us-ascii?Q?xRyEXR7qC1cdWGy4VqkpNycO02mO2AhtrRLJftnLTcD6TU1aSp+tWgTcl6aD?=
 =?us-ascii?Q?Cobi3Z/fgC1gPe8owOCjR31VYaVixLrHm4oNPpJ7ipkexbRNpOOIlL8+sNDw?=
 =?us-ascii?Q?0DIhiaSCBDrkbUuD8dXk/uNSK5EnoQgZlwH7aF/th9TzHV6UgA43srnfQ7IN?=
 =?us-ascii?Q?Dh51mLwjiW639sW1LXrpWcdSXkd6vQzq3KH71hnqzDZTXf9X5NtyvRjZv/DW?=
 =?us-ascii?Q?wbH08YtKtAg6KzhkFK95Qy0MeVrv9gxL8qJQYUeWf+gFUW4COEOulFj3PFKM?=
 =?us-ascii?Q?DdU8dCVimBLANXm+aqSA+IeqoXDcr2VRZHRvYPHJjVgJQq2aNB3TNlS29V8G?=
 =?us-ascii?Q?vR3DnA9SSj+XUAwO+wm+5NfdFyi63gjVfzesiD/J1G9N7ud04g+s4bORKawF?=
 =?us-ascii?Q?Iq3+YEtnZvXYDqqob7Zd4L57AnO2iLm8fzHCTBTzpdAxsdrk+N/K381ccBiq?=
 =?us-ascii?Q?LUzNxZoLgcvFPBa+VetMvuJ3JB01gW5++jpwRqIC5u2hr7VCVejpXzmI/giR?=
 =?us-ascii?Q?Jg=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f5b3b0e7-09b4-40f0-30a9-08da9166d949
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2126.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2022 06:53:34.6209
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RG6Xk11/jrPs6pZV4OEfB3RcJhQPS7+k7LxKUOi3Ckk9j7G0Z0WYvFS3EDJlbiESsWGNvdY726POxCzx9crPLBlxQ7XSuOhWy0neZsCgtKY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4169
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Borislav Petkov wrote:
> On Wed, Sep 07, 2022 at 09:52:17AM -0700, Dan Williams wrote:
> > To be clear nfit stuff and CXL does run in guests, but they do not
> > support secure-erase in a guest.
> > 
> > However, the QEMU CXL enabling is building the ability to do *guest
> > physical* address space management, but in that case the driver can be
> > paravirtualized to realize that it is not managing host-physical address
> > space and does not need to flush caches. That will need some indicator
> > to differentiate virtual CXL memory expanders from assigned devices.
> 
> Sounds to me like that check should be improved later to ask
> whether the kernel is managing host-physical address space, maybe
> arch_flush_memregion() should check whether the address it is supposed
> to flush is host-physical and exit early if not...

Even though I raised the possibility of guest passthrough of a CXL
memory expander, I do not think it could work in practice without it
being a gigantic security nightmare. So it is probably safe to just do
the hypervisor check and assume that there's no such thing as guest
management of host physical address space.