Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 7 Sep 2022 23:11:09 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Robert Richter <rrichter@amd.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        "Ira Weiny" <ira.weiny@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        "Dan Williams" <dan.j.williams@intel.com>
CC:     <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Len Brown <lenb@kernel.org>, Robert Richter <rrichter@amd.com>
Subject: RE: [PATCH 05/15] cxl/acpi: Add probe function to detect restricted
 CXL hosts in RCD mode
Message-ID: <6319877d8dc7e_58016294df@dwillia2-xfh.jf.intel.com.notmuch>
References: <20220831081603.3415-1-rrichter@amd.com>
 <20220831081603.3415-6-rrichter@amd.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220831081603.3415-6-rrichter@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Vd8A6+prqua1SrmGPKZ7M7J3KQZRMQeNDMFvyJTD5SJYOS3OhqkWXZmmMGmb?=
 =?us-ascii?Q?zVIcrlyofMYSk7v/jC5I1Fi7Q1kzIhkDzk/4LA4oyn52ENqd+lGaaDRYmSf8?=
 =?us-ascii?Q?OEdh4y1Cqv/l84bG0WW+Cao9o2im6Xc76C+aCMUF8MDFo+NgZiC13w07C6d0?=
 =?us-ascii?Q?q4lEC9tmW/eU+bjSKHcPIJtWBqbMkohqJGGK10G4fChW4tHsT3LkuYQqgXtM?=
 =?us-ascii?Q?Hod5IbFt8PJkBl40uQUq5d9keBkmd9llc8pnkWRxn+tsySntxgdxI9AIVtM7?=
 =?us-ascii?Q?kHSIrbH9jq52q8BJh8Xc/qRkTMs/5iATYseeBUM7tn5Scak4/EPlIwXUMHz2?=
 =?us-ascii?Q?kdQnBQohVbwldn4+TGl7R8p2A2N3gIOSwT7xAAnkNdGAy+wu9aOOaFNtRavt?=
 =?us-ascii?Q?rp4MJHsH3LsIPMJ8JZDGEtzouvRtdEPSYxtTYIl/sVoSxOFho3LAGsPcsc2K?=
 =?us-ascii?Q?pYumyjT+DhovhkU65oQ/5Zdxycc1PG5g5A9fAtCzsFXmbCrY3lFIPP1wUCKi?=
 =?us-ascii?Q?tAVVGt+ecQDfZbAS6EKEXeG36wgoG7mgKpbFibmXFRsUAb3mcZDOAuRuCgID?=
 =?us-ascii?Q?kUDk0+wHN6qd8Qu54ad7UC4hGckhc0OJInDtysvOpizSnuNL4FlOkoktZ2LG?=
 =?us-ascii?Q?8p9ggMEMf+LeuBZgEIGmJK1K+Y/LjtLf4oPf/Hq54Fd7v4wmBrOm6k5gGK+w?=
 =?us-ascii?Q?/4WBQV/0wdcMHC3xkaeAgNaPBl0CQw8lkjyI11tYwK1Gm1CCYZivPMHtFPOc?=
 =?us-ascii?Q?R6QEn68/QdGv1F6EniAERgX+Mf2hE4w+LrrYKAIusuXAlNdoZr3JhEaEkbC7?=
 =?us-ascii?Q?cEgpERgreshv5Q+Bj8nyl96ebj5HFxMMBjsLBdeBi+H35PPhXY3mMVLD1dgl?=
 =?us-ascii?Q?enGzHMV5iW4J6HHj6fAL7DtcAoHXQExpBc879jkHzR7UQ7id4pAcq7+1/Hgj?=
 =?us-ascii?Q?6raprwssJQl38NwgEDzPZnGNyc2sqUkvI7DY2UDvKqFt52JWAdVP1fkMIGLO?=
 =?us-ascii?Q?3gHKCi8ty43k/Ms6flmWOxQipt2MU21kwehek/ibNlEw2Bm3ujYCIlP69ZYT?=
 =?us-ascii?Q?OlWouYii8Le+AjHVBArhUiypHDp6uz84B/H34Y+3nlyoSx4/WKm/2mYfMYsk?=
 =?us-ascii?Q?5JHrk39Vp7mH89EbmmO3CI4StKN48/YP/8PRbyiO/QnQQnKKdz5UPExBMWCO?=
 =?us-ascii?Q?uDsNuvDQ8kjSzxqutYq3GX8msBukwJUmcb5L+yXeB7xylWlWkHbTNDJfE8H8?=
 =?us-ascii?Q?FowXDsySY0ZNFfu5rwbrAZj+Mg8ghPB+5gWRo5IEwHAw1kpglqy6FSNeaQJl?=
 =?us-ascii?Q?be+tW5CDHEr7BEX068ZHthVX0YtuLrb2M80DQaB9RzaXWWQqzt93P4qfK7HC?=
 =?us-ascii?Q?bY71MPJnG2EWRLJs/Un7hFf1YLrucmE/ruS48FFarjG8oIfiJu9GMhcob/K+?=
 =?us-ascii?Q?68AbeQHMbF+6S5IwvVIz0hvqekttuaJFFiK8OLvNirbU9wVc3NF1ihVasjB5?=
 =?us-ascii?Q?1VtdEDpbbgGdIHzu2jiED69hZ57e/fo7D2Y/h00PLdhvKQBD5jG7hDKZq7Hg?=
 =?us-ascii?Q?G/uyqb9F/EXl6jd2KbC9JaVrQ7KRcTjVQr4Oq+uvunbxS75k76Rh2Xxb5X6l?=
 =?us-ascii?Q?oA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 147415d8-0f12-4733-6949-08da9160ee0e
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2126.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2022 06:11:12.4093
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +XewxYPi0mOG4qL36+GYYuH5oh+nwdy9o5eVuOmod3yUt/iivCZqg/eNm6T9P8q2zgcYQPVxMY7e/jWL3+5qT0eWrC8vM52E8g20KjxrcdQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3056
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Robert Richter wrote:
> Restricted CXL device (RCD) mode (formerly CXL 1.1) uses a different
> enumeration scheme other than CXL VH (formerly CXL 2.0). In RCD mode a
> host/device (RCH-RCD) pair shows up as a legal PCIe hierarchy with an
> ACPI host bridge ("PNP0A08" or "ACPI0016" HID) and RCiEP connected to
> it with a description of the CXL device.
> 
> Add function cxl_restricted_host_probe() to probe RCD enumerated
> devices. The function implements a loop that detects all CXL capable
> ACPI PCI root bridges in the system (RCD mode only). The iterator
> function cxl_find_next_rch() is introduced to walk through all of the
> CXL hosts. The loop will then enable all CXL devices connected to the
> host. For now, only implement an empty loop with an iterator that
> returns all pci host bridges in the system.
> 
> The probe function is triggered by adding an own root device for RCHs.
> This is different to CXL VH where an ACPI "ACPI0017" root device
> exists. Its detection starts the CXL host detection. In RCD mode such
> a device does not necessarily exists, so solve this by creating a
> plain platform device that is not an ACPI device and is root only for
> RCHs.

These host bridges should be discovered by add_host_bridge_dport(), no?
Unless the BIOS is failing to emit the expected CEDT along with
ACPI0017.