Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp229750rwn; Thu, 8 Sep 2022 00:07:47 -0700 (PDT) X-Google-Smtp-Source: AA6agR5+8ZS0tr52m+3S/n1eZxGmOSWzpnaKnYEKNGImk4OZF14kH/e8FxVmM8xcEl/GiOVp0G2Y X-Received: by 2002:aa7:c6c4:0:b0:44e:dfc0:224e with SMTP id b4-20020aa7c6c4000000b0044edfc0224emr5916659eds.115.1662620866840; Thu, 08 Sep 2022 00:07:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662620866; cv=none; d=google.com; s=arc-20160816; b=vgMs4nFiu9h9lbRY3cuRoQS6yL9hygvsQX1lvHhTGYJB3KLDDaRgrP+PPtJjsHRR5+ 5Bc9Lop3Eo2hGyRxtxpdZHwrapEL87f7UaEBjzzpt9xaT6RYmw3nPcDPGpne42dX7hS2 w64CWP2BAFFvFSNJC6r+OufyD6vMML9T+O1ZLF7wKCyHfBadU6uObBtfJtshGNnW8SlI KkiIK+bULsRoMUv4thGdbhd4PF+dUDT71on6MEIswWLGoDqEEqHPWVazPWaQAy4tMI0O vG8rGZL9SDpvOyNz5i9aKUf21dNlPygJhlek+ECSJTh5zkAKwNQRW52gE/It89EqAcUw p0Mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:reply-to :in-reply-to:references:mime-version:dkim-signature; bh=gUbpbbKfF7KQ6Lsb7wztDuENXE7eYaOMwk9vpfh3W34=; b=xQVHCS71D/DLK/6Wn9tdJyrYEpHwWYYp6NMgOElTYWu2xnQIc4FhYKK3xZOxerR/4o 6YvSen/8SpMgfCTm67LV2Kx4gNwn90btleQp/+Jc9gkUi6y6+SgAfdDjLg7dzDHfdRGJ 4isolTOXSchxp+bPXLc9ND8ofDTdxFLas1aFap/Cc2At1c+Xm8upKyq3a2EcZlow9lrp ZqK6dctSmSu5Pvpc/3ayOguMUrC0rl9BSLAUB4wYn9AuzZZrkyrLY3IqLFi/yE4qkp+G XYzjD8q3WGk3WYZjXFIqQPK/m+zSCJAvV3JGgPKlPoEOTN9l2sE5LVPzoAmHBg6Cx9aL K9sA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=D43d3wSl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n8-20020a05640205c800b00448b894310esi16281326edx.343.2022.09.08.00.07.21; Thu, 08 Sep 2022 00:07:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=D43d3wSl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230403AbiIHGmQ (ORCPT + 99 others); Thu, 8 Sep 2022 02:42:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229552AbiIHGmO (ORCPT ); Thu, 8 Sep 2022 02:42:14 -0400 Received: from mail-oa1-x2c.google.com (mail-oa1-x2c.google.com [IPv6:2001:4860:4864:20::2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82157CD511; Wed, 7 Sep 2022 23:42:13 -0700 (PDT) Received: by mail-oa1-x2c.google.com with SMTP id 586e51a60fabf-12ab0eaa366so2505624fac.13; Wed, 07 Sep 2022 23:42:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:reply-to:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=gUbpbbKfF7KQ6Lsb7wztDuENXE7eYaOMwk9vpfh3W34=; b=D43d3wSldH8HgBUSqmOf8ObLusP+opNToR5dIAzJAX85rqh5wr9vUpFn0s2PAm+761 dMIabrMKoag9GinKWZpuG+v3RSNJaiEcYE2Auo9/02LQCRjJUDBc2q9p1I54pPDdwiXD y/oD19zu4qLdtkxRgEAeKV1p6mchLeSaDB7rCKrPn4EbRMwVDiK8VATAO02F9nA8EBCc iLPvKqKDBnls/D5NOBHox4t6cclDtR1oC0CeN9OiJG1XlKofl2HkUpVVg8MuC+gxneCy 3ltiZO3XMP5PSIlMRPmYIG8D07AyqB4ln55utAKRp1HdxcoJmHlLfAC7m8C3BCODnspX nRyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:reply-to:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=gUbpbbKfF7KQ6Lsb7wztDuENXE7eYaOMwk9vpfh3W34=; b=KMioVP+BNxdzJ1SCZ+aKWEE4HSU3iqD7FCsTM4GajqOwndS4M3VWAxyE0pwmgGoaLT vVwGzbYhuHFcrsAx32X0otsVUJ4qacTWqgys350G3iLlX96Sqo8W8lMJV3f/JtLpGImZ 2ar/il6573KXuXKiXPWiiQICyL4B/G5W3qK/X8OjAAtIC3NY+BvmWE2psnnB9Tgq2i/G OzH6n+p6DbQtpZM8cp/1eRwssBcI7DpVAU+tpaKwKF2+Y1LiCvcFGAFUHepjMOcIveMg eGAEvnuIGgwB2dPppvblufjWyIUKleqe0midBgvVFI8EYZv9Jevqi9JP/tqmR8ZKv7c8 kW6g== X-Gm-Message-State: ACgBeo0ISP883clCQXVw8KrLFeF2/oTinoWjSdecH5mrvxcp3MTIjoIu SPwKc942FqxFtgZ3kOs+IP3lpnnNSQKjyjcrkvw= X-Received: by 2002:a05:6870:c1d4:b0:127:9423:22b8 with SMTP id i20-20020a056870c1d400b00127942322b8mr1062860oad.123.1662619332893; Wed, 07 Sep 2022 23:42:12 -0700 (PDT) MIME-Version: 1.0 References: <20220907132205.28021-1-andrea.merello@iit.it> <20220907132205.28021-14-andrea.merello@iit.it> In-Reply-To: Reply-To: andrea.merello@gmail.com From: Andrea Merello Date: Thu, 8 Sep 2022 08:42:01 +0200 Message-ID: Subject: Re: [v7 13/14] iio: imu: add BNO055 I2C driver To: Andy Shevchenko Cc: Andrea Merello , Jonathan Cameron , Mauro Carvalho Chehab , linux-iio , Linux Kernel Mailing List , devicetree , Lars-Peter Clausen , Rob Herring , Matt Ranostay , Alexandru Ardelean , jmondi , Bagas Sanjaya Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Hmm... It has my tag but I have noticed something to improve. One comment below, OK for the rest. > ... > > > +#define BNO055_I2C_XFER_BURST_BREAK_THRESHOLD 3 /* FIXME */ > > Can we elaborate what to fix and why it can't be fixed right now? Ah, this is a stale comment; I'll drop it..