Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 08 Sep 2022 08:23:18 +0200
Message-ID: <871qsme65l.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Jason Gunthorpe <jgg@nvidia.com>
Cc:     Takashi Iwai <tiwai@suse.de>, Lu Baolu <baolu.lu@linux.intel.com>,
        Joerg Roedel <jroedel@suse.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Robin Murphy <robin.murphy@arm.com>,
        Eric Auger <eric.auger@redhat.com>,
        regressions@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [REGRESSION 5.19.x] AMD HD-audio devices missing on 5.19
In-Reply-To: <YxihMchpLRPAqNWx@nvidia.com>
References: <874jy4cqok.wl-tiwai@suse.de>
        <20220823010021.GA5967@nvidia.com>
        <87h723sdde.wl-tiwai@suse.de>
        <87ilmjqj1f.wl-tiwai@suse.de>
        <20220823202824.GA4516@nvidia.com>
        <87bkrrl3eo.wl-tiwai@suse.de>
        <YxihMchpLRPAqNWx@nvidia.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Wed, 07 Sep 2022 15:48:33 +0200,
Jason Gunthorpe wrote:
> 
> On Wed, Sep 07, 2022 at 03:28:31PM +0200, Takashi Iwai wrote:
> > >  /**
> > >   * iommu_device_use_default_domain() - Device driver wants to handle device
> > >   *                                     DMA through the kernel DMA API.
> > > @@ -3094,8 +3112,7 @@ int iommu_device_use_default_domain(struct device *dev)
> > >  
> > >  	mutex_lock(&group->mutex);
> > >  	if (group->owner_cnt) {
> > > -		if (group->domain != group->default_domain ||
> > > -		    group->owner) {
> > > +		if (group->owner || iommu_is_default_domain(group)) {
> > 
> > Isn't this rather 
> > 		if (group->owner || !iommu_is_default_domain(group)) {
> > ?
> > 
> > I'll rebuild the kernel with this change and ask reporters again.
> 
> Oh yes, good eyes, that probably crashes on boot too

Indeed the corrected patch seems working; it boots and the HD-audio
device appears again.

Can we go forward with this?


thanks,

Takashi