Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 7 Sep 2022 23:18:32 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Robert Richter <rrichter@amd.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        "Ira Weiny" <ira.weiny@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        "Dan Williams" <dan.j.williams@intel.com>
CC:     <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Len Brown <lenb@kernel.org>, Robert Richter <rrichter@amd.com>
Subject: RE: [PATCH 09/15] cxl/acpi: Determine PCI host bridge's ACPI UID
Message-ID: <631989383c505_5801629496@dwillia2-xfh.jf.intel.com.notmuch>
References: <20220831081603.3415-1-rrichter@amd.com>
 <20220831081603.3415-10-rrichter@amd.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220831081603.3415-10-rrichter@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?iWHmKK3uknAR/bjw/O+BlQbo+JTr1/sQZKrXlAaXVX8is6n0B/AaXMbv6iXn?=
 =?us-ascii?Q?5sLWgxtXKtNfepgZZX271p647miE5gWtDW+XdnU/pvYAzqRW3gqM+o74waz8?=
 =?us-ascii?Q?N7Dtt13ymg1PYx2dhOfncRr9lf/cuyXmrf14NoqZLezg+bZVQaFf2Avh6m3B?=
 =?us-ascii?Q?x1yei1m3sya24Jd1pZGGXbw4nEAQ3Z36B6+Soat6reiQ1oWB6DUxaeU1eBQG?=
 =?us-ascii?Q?VTxZnydCBnyTTjbacznA64XV5jWszG2qIO1bL4xWXiL/Y+ycyQXFcG+CTQfX?=
 =?us-ascii?Q?CGEcrS3WFPfM5gZ0RrvuaZ6JtKzjaZ1XtkXDe8Vzx3mrI0ol+dkwQmlE9PpP?=
 =?us-ascii?Q?3PzRgX3AFVTqanMCdNlwn6jnBZwgAKecx6EWFSZen9u9pnde8iXPTzhB4Ia0?=
 =?us-ascii?Q?JRFiRoKTcOP8fjGs7VswfQlBUs2NhqQKh6jDSOwWielZr+tpKfhju0Q81hlv?=
 =?us-ascii?Q?jHZKWu7r7XydCD8wRJ6FvMUjIjScyQp6RKrdfF3se+Zwrizyj9bN2Sf52cAY?=
 =?us-ascii?Q?RPFknK7A3z3kUCJHiN68WjLsTj0oHJe++dmYhmi6l0hmTH1OtWDCwfsTB/ET?=
 =?us-ascii?Q?5Wqvx/mDy9sBQNT+Rq7vnp7WsYs+qdelOQ8yHhGFRZmDj+bNcgjyVamoKcif?=
 =?us-ascii?Q?SCeJnoec7LupI/SOKa633W1/XuczlxDvvlbOTiuB1vxUZibPSx/YbvxAzJN0?=
 =?us-ascii?Q?NSzDnjqMhvzJov+ak0NChECbeO/m0jwX7RHKgA+LtMMNmRuRFV/SIGckBOfb?=
 =?us-ascii?Q?EEvV/cAgIACKYqfq72Dgb9qsPaQ3I3D0qes4bTUVbrRJJ+5eQmK7yIpp00rD?=
 =?us-ascii?Q?hX+5CtzRN2jUuFe6W4n9C8Col+7Y8WVYdve01Za8RH9jytezYSWFBV91sVG0?=
 =?us-ascii?Q?5cxyhhws+3EDWXpZKu3F4RN81ulUvTHS3D2PqiN6tnpjxlST9Rg+Z8O/BMdA?=
 =?us-ascii?Q?w/r9F8B7kWng5KFD+guWRjbFPDhq0xDyNE6xGtv2lm1/0xvSvLVc/Yd2PqPr?=
 =?us-ascii?Q?/+Odz6apkik1pDgajI9JWxEu3w0XmmC9A9vqHvxSWrO/gkNxCIzsejDMDBqY?=
 =?us-ascii?Q?d71baknUWgtQtkd+2q1CBDm0sXVKCxkoMMOZWVp3pfzExbnAuCHC3Ftc5Z1m?=
 =?us-ascii?Q?FY85rCz71iksFwJswNDfRmKaJVL+iQMjd/LUU+jVUUSYmcOcDdS335U3mqzc?=
 =?us-ascii?Q?VAfkqRAaVIfLuP0IgAHKOlZKyQmFuHrzqmR6U6REusXw66nOlFARG+lrI+UW?=
 =?us-ascii?Q?T9BIPRm+YOnMfV4iakbjtJkkdtEwM0LamZOombhG7y+Fvukxn1DgrTwAjRXg?=
 =?us-ascii?Q?f0zy4YWvAVx0dHLeTTLpAHsNwcM0dtXMboMahpPhRwegf034DlPZyJZG581l?=
 =?us-ascii?Q?w8WKjglhgQAFM1D36njmo+lqmHXiaBujyowYcpiQz9u6EZi4MmQhJyRp33FR?=
 =?us-ascii?Q?pirJGGFic0FR0whR+YDZBwZy19G+DPuCGftxMvFqP2mKuiaaDWJcDDvSC3ON?=
 =?us-ascii?Q?uHVqiDgm1xYidDUdKr6CRTFIl2nXH1aiacR2U7V3GIECdQKDtKHhOZjlim/n?=
 =?us-ascii?Q?LV79y6TM1SC0/Ri/ApyEAaAITs7cXk4K9k24hNsmg1NFIdsM3lAqSUAFAAX/?=
 =?us-ascii?Q?ew=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 00665e11-e4ad-4f6b-a457-08da9161f5b2
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2126.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2022 06:18:34.7264
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UM+c/IiOw1w75yJ6D0LGtkDPTITy6sxtNSVvbiYYSCLsxVbrLn4bCxewC+f/2ifsxDx2Tmy696p3lZ4hShR2R/27pSEa5mFAFXi16qfBE5U=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5789
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Robert Richter wrote:
> The UID is needed to read the RCH's CEDT entry with the RCRB base
> address. Determine the host's UID from its ACPI fw node.
> 
> Signed-off-by: Robert Richter <rrichter@amd.com>
> ---
>  drivers/cxl/acpi.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/drivers/cxl/acpi.c b/drivers/cxl/acpi.c
> index f9cdf23a91a8..b3146b7ae922 100644
> --- a/drivers/cxl/acpi.c
> +++ b/drivers/cxl/acpi.c
> @@ -368,8 +368,20 @@ struct pci_host_bridge *cxl_find_next_rch(struct pci_host_bridge *host)
>  static int __init cxl_restricted_host_probe(struct platform_device *pdev)
>  {
>  	struct pci_host_bridge *host = NULL;
> +	struct acpi_device *adev;
> +	unsigned long long uid = ~0;
>  
>  	while ((host = cxl_find_next_rch(host)) != NULL) {
> +		adev = ACPI_COMPANION(&host->dev);
> +		if (!adev || !adev->pnp.unique_id ||
> +			(kstrtoull(adev->pnp.unique_id, 10, &uid) < 0))
> +			continue;
> +
> +		dev_dbg(&adev->dev, "host uid: %llu\n", uid);
> +
> +		if (uid > U32_MAX)
> +			continue;

Looks redundant with existing _UID matching.