Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220908014854.151203-1-yangjihong1@huawei.com>
In-Reply-To: <20220908014854.151203-1-yangjihong1@huawei.com>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Wed, 7 Sep 2022 23:59:27 -0700
Message-ID: <CAM9d7ciPd4vf3v1rdOD43vR-bh0pjj1LCcrMVTLfH6Fcxx_Dsw@mail.gmail.com>
Subject: Re: [PATCH] perf lock: Remove redundant word 'contention' in help message
To:     Yang Jihong <yangjihong1@huawei.com>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        linux-perf-users <linux-perf-users@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hello,

On Wed, Sep 7, 2022 at 6:52 PM Yang Jihong <yangjihong1@huawei.com> wrote:
>
> Before:
>   # perf lock -h
>
>    Usage: perf lock [<options>] {record|report|script|info|contention|contention}
>
>       -D, --dump-raw-trace  dump raw trace in ASCII
>       -f, --force           don't complain, do it
>       -i, --input <file>    input file name
>       -v, --verbose         be more verbose (show symbol address, etc)
>           --kallsyms <file>
>                             kallsyms pathname
>           --vmlinux <file>  vmlinux pathname
>
> After:
>   # perf lock -h
>
>    Usage: perf lock [<options>] {record|report|script|info|contention}
>
>       -D, --dump-raw-trace  dump raw trace in ASCII
>       -f, --force           don't complain, do it
>       -i, --input <file>    input file name
>       -v, --verbose         be more verbose (show symbol address, etc)
>           --kallsyms <file>
>                             kallsyms pathname
>           --vmlinux <file>  vmlinux pathname
>
> Fixes: 528b9cab3b81 ("perf lock: Add 'contention' subcommand")
> Signed-off-by: Yang Jihong <yangjihong1@huawei.com>

Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks for the fix!

Namhyung


> ---
>  tools/perf/builtin-lock.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/tools/perf/builtin-lock.c b/tools/perf/builtin-lock.c
> index dd11d3471baf..ea40ae52cd2c 100644
> --- a/tools/perf/builtin-lock.c
> +++ b/tools/perf/builtin-lock.c
> @@ -1874,8 +1874,7 @@ int cmd_lock(int argc, const char **argv)
>                 NULL
>         };
>         const char *const lock_subcommands[] = { "record", "report", "script",
> -                                                "info", "contention",
> -                                                "contention", NULL };
> +                                                "info", "contention", NULL };
>         const char *lock_usage[] = {
>                 NULL,
>                 NULL
> --
> 2.30.GIT
>