Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
Message-ID: <2ba61271-8d3f-cbd2-164e-8f4968e5dcad@amd.com>
Date:   Thu, 8 Sep 2022 12:35:27 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.13.0
Subject: Re: [PATCH v3 4/4] drivers: misc: Add Support for TMR Inject IP
Content-Language: en-US
To:     Greg KH <gregkh@linuxfoundation.org>,
        Appana Durga Kedareswara rao 
        <appana.durga.kedareswara.rao@amd.com>
CC:     <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <michal.simek@xilinx.com>, <derek.kiernan@xilinx.com>,
        <dragan.cvetic@xilinx.com>, <arnd@arndb.de>,
        <linux-arm-kernel@lists.infradead.org>, <git@amd.com>
References: <20220908042444.2866731-1-appana.durga.kedareswara.rao@amd.com>
 <20220908042444.2866731-5-appana.durga.kedareswara.rao@amd.com>
 <YxmFgblww9VfySnv@kroah.com>
From:   "Rao, Appana Durga Kedareswara" <appanad@amd.com>
In-Reply-To: <YxmFgblww9VfySnv@kroah.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2022 07:07:15.9523
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 32d31fca-2193-4e81-2dd4-08da9168c2fa
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT003.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6190
X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Greg,

Thanks for the review.

On 08/09/22 11:32 am, Greg KH wrote:
> On Thu, Sep 08, 2022 at 09:54:44AM +0530, Appana Durga Kedareswara rao wrote:
>> The Triple Modular Redundancy(TMR) provides functional fault injection by
>> changing selected MicroBlaze instructions, which provides the possibility
>> to verify that the TMR subsystem error detection and fault recovery logic
>> is working properly, provided sysfs entries which allow the user to inject
>> a fault.
>>
>> Usage:
>> echo 1 > /sys/kernel/debug/xtmr_inject/inject_fault/inject_fault
>>
>> Signed-off-by: Appana Durga Kedareswara rao <appana.durga.kedareswara.rao@amd.com>
>> ---
>> Changes for v3:
>> --> Updated the driver to use fault-injection api as suggested by Greg.
>> --> Updated the Kconfig to compile the driver as a module.
>> Changes for v2:
>> --> Fixed Month in the sysfs description.
>> --> Fixed line over 80 char in driver.
>> --> Replaced kstrtol with kstrtoul as suggested by Michal.
>> --> Added error check for xlnx,magic value.
>>
>>   MAINTAINERS                      |   6 +
>>   drivers/misc/Kconfig             |  10 ++
>>   drivers/misc/Makefile            |   1 +
>>   drivers/misc/xilinx_tmr_inject.c | 181 +++++++++++++++++++++++++++++++
>>   4 files changed, 198 insertions(+)
>>   create mode 100644 drivers/misc/xilinx_tmr_inject.c
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 5fc5ec13985e..1207effa8e15 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -13284,6 +13284,12 @@ F:	Documentation/ABI/testing/sysfs-driver-xilinx-tmr-manager
>>   F:	Documentation/devicetree/bindings/misc/xlnx,tmr-manager.yaml
>>   F:	drivers/misc/xilinx_tmr_manager.c
>>   
>> +MICROBLAZE TMR INJECT
>> +M:	Appana Durga Kedareswara rao <appana.durga.kedareswara.rao@amd.com>
>> +S:	Supported
>> +F:	Documentation/devicetree/bindings/misc/xlnx,tmr-inject.yaml
>> +F:	drivers/misc/xilinx_tmr_inject.c
>> +
>>   MICROCHIP AT91 DMA DRIVERS
>>   M:	Ludovic Desroches <ludovic.desroches@microchip.com>
>>   M:	Tudor Ambarus <tudor.ambarus@microchip.com>
>> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
>> index 1508cc29b05a..7b1930a7f18a 100644
>> --- a/drivers/misc/Kconfig
>> +++ b/drivers/misc/Kconfig
>> @@ -506,6 +506,16 @@ config TMR_MANAGER
>>   
>>   	  Say N here unless you know what you are doing.
>>   
>> +config TMR_INJECT
>> +	tristate "Select TMR Inject"
>> +	depends on TMR_MANAGER && FAULT_INJECTION
> 
> But if CONFIG_FAULT_INJECTION_DEBUG_FS is not enabled, does this driver
> actually do anything?  Why not just depend on that option?
> 

Sure will fix and will post v4.

Regards,
Kedar.

> thanks,
> 
> greg k-h