Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp272919rwn; Thu, 8 Sep 2022 01:04:39 -0700 (PDT) X-Google-Smtp-Source: AA6agR7jgOJyTOZIr+1+22vCnqrYC1NR5sE64iwlnw4uuWoch3OH0dXMFHxiKsjyPK/Zap8vND/D X-Received: by 2002:a17:907:3f15:b0:76e:fbf3:6edc with SMTP id hq21-20020a1709073f1500b0076efbf36edcmr5198103ejc.349.1662624279331; Thu, 08 Sep 2022 01:04:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662624279; cv=none; d=google.com; s=arc-20160816; b=BNHYhAluL8qAbFM5IIRaDYH7cexIb8N1ei6W8nYOhPanvNuxdQ7GqNgwECT/ZN29aq DxJvacuwgw8vtr3n47rhiLrR5W66PpcNiDPd9VIt0A8YwDwibqKyLVb4w1Tf9rezTpil +GG3TsSQLaw9WUdMrxQaicbqUbYxItBHY1s9qizqvZMRcdP5WMfSRlrGX5NBkwMbAaKz QNeRSVAEwMNe1n3tPq9GJrsjJMgLzzUrmN+diGrUyCvjgb4dt79aR3LHxBtmHOtwpLUw /Ex/o/ptvRvzT7O+XikKBMsU/RS8FDUIHy4CbcCciuQR8cau6ASAVH620qOaubEsCKEf bh5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version; bh=RhnrPpOs8U7U5e/dDJlH9qsFhHWq2idwdbhm4KgyDo4=; b=KILeOd9tnYdbirjmNB7j2hcNzeWGERB2n4OhS+li0RqdfmW8Yj4+J+g75MBY15LOxi fGBqC6uZcELW4Uw9ZbBv3cf6OWEI4Le3GmEmco9hmv0naR7kli14phWcO+wPcLcpAhMD /DQsZVyeKO289yVZ+yZAgUrfxBZ+AZV9XqAAjddlRV5qe83jnuXLdt54RrdwUk+kmbIO foD/dfj6UamfbhrCKH4xvP6VyInUGWLNJ90MR0yjDeQgp+0sckCcm1D6GAnPAfcxvoV9 W1Ha78X3IcQm1AqoqiLMMAXZKdgKcEiVIK3+8fP9rgoio4Fb32NUvPdgrqLiDq7WjpEx 4bEQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g11-20020a170906868b00b007306b2bfa66si1433016ejx.851.2022.09.08.01.04.02; Thu, 08 Sep 2022 01:04:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229748AbiIHHI3 (ORCPT + 99 others); Thu, 8 Sep 2022 03:08:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39122 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229884AbiIHHIX (ORCPT ); Thu, 8 Sep 2022 03:08:23 -0400 Received: from mail-oa1-f50.google.com (mail-oa1-f50.google.com [209.85.160.50]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C79DA1D54; Thu, 8 Sep 2022 00:08:18 -0700 (PDT) Received: by mail-oa1-f50.google.com with SMTP id 586e51a60fabf-1279948d93dso22228760fac.10; Thu, 08 Sep 2022 00:08:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=RhnrPpOs8U7U5e/dDJlH9qsFhHWq2idwdbhm4KgyDo4=; b=lYW3S3bB/fE704zu/ErhyTkBvFw+M4YZOzIBsKsTTBUTSQeZsgEcanqEm1gbvDCgao 3Vtl/tLIdz8pGuIu57x+oBCHoe1zNsqRAeMLFY2D+ofTEoPJR8OIsbQD8dAZd2iiLUGG UGaEV/cogSLnpOb/qh1GySGkXbvUGKybj16Dl+rHsHnCbBOPN45NtWScVUyXJiDbSRk4 CIKUgWSUTAm0nvCLGbUkbyfbH20bljJu8+iownsPZLFcT+/KeR3Ak6LTbcjrqwVccqrA gTIBUHMnee69//hg8rYKewfcubvaWRQBU6RZtnBQoRyUnN+1vt50zsGm2M9lpj0bLVjQ KB4w== X-Gm-Message-State: ACgBeo3FwqW2DcmWRAHG2GRjfFZio6Grt+WWwvyTcoFnh15tCyCDnYh1 O9+wrpwdO31dWPh7yi7yjyeOeauUzNoC9iteHYs= X-Received: by 2002:a05:6870:5b84:b0:10c:d1fa:2f52 with SMTP id em4-20020a0568705b8400b0010cd1fa2f52mr1158961oab.92.1662620897764; Thu, 08 Sep 2022 00:08:17 -0700 (PDT) MIME-Version: 1.0 References: <20220908021141.27134-1-shangxiaojing@huawei.com> In-Reply-To: <20220908021141.27134-1-shangxiaojing@huawei.com> From: Namhyung Kim Date: Thu, 8 Sep 2022 00:08:06 -0700 Message-ID: Subject: Re: [PATCH 0/4] perf: Clean up by adding helpers To: Shang XiaoJing Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , linux-perf-users , linux-kernel Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Wed, Sep 7, 2022 at 6:37 PM Shang XiaoJing wrote: > > Some clean up in builtin-lock.c, builtin-timechart.c, and > builtin-trace.c. > > Shang XiaoJing (4): > perf trace: Use zalloc to save initialization of syscall_stats > perf lock: Add get_key_by_aggr_mode helper > perf timechart: Add create_pidcomm helper > perf timechart: Add p_state_end helper Acked-by: Namhyung Kim Thanks, Namhyung > > tools/perf/builtin-lock.c | 129 ++++++++++++++------------------- > tools/perf/builtin-timechart.c | 65 +++++++++-------- > tools/perf/builtin-trace.c | 5 +- > 3 files changed, 88 insertions(+), 111 deletions(-) > > -- > 2.17.1 >