Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755176AbXFREvs (ORCPT ); Mon, 18 Jun 2007 00:51:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750895AbXFREvl (ORCPT ); Mon, 18 Jun 2007 00:51:41 -0400 Received: from pasmtpb.tele.dk ([80.160.77.98]:47934 "EHLO pasmtpB.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750849AbXFREvk (ORCPT ); Mon, 18 Jun 2007 00:51:40 -0400 Date: Mon, 18 Jun 2007 06:52:44 +0200 From: Sam Ravnborg To: Adrian Bunk Cc: Andrew Morton , "Antonino A. Daplas" , linux-kernel@vger.kernel.org Subject: Re: [-mm patch] arch/i386/video/fbdev.c should #include Message-ID: <20070618045244.GA20224@uranus.ravnborg.org> References: <20070606220313.8f7c1fab.akpm@linux-foundation.org> <20070617234257.GE3588@stusta.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070617234257.GE3588@stusta.de> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 917 Lines: 27 On Mon, Jun 18, 2007 at 01:42:57AM +0200, Adrian Bunk wrote: > Every file should include the headers containing the prototypes for > it's global functions. > > Signed-off-by: Adrian Bunk > > --- > --- linux-2.6.22-rc4-mm2/arch/i386/video/fbdev.c.old 2007-06-17 15:48:25.000000000 +0200 > +++ linux-2.6.22-rc4-mm2/arch/i386/video/fbdev.c 2007-06-17 15:48:53.000000000 +0200 > @@ -11,6 +11,8 @@ > #include > #include > > +#include > + 1) Why not include asm/fb.h from linux/fb.h? 2) Is asm/fb.h an -mm thing? I do not have it in my linus tree. Note: Ketchup is broken on my ubuntu box so no -mm right now. Sam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/