Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp336241rwn; Thu, 8 Sep 2022 02:19:35 -0700 (PDT) X-Google-Smtp-Source: AA6agR5olE6pQuspV/Y2WNcfqRgxmYUaivPCHBWsOh+W6fN2cYCmti6G5IpG8gNexec8Oa7abBFY X-Received: by 2002:a62:55c3:0:b0:536:729:71d8 with SMTP id j186-20020a6255c3000000b00536072971d8mr8556242pfb.53.1662628775364; Thu, 08 Sep 2022 02:19:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662628775; cv=none; d=google.com; s=arc-20160816; b=MXvvArlhmhRBsrKEvtbDwqSmUfFDZhDfPzvfRD7kCndCbFHddT2Q7dNxk3a8Xswnkd GCXznB86ePfKKM/X37CChpIWkwlUXvWlNhecVguYkbxl1HVj3tcEA9InghlmxMg+85Sm 7QHQOGLueeo1TavMmRwd67fbrFOpOk80uTHX7M5aBDfNRxI1vZHRpsIt8fsRJT/gXc/1 ee9nNZY73qa9yBE6jqhd7DFSqhYk8KCy/igplBqMeb7fUgeutyZVrf2k4FhICS5+p3XD qSqxiYhXV4EfLQ3+YPYqFCtBGLa65zMf982cl5QlbnDKVO/OjtQon2T0vzwIKtn/jncJ POzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=EwWxrorUf0t5RelWvYwxkGlKAd06wzLiUvgHfS7saik=; b=RkVRYQqBO1brhTujq+XPdJo2asZ8DKB1xzqwRTJbchQWqjglIfs2ORI7wyPZMKfVJC RwjL4sF/fm2t4Ap8xBeT0zm27Z8RbUBVR3FxlRJkal43/hSaJnLtZjLYtUXfv+PSOvw5 AHx8ILb9MUGCMJwHFbyuIZVJUC1IWcSFPMmo0GfTUfscnY1zKox7sPymwFtIXQFWdY3z VcxRBQwcDXBVyGVrUNMmQKsWO+CUWwOYuX6GZzTnPl3fgdyuGwMGP83E/hK7F7ytKAiy feLxsL6H64peXkn9a4vawOUA3a8UhxcvytYkEYoJrFaznUoJGJrTaQcPqA7JC8M/e9lp xP1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=V4ujnzw8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j5-20020a636e05000000b0043077f2f57asi18243376pgc.213.2022.09.08.02.19.23; Thu, 08 Sep 2022 02:19:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=V4ujnzw8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230446AbiIHIxP (ORCPT + 99 others); Thu, 8 Sep 2022 04:53:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230400AbiIHIwq (ORCPT ); Thu, 8 Sep 2022 04:52:46 -0400 Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D057F7773 for ; Thu, 8 Sep 2022 01:51:49 -0700 (PDT) Received: by mail-lj1-x236.google.com with SMTP id y29so6454509ljq.7 for ; Thu, 08 Sep 2022 01:51:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=EwWxrorUf0t5RelWvYwxkGlKAd06wzLiUvgHfS7saik=; b=V4ujnzw8vMuY/a05YcTrFpZgg/5LFWS4wW5dJiv0AsoB4o63I5VUBvtF0SNMRRsD4T P+iIMwIHS5+xR0r1Jp5E6vuIDEktjNeuzhWABTroJ3cjo1CgBxgXCWPqCjOLIsYXRJu5 67C8s/Q9m3Qnh3UnzQT53njfKnfkqsVxPSvnlFxsMyhTFTwj46+voSNUFSH5pn75T0Wy LrNkEUc6vlp0csIHShHvS1fkFYb+t9NKThJv4Cqi6Izg+K14Kn3y8oMIqkFN+PQeg43R 34S/RGduROl1gmzE+Q4C7ZAU+gAlGUF8JqnVR0tdPPn1XgQ12rax/1e6kEM3mCIb4Kqj vW+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=EwWxrorUf0t5RelWvYwxkGlKAd06wzLiUvgHfS7saik=; b=qd4Je2OvtubB/UUQgx0yUarUU1k6P1pqmlF5uSwgd7HvnXiSGtvz5GEA+rViNZFBPd tnCHRbzgkX29Z+7eUwmAuBAFo/vCg1mQr3TBEsfoBmLIbaySIicI0wdXiMTZL6jmWF5r zKD9mHE/2Nb3F6qk7np6scQCSE5qmVCT60HstVsqnu8nBYN0cuK/1TJdifFrtKUmFuu4 8GhaQttjGQFzu2+ekdMMcXWY9Dh+MlDv0wmhutq2bspg5zUAXabrTVWC5WL17+nxFhBy 9ccOoC43gO2j6DI6Vgp/3nTH7PgAkWSatfqiC7XpWj3AvMLLFJNVY06VSY7E3w+znWVs ldsQ== X-Gm-Message-State: ACgBeo3r6CZciegZAYXAJ6mn/Me6iBVYfWFdFTw/M+Ih7S2qWrT8xT0l QzkG7eEWoYVd/U0K8IzdBRbzlQ== X-Received: by 2002:a2e:8181:0:b0:25f:e028:a67 with SMTP id e1-20020a2e8181000000b0025fe0280a67mr2269290ljg.89.1662627107903; Thu, 08 Sep 2022 01:51:47 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id f10-20020a05651232ca00b00497ab39bcd0sm695212lfg.96.2022.09.08.01.51.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Sep 2022 01:51:47 -0700 (PDT) Message-ID: <0a977d86-e137-c328-ce7f-ef7941860936@linaro.org> Date: Thu, 8 Sep 2022 10:51:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCHv2 08/13] dt-bindings: mfd: add rk806 binding Content-Language: en-US To: Sebastian Reichel , Heiko Stuebner , Rob Herring , Krzysztof Kozlowski , Lee Jones Cc: Michael Turquette , Stephen Boyd , Linus Walleij , Mark Brown , Liam Girdwood , Alexandre Belloni , Alessandro Zummo , linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@collabora.com References: <20220908003107.220143-1-sebastian.reichel@collabora.com> <20220908003107.220143-9-sebastian.reichel@collabora.com> From: Krzysztof Kozlowski In-Reply-To: <20220908003107.220143-9-sebastian.reichel@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/09/2022 02:31, Sebastian Reichel wrote: > Add DT binding document for Rockchip's RK806 PMIC. > > Signed-off-by: Sebastian Reichel > --- Thank you for your patch. There is something to discuss/improve. > + vcca-supply: > + description: > + The input supply for pldo-reg6. > + > + regulators: > + type: object > + patternProperties: > + "^(dcdc-reg([1-9]|10)|[pn]ldo_reg[1-6])$": You still have underscore in the pattern. This should pop-up during test: please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Best regards, Krzysztof