Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Olivier Masse <olivier.masse@nxp.com>
To:     "sumit.garg@linaro.org" <sumit.garg@linaro.org>
CC:     "sumit.semwal@linaro.org" <sumit.semwal@linaro.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linaro-mm-sig@lists.linaro.org" <linaro-mm-sig@lists.linaro.org>,
        "christian.koenig@amd.com" <christian.koenig@amd.com>,
        "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
        =?iso-8859-15?Q?Cl=E9ment_Faure?= <clement.faure@nxp.com>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "jens.wiklander@linaro.org" <jens.wiklander@linaro.org>,
        "op-tee@lists.trustedfirmware.org" <op-tee@lists.trustedfirmware.org>,
        "etienne.carriere@linaro.org" <etienne.carriere@linaro.org>
Subject: Re: [EXT] Re: [PATCH v2 0/1] tee: Add tee_shm_register_fd
Thread-Topic: [EXT] Re: [PATCH v2 0/1] tee: Add tee_shm_register_fd
Thread-Index: AQHYrlglkVt62yOLKU2bEUe77YcK2K217YWAgB99bAA=
Date:   Thu, 8 Sep 2022 09:18:43 +0000
Message-ID: <fb641c168a6b9fc041785a0baa8ee4b2d3ff8ed4.camel@nxp.com>
References: <20220812143055.12938-1-olivier.masse@nxp.com>
         <CAFA6WYM89+SrW2Br-fnFke4djt4GgGHXn7JS3=rxvAa7dAAY7w@mail.gmail.com>
In-Reply-To: <CAFA6WYM89+SrW2Br-fnFke4djt4GgGHXn7JS3=rxvAa7dAAY7w@mail.gmail.com>
Accept-Language: fr-FR, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-15?Q?dvxdqz0bVmplNoRPSy3CMDCT8ILcpOqJApwKnGrC5UrXa4d46AaM84zqh?=
 =?iso-8859-15?Q?o3wrdho7WBrafUCvlJiwqX0BqN7lZL0D4ctkGc8pY5F7wh0zcWGD3sf2n?=
 =?iso-8859-15?Q?DXckPq+M+wZpgNHeZFcherBAYHadlt426jCK+c5VSMQbaoYtqFNYXeHRs?=
 =?iso-8859-15?Q?jFuV//BnzJyxPeMR819bL3/YCCORxpCt11yPAVmzQ2CvToYkhbYxmMGL7?=
 =?iso-8859-15?Q?cuGhl/Xdx8XjbS0eSnslC/JoBwwqwJJTbdg6EVnoYSdWtAlVUB7QngPUO?=
 =?iso-8859-15?Q?yTlJPqObpdKJx6/PaxCH5TtI99gseJHn+BjUqrVD3stQbHE+GepiRNKA1?=
 =?iso-8859-15?Q?kJbdkz0ghKNmMotMwUOJXjADMDYeSWzt0Wc/BDhCrfJB1GaB1mlmsYSRA?=
 =?iso-8859-15?Q?mPvnOQu2MPVTxBvnxv9dKnN3XhP6OV0Y3caYBoLamvzwAYWutApBBd+/N?=
 =?iso-8859-15?Q?uZUOtE7z4ahKdvwhK+XFH13rzGQc/arSzQ9ThPLKNlEecwdf29nTTcoM5?=
 =?iso-8859-15?Q?LgRmDVBr6U+TvzfdhAP9i2NWQqNAb1t9Q3WBbhz9qUf+aB2ULRPe4lh8N?=
 =?iso-8859-15?Q?fp72rkwASPs1srZATemRM9w37yi92BaDcEkXdhCF6ZlVqUS8ou7kkF3Ff?=
 =?iso-8859-15?Q?wAG9z4tBztXxyDWPGDTSoiF4lh7NM8v8eVwdin6rzg8BiAIV5F5+TeyPg?=
 =?iso-8859-15?Q?zEpzrDPUFI6AWLHE/fwA/S2zQd0tcZhD/1Hota1RqB7aHNzhFD83zafuR?=
 =?iso-8859-15?Q?v0Z6Iic4SJ4m1B9ESy/JgJL9LUU8MhnwlVzSOTXTWjMNlbcdcAXyuh56Y?=
 =?iso-8859-15?Q?6QiTiATUG4NN8kOYYOJMTYgXSZA1GV0tEEJJMmBC/UzgL6sFg+XtSjb3X?=
 =?iso-8859-15?Q?VL0euF8uNznA1Pkqh02LlHnr+aiOxGENE+1iFgYidwx+ZZ/lHiNv5A3IT?=
 =?iso-8859-15?Q?34izfh4D/vxjynQQ/HlQv/mT9tObYnZ7H1YlNDu+fdjAaVhQr2Z6bby6A?=
 =?iso-8859-15?Q?ittdk+Fl9c6KioSeRWO0zeCvnN/qtxrl7jp5yvsCpEfd3CaH25IsjwrZ9?=
 =?iso-8859-15?Q?BYtixKLKTwqo9iPPOflldhGK8hIRhYweIIqE+ZrJGSvrYRAAq6LGVOl8L?=
 =?iso-8859-15?Q?ZuNFkiVmOuRR7z+6JosOgZAwAultf635IOz11ewPp6vBSUt0l7QJ+hqRT?=
 =?iso-8859-15?Q?UweysUhIujy5XNxNKqMQtzmHQt9HJ41CfmAEi6XHW71sLofZXObk8Ph22?=
 =?iso-8859-15?Q?T0xe27b0ZWhHbDeC5XI4LmY8ducp7QDLhBchxWwlHwNeVgG8a1XdQqJS9?=
 =?iso-8859-15?Q?4n1iAfulCNPkb5qA+k29Hs8mmJvnQDr5lOicpNEBEMJXTfOhxNcmeagGY?=
 =?iso-8859-15?Q?StMfHAjHxYJErNZ/BpgQjME70tNisanf2Z/Qgqx32c0mTzbownFM45kj+?=
 =?iso-8859-15?Q?QylfyHTIFzeydAbqqqKolv5QAzOOo2PRNF9837744+Tq6YsAlUo5ctcHg?=
 =?iso-8859-15?Q?mp+6ZOD+cMrEd0a2n9mXyypnLKKId7r+kCH7P3FGuvckG1wsYvBayR5db?=
 =?iso-8859-15?Q?rL1EQHaeMPesEUWfnGI/D0nqW3L0t+c9ARNFwkr3S6NRKoNbZjMtwqYmN?=
 =?iso-8859-15?Q?rrxPwj2p7kbRSfhgS/RDTarth33THhYJX1DTgth4B8u0xoLiEtQBSKJFk?=
 =?iso-8859-15?Q?SblJv3oeraqyLpi1JwfOV04t7w=3D=3D?=
Content-Type: text/plain; charset="iso-8859-15"
Content-ID: <0A3212FE247CC248A5244C6E9B995876@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6737.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9294ae72-ccf1-43a2-f88a-08da917b206d
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Sep 2022 09:18:43.6804
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: X9cJjUkbetImf7cUVaecakHgmmMvPu3RAbpRe4EqVbwH19z142xj3MZ3VGAbAAZz5oaJWfACLzmVnaYFqZuktg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB2797
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Sumit

On ven., 2022-08-19 at 13:54 +0530, Sumit Garg wrote:
> Caution: EXT Email
>=20
> Hi Olivier,
>=20
> On Fri, 12 Aug 2022 at 20:01, Olivier Masse <olivier.masse@nxp.com>
> wrote:
> >=20
> > Add a new ioctl called TEE_IOC_SHM_REGISTER_FD to register a
> > shared memory from a dmabuf file descriptor.
> > This new ioctl will allow the Linux Kernel to register a buffer
> > to be used by the Secure Data Path OPTEE OS feature.
> >=20
> > Please find more information here:
> >=20
https://eur01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fstatic.=
linaro.org%2Fconnect%2Fsan19%2Fpresentations%2Fsan19-107.pdf&amp;data=3D05%=
7C01%7Colivier.masse%40nxp.com%7C05071ff1c28044ab740908da81bc44e2%7C686ea1d=
3bc2b4c6fa92cd99c5c301635%7C0%7C1%7C637964942860947359%7CUnknown%7CTWFpbGZs=
b3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C30=
00%7C%7C%7C&amp;sdata=3DnYLb2iMoJExdKEg4CL4eW5%2FQ%2Bqqj4Iw1TxFsd1UqWW0%3D&=
amp;reserved=3D0
> >=20
> > Patch tested on Hikey 6220.
> >=20
>=20
> AFAIU, for the OP-TEE SDP feature to work you need to have a DMA-BUF
> heap driver for allocating secure buffers through exposed chardev:
> "/dev/dma_heap/sdp". Have you tested it with some out-of-tree driver
> as I can't find it upstream? Also, do you plan to push that upstream
> as well?

It has been tested with linaro,secure-heap reserved dma heap memory
which is also in review for upstream.

>=20
> BTW, please add a changelog while sending newer patch-set versions.
>=20
> -Sumit
>=20
> > Etienne Carriere (1):
> >   tee: new ioctl to a register tee_shm from a dmabuf file
> > descriptor
> >=20
> >  drivers/tee/tee_core.c   | 38 +++++++++++++++
> >  drivers/tee/tee_shm.c    | 99
> > +++++++++++++++++++++++++++++++++++++++-
> >  include/linux/tee_drv.h  | 11 +++++
> >  include/uapi/linux/tee.h | 29 ++++++++++++
> >  4 files changed, 175 insertions(+), 2 deletions(-)
> >=20
> > --
> > 2.25.0
> >=20