Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Jun Li <jun.li@nxp.com>
To:     Alexander Stein <alexander.stein@ew.tq-group.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        dl-linux-imx <linux-imx@nxp.com>
CC:     "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 0/4] USB host support for TQMa8MPxL + MBa8MPxL
Thread-Topic: [PATCH 0/4] USB host support for TQMa8MPxL + MBa8MPxL
Thread-Index: AQHYwsihZnSWdyGvYEiiheIFncU2x63UHe0wgADqGoCAAC6nAA==
Date:   Thu, 8 Sep 2022 09:07:06 +0000
Message-ID: <PA4PR04MB9640E5CB572980CB087BE9E389409@PA4PR04MB9640.eurprd04.prod.outlook.com>
References: <20220907144624.2810117-1-alexander.stein@ew.tq-group.com>
 <PA4PR04MB9640CB3CA93301CA1571D85789419@PA4PR04MB9640.eurprd04.prod.outlook.com>
 <3126965.5fSG56mABF@steina-w>
In-Reply-To: <3126965.5fSG56mABF@steina-w>
Accept-Language: zh-CN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?lPoMNt+4MpqtddIioU9Mi+cti1Lnl8vEQ2vkh16tQBeESUIU8424mc1/re8t?=
 =?us-ascii?Q?0fOEMU39IPiH0oz49bQOG9fMnOrPZ8M3cMdJDgRyBfQ24RlRzWusFinZ+fYy?=
 =?us-ascii?Q?UBfUwcM6w0VY/C1jSs+i/w2Y0WivNWBI3NiIgETZOTkjXuhVN+e+QD60kvtl?=
 =?us-ascii?Q?KcYC6ANg96eWZ9QD8DcEGv14uKzkaSN44UkddKxTeS5dKIgM/P/ue1ErDy/2?=
 =?us-ascii?Q?EHEwXSWQMxRlHU14GnCzfxeULB6p8G62SmJf6P0LfETsbGRFQwppFZlforau?=
 =?us-ascii?Q?RIVy67/2iasDQsCcAozRwieMi9+hWBy5pcTkKi1YkrEP2e7IzRwlZp7FgrT3?=
 =?us-ascii?Q?31kS0a832Lmuib3ERwJEr3iLAIXgHoehI2pEZVnp8OgixJroMUhUr7nwMx+I?=
 =?us-ascii?Q?KJkk0GlSXeniAiRsxJ0G3OEkRNrkIPNp2d4If0BywNS8YhVzGy4sh26I5kvI?=
 =?us-ascii?Q?CttHwOdK2zOWhBzk+JzEVqGo00rtMu057OJk1DGlATiFAvPETHL3UnL76Msi?=
 =?us-ascii?Q?Jox3mfiTNbkYLTrMfED4TQ5JWRa3UBkHFUyveuuQ/buKTgZ0C64wWcRqzxRk?=
 =?us-ascii?Q?UOL2QYBHyWn+Q6PJ4xkYuehFj2gK+WzHUfachGgwf6ufN2mcCGO9zgDO9n3w?=
 =?us-ascii?Q?yQoDnAsjjac+bl1kXYhvv15CBGyEqimoI7Z0bCYl3Eq4GfoFXe+A6bFP27j1?=
 =?us-ascii?Q?qVarINr1l0PwRczs1PJoUTNv29+EODh4XB4NlguYgyYuN4Ond2Ub37Gg1Gu2?=
 =?us-ascii?Q?GImxr3+ScjaG3WThjAOh8O3x6YRtXodENR/Ellg+qJL6R/8QbwAFBqFaBc9W?=
 =?us-ascii?Q?gHOAsE+8Rayd0IHdAf9kQtU9ZLdhuDTUrmh7yV2/GtJLKtM5vwPlA3H1XH6O?=
 =?us-ascii?Q?7RQ28lH8oCpcZfPDzAPKAT3SSl2YyPDMiL7iku18370ZUpBF5wOkNYUH6di4?=
 =?us-ascii?Q?Smwk/TYyR18vX/5/dPca+u8kUVHoiruk1yRfXfXdJry/B+4G1MLVEE2msiBs?=
 =?us-ascii?Q?SdoFEwyV3Y/r8vwQoqiTmhM7yWA7OIT+5K3+JyP+63vwl6EmDKQ29xct+5g2?=
 =?us-ascii?Q?NH5CEQ3c/wAWLQeRc3neLGCtJlvRtlwLcIOR3WIAZPAokqHWB6xj7qp0aW/2?=
 =?us-ascii?Q?dPcfu6klprL/Pyko/LvYGwOqP4tQQoXeOlrpIe9nyX14zA3Z0/yaVcwcKd9O?=
 =?us-ascii?Q?DSl9eTelS9PPlv2UXKQwG6Q/xHr8HI4nlv842/d68FNy70LRmQG9NyJxyYai?=
 =?us-ascii?Q?ESh2tSoWRzrmVpDMddMNPWyKR6jV5FGCj+eExT5+W/SwDbu9aupE63oAYzBo?=
 =?us-ascii?Q?tTxuhf37mTp6HGmXk2i3bldc2tghgTBJHJWFCboFk90i+4iqtRY7RjDcCktV?=
 =?us-ascii?Q?CLVg66HghoFgWUw9+DgMTPRgDfmxpjQZaPnwYatnmrOdLKgopFiXuXCG28ud?=
 =?us-ascii?Q?0fYHYGSiYHPztkuPOApMB0wOE02aSGRLIj4gHZjf79kdT0JIGoB7ursrX2Cu?=
 =?us-ascii?Q?Re3hvSKrrWG7ct/yGJN6SyOFIa6adhtv61zx9BPWSRJQQIiF7O7fLgk/OHpD?=
 =?us-ascii?Q?BwnvVBpyTybFVFwZuHg=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR04MB9640.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a383a6c7-97a2-47e8-1a56-08da9179810b
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Sep 2022 09:07:06.8249
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: W12fPpVcs3H8xE7vuAxkvb03xf+aSbzpsHfnKzyJ+Y7QVx0iGF6hW1xl+4QlyeYT
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7020
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

> -----Original Message-----
> From: Alexander Stein <alexander.stein@ew.tq-group.com>
> Sent: Thursday, September 8, 2022 1:50 PM
> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Rob Herring
> <robh+dt@kernel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@linaro.org>; Shawn Guo <shawnguo@kernel.org>;
> Sascha Hauer <s.hauer@pengutronix.de>; Pengutronix Kernel Team
> <kernel@pengutronix.de>; Fabio Estevam <festevam@gmail.com>; dl-linux-imx
> <linux-imx@nxp.com>; Jun Li <jun.li@nxp.com>
> Cc: linux-usb@vger.kernel.org; devicetree@vger.kernel.org;
> linux-kernel@vger.kernel.org
> Subject: RE: [PATCH 0/4] USB host support for TQMa8MPxL + MBa8MPxL
>=20
> Hi,
>=20
> Am Mittwoch, 7. September 2022, 18:08:25 CEST schrieb Jun Li:
> > Hi
> >
> > > -----Original Message-----
> > > From: Alexander Stein <alexander.stein@ew.tq-group.com>
> > > Sent: Wednesday, September 7, 2022 10:46 PM
> > > To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Rob Herring
> > > <robh+dt@kernel.org>; Krzysztof Kozlowski
> > > <krzysztof.kozlowski+dt@linaro.org>; Shawn Guo
> > > <shawnguo@kernel.org>; Sascha Hauer <s.hauer@pengutronix.de>;
> > > Pengutronix Kernel Team <kernel@pengutronix.de>; Fabio Estevam
> > > <festevam@gmail.com>; dl-linux-imx <linux-imx@nxp.com>; Jun Li
> > > <jun.li@nxp.com>
> > > Cc: Alexander Stein <alexander.stein@ew.tq-group.com>;
> > > linux-usb@vger.kernel.org; devicetree@vger.kernel.org;
> > > linux-kernel@vger.kernel.org
> > > Subject: [PATCH 0/4] USB host support for TQMa8MPxL + MBa8MPxL
> > >
> > > Hi everybody,
> > >
> > > this is a series based on the RFC at [1] for USB host support on
> > > TQMa8MPxL
> > > + MBa8MPxL. The main difference is that USB DR support has already
> > > + been
> > > added and has been removed from this series.
> > >
> > > The DT configuration itself (patch 4) is rather straight forward,
> > > but leads
> > >
> > > to the following dmesg errors regarding superspeed ports:
> > > > [    8.549243] hub 2-1:1.0: hub_ext_port_status failed (err =3D -11=
0)
> > > > [   22.885263] usb 2-1: Failed to suspend device, error -110
> > >
> > > This hardware works fine using the downstream kernel, because for
> > > imx8mp this ITP sync feature is enabled conditionally [2] & [3].
> > > Hacking this into mainline resulted in a working superspeed setup as
> well.
> > > I also noticed that on some android kernel [4] depending in IP core
> > > version either GCTL.SOFTITPSYNC or GFLADJ.GFLADJ_REFCLK_LPM_SEL is
> > > enabled unconditionally.
> > > So I opted for the latter one using some quirk (patch 1-3).
> > >
> > > I have to admit I do not know what this is actually about, nor why
> > > my setup does not work without this change or why this fixed my
> > > problem. So maybe someone with more knowledge can say if this is the
> > > way to go or what this is about.
> >
> > This can be updated:)
> >
> > > I also added snps,dis_u3_susphy_quirk to the board level as for some
> > > reason USB Superspeed U3 does not work. Detecting the onboard hub
> > > takes much longer and once all devices are diconnected from the hub
> > > it is put into runtime suspend (U3) and new attached devices are not
> > > detected at all.
> > > Until the cause is known and fixed runtime suspend has to be disabled=
.
> >
> > For this issue you are reporting, I am not sure if this is caused by a
> > USB clock change merged on v5.19, if you use latest kernel, can you
> > try with below patches applied to see if U3 can work for you?
>=20
> Awesome, This does the trick!
> I was already running with patches [1] & [2], but was missing patch [3].
> With all of them applied, USB detects a newly attached superspeed device
> when the HUB is in runtime suspend (U3).

Yes, patch[3] needs to apply with patches [1]&[2], I am applying the
same tag to make sure the 3 patches land on the same target release
as they will go through diff maintainer's trees.

>=20
> I forgot: thanks for checking with synopsis regarding soft ITP sync featu=
re.
>=20

Welcome.

Li Jun