Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 8 Sep 2022 12:31:48 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Matti Vaittinen <mazziesaccount@gmail.com>
Cc:     Sebastian Reichel <sebastian.reichel@collabora.com>,
        Heiko Stuebner <heiko@sntech.de>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Lee Jones <lee@kernel.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Alessandro Zummo <a.zummo@towertech.it>,
        linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel@collabora.com,
        shengfei Xu <xsf@rock-chips.com>
Subject: Re: [PATCHv2 12/13] regulator: rk808: add rk806 support
Message-ID: <YxnSpE7/oNti9KKK@sirena.org.uk>
References: <20220908003107.220143-1-sebastian.reichel@collabora.com>
 <20220908003107.220143-13-sebastian.reichel@collabora.com>
 <88f6110b-94b7-484d-cc37-d7f72c88090a@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="zfjnbY86D6IxZX3o"
Content-Disposition: inline
In-Reply-To: <88f6110b-94b7-484d-cc37-d7f72c88090a@gmail.com>
Precedence: bulk


--zfjnbY86D6IxZX3o
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Sep 08, 2022 at 10:45:40AM +0300, Matti Vaittinen wrote:
> On 9/8/22 03:31, Sebastian Reichel wrote:

> > +static int rk806_set_voltage(struct regulator_dev *rdev,
> > +			     int req_min_uV, int req_max_uV,
> > +			     unsigned int *selector)

> Hmm. Maybe this is not necessary? I wonder if we could get away just with
> the .map and .set_voltage_sel (regulator_get_voltage_sel_regmap() and
> regulator_map_voltage_linear_range()).

Not just can, should.  Drivers should not mix and match voltage based
and selector based operations, and they should always try to implement
selector based operations unless there's a specific reason to do
otherwise.

--zfjnbY86D6IxZX3o
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmMZ0qMACgkQJNaLcl1U
h9A3iAf/RV6xulcLF3Uiq6Nup7Itd0N4Nsi3t+C2+D49b18Gq28gAKZucesUpjfz
gVO5YeJnNX6gJnia1jDhxTAVa8r+Xy1K+6WmQGpYbfCECmTmS1v9GB3uIfOPyp5m
iWrne12WJjo1b0a52D6/EyFT2okKjmR6qNYf37LVcomneLWl/KnXnPQmcK6vhbkY
gwBklAF5YL822NCgx65aO4cgqkfIm/w7KK+y6h5DTzmXw5h+Ldi11+tMS65g5Oax
77RzRDaU91PhGv9DSN94iBnvEmXGigofOJQ9vz/HRYOTmBUNPsu5dVxXdgeVhWqY
4b6pMpBw61OJXeC3ETKEaS/j2jQfeA==
=GRVt
-----END PGP SIGNATURE-----

--zfjnbY86D6IxZX3o--