Date: Mon, 18 Jun 2007 09:17:57 +0200
From: Jean Delvare <khali@linux-fr.org>
To: Soeren Sonnenburg <kernel@nn7.de>,
       Andrew Morton <akpm@linux-foundation.org>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
       Rudolf Marek <r.marek@assembler.cz>
Subject: Re: [PATCH] hwmon/coretemp: Fix a broken error path
Message-ID: <20070618091757.6d631d4f@hyperion.delvare>
In-Reply-To: <1182071803.4815.5.camel@localhost>
References: <1182026585.4230.8.camel@localhost>
	<20070616231745.1b0f7bd9@hyperion.delvare>
	<1182071803.4815.5.camel@localhost>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1732
Lines: 47

Hi Soeren,

On Sun, 17 Jun 2007 11:16:43 +0200, Soeren Sonnenburg wrote:
> On Sat, 2007-06-16 at 23:17 +0200, Jean Delvare wrote:
> > Thanks for reporting. Indeed this patch is broken, sorry for
> > overlooking it. I tested it but my hardware is such that the faulty
> > error path was never taken. Please test the following patch (on top of
> > git-current) and confirm it fixes your problem:
> > 
> > Signed-off-by: Jean Delvare <khali@linux-fr.org>
> > Cc: Rudolf Marek <r.marek@assembler.cz>
> > ---
> >  drivers/hwmon/coretemp.c |    1 +
> >  1 file changed, 1 insertion(+)
> > 
> > --- linux-2.6.22-rc4.orig/drivers/hwmon/coretemp.c	2007-06-05 10:25:54.000000000 +0200
> > +++ linux-2.6.22-rc4/drivers/hwmon/coretemp.c	2007-06-16 23:14:06.000000000 +0200
> > @@ -185,6 +185,7 @@ static int __devinit coretemp_probe(stru
> >  		/* check for microcode update */
> >  		rdmsr_on_cpu(data->id, MSR_IA32_UCODE_REV, &eax, &edx);
> >  		if (edx < 0x39) {
> > +			err = -ENODEV;
> >  			dev_err(&pdev->dev,
> >  				"Errata AE18 not fixed, update BIOS or "
> >  				"microcode of the CPU!\n");
> 
> this patch indeed fixes the problem. Thanks!

OK, great. Andrew, can you please pick this patch:
http://lkml.org/lkml/2007/6/16/177
and push it to Linus in your next batch?

> Soeren
> -- 
> Sometimes, there's a moment as you're waking, when you become aware of
> the real world around you, but you're still dreaming.

I too listen to Astral Projection at times :)

Thanks,
-- 
Jean Delvare
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/