Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp536986rwn; Thu, 8 Sep 2022 05:34:20 -0700 (PDT) X-Google-Smtp-Source: AA6agR706S1vFMcCOkc8w8XlBnRe16gAvgYwj+fWRhfursO7AR7SmPNVlOXB2Npj8u7l1QGjOboK X-Received: by 2002:a17:907:2c6a:b0:76f:ce8b:b8c4 with SMTP id ib10-20020a1709072c6a00b0076fce8bb8c4mr5888178ejc.553.1662640460313; Thu, 08 Sep 2022 05:34:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662640460; cv=none; d=google.com; s=arc-20160816; b=qIknd9gDiAXaP3U/JDyP4gFT4tX5BpAVIqOar/39rJa+f83wDpJjq0G23gu29sq/nL /TUMAQGyrJUgRoZe7aOcDkfSpfk79DqoPhlPYbhk4hD4aQDWqe8scxK18tp5JVgHtV4W TeZqOZuYYoVrBbTbVXn+K9lsweofhH6qdbX2m9dlN0/H7Mz8gQb3FSc2FfDaECIHNjpJ GXX9Ovx1o2EGHJysEE4xMoMB8zmPBDRmBw4WLiKuM2je6VOcYkYY5gFt/vLYtWD7CvSI mvMa2XLFQtzQfxHVc4dJoFZk7F1Oh9sQBHLchZKFvRn11rMYtTvmuPpZMQZS40dpyftE kvvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:feedback-id :dkim-signature:dkim-signature; bh=KrUSQEGonbAlAjJjGy+o4W945brRN+Avg2umBhBnQI0=; b=v+5STyUnVBfS3LUopv1JybQJV+26JjHVE+ctYD2g+Lf4qvZ9M0GxB++BS3ImA+nls+ uWVqtauDNYqWYl9wl8no3SmakRijDpcCn78/rxfKgu2CbK04vlltBFNZKK0/WDUNcQhY TMQZdRetk5YSCTbbGD7Zuu3+K738qxCU0PShZixMsScI1Oy4Qf30t3A8YZoxrP8MYZzX Bpy8DVQ+jiBOy4b3ui4UOtuBu+Dcz7UyaqNhY0g+I3qlbhhKSU9qbqdiwst1fQEsCH5o qpbs6uu91Yi6hT30l4EOgm3l7Ma5f/eUgPP5HjoW6RBENvSwFbbzh6N9VEX5Eo7+C1SS 628Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cerno.tech header.s=fm2 header.b=FDJ+i06u; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=qSbjZbSS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cerno.tech Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n4-20020a170906700400b0073d8ec9485esi1772658ejj.714.2022.09.08.05.33.54; Thu, 08 Sep 2022 05:34:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@cerno.tech header.s=fm2 header.b=FDJ+i06u; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=qSbjZbSS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cerno.tech Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230407AbiIHMQl (ORCPT + 99 others); Thu, 8 Sep 2022 08:16:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229574AbiIHMQj (ORCPT ); Thu, 8 Sep 2022 08:16:39 -0400 Received: from wnew3-smtp.messagingengine.com (wnew3-smtp.messagingengine.com [64.147.123.17]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE56AA4B2A for ; Thu, 8 Sep 2022 05:16:32 -0700 (PDT) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailnew.west.internal (Postfix) with ESMTP id EA3332B05A0A; Thu, 8 Sep 2022 08:16:26 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 08 Sep 2022 08:16:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1662639386; x=1662646586; bh=KrUSQEGonb AlAjJjGy+o4W945brRN+Avg2umBhBnQI0=; b=FDJ+i06umqUPBluRJ7zeRUbZGi N7jURhZXBmo5/S/Usa0N7J90mrtZzUzd9Nnaqc/FSn/y2WncCNW0R/moHpGLsUYL C5HWH/06WmYBIrzd3wE8FfKvD0KP4va0BIHvH8EF3nQZlPPz05ZBTb7yXqScAKuO 2cUl3GXynvvp+pozPGU+71VCeJvYCtvKDI5tFdQJ+tdXHAMzBJCwHKqsE0lKu/Pr A8ao6EFdwHVEEFLchW5crqmZTnlYgKcXUd/7CLSB+FPVSiwYJTLsjONLCGGyUb5y BFn+4WlR1jtVnr0gwwa1yiUURtwxTD5yuFucnCU7kZFiAss3Xjxn5XHd3GhA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1662639386; x=1662646586; bh=KrUSQEGonbAlAjJjGy+o4W945brR N+Avg2umBhBnQI0=; b=qSbjZbSSlScqRRb2KD+nkNMWqkO7dm28pU786LY/qda/ 20Ta+Fxd1Nfb9NVVgPzUZ5oXSwIVH75WHvntED+kLxclil5DY0Pe1OLJHK/OlyA0 gpWzwt0FgxfMKod2+RxptaSG392n33NPqK/rCJPfYeu9E9KTI49qaIpha15PJwFe n2fe8C/IedfcplqCjGsd87uRarm6rQxfP3WAZPBWsXbWbMkI3xxUOfRjmg/XKIdV wfYk/382pZzKgJ+qRyqYgkzd+uFzaBZ1CidqctyDK7PR+nulsm3G8tT4B47TdQdK yfTTbwtCbOcgqMJqt0PLyEhVSx/hdOjbLulLGn2KOQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedtvddgheduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtudenucfhrhhomhepofgrgihi mhgvucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrg htthgvrhhnpeetudffhfdtieeuleeivdevgeefvdfggfejuefhtdekueetfeduhfejfeej veegueenucffohhmrghinhepmhhouggvrdhimhdpghhithhhuhgsrdgtohhmnecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegt vghrnhhordhtvggthh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 8 Sep 2022 08:16:25 -0400 (EDT) Date: Thu, 8 Sep 2022 14:16:23 +0200 From: Maxime Ripard To: Mateusz Kwiatkowski Cc: Noralf =?utf-8?Q?Tr=C3=B8nnes?= , Ben Skeggs , David Airlie , Chen-Yu Tsai , Thomas Zimmermann , Jani Nikula , Lyude Paul , Philipp Zabel , Maarten Lankhorst , Rodrigo Vivi , Tvrtko Ursulin , Jernej Skrabec , Samuel Holland , Karol Herbst , Emma Anholt , Daniel Vetter , Joonas Lahtinen , Hans de Goede , linux-arm-kernel@lists.infradead.org, Phil Elwell , intel-gfx@lists.freedesktop.org, Dave Stevenson , dri-devel@lists.freedesktop.org, Dom Cobley , linux-kernel@vger.kernel.org, nouveau@lists.freedesktop.org, linux-sunxi@lists.linux.dev, Mateusz Kwiatkowski , Geert Uytterhoeven Subject: Re: [PATCH v2 32/41] drm/vc4: vec: Convert to the new TV mode property Message-ID: <20220908121623.m6n2zyk3aratb6ag@houat> References: <20220728-rpi-analog-tv-properties-v2-0-459522d653a7@cerno.tech> <20220728-rpi-analog-tv-properties-v2-32-459522d653a7@cerno.tech> <199cf4b3-8ace-e047-3050-b810cf0c6b63@tronnes.org> <20220908112312.hlb7mzneuxnethhr@houat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="tdggbbxhdgn6r5uy" Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,T_SCC_BODY_TEXT_LINE, T_SPF_TEMPERROR autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --tdggbbxhdgn6r5uy Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 08, 2022 at 01:31:34PM +0200, Mateusz Kwiatkowski wrote: > W dniu 08.09.2022 o 13:23, Maxime Ripard pisze: > > Hi Noralf, > > > > On Tue, Aug 30, 2022 at 09:01:08PM +0200, Noralf Tr=F8nnes wrote: > >>> +static const struct drm_prop_enum_list tv_mode_names[] =3D { > >> > >> Maybe call it legacy_tv_mode_enums? > >> > >>> > >>> +=A0=A0 =A0{ VC4_VEC_TV_MODE_NTSC, "NTSC", }, > >>> > >>> +=A0=A0 =A0{ VC4_VEC_TV_MODE_NTSC_J, "NTSC-J", }, > >>> > >>> +=A0=A0 =A0{ VC4_VEC_TV_MODE_PAL, "PAL", }, > >>> > >>> +=A0=A0 =A0{ VC4_VEC_TV_MODE_PAL_M, "PAL-M", }, > >> > >> If you use DRM_MODE_TV_MODE_* here you don't need to translate the val= ue > >> using the switch statement in get/set property, you can use the value > >> directly to get/set tv.mode. > > > > I'm sorry, I'm not quite sure what you mean by that. If we expose the > > DRM_MODE_TV_MODE_* properties there, won't that change the values the > > userspace will need to use to set that property? >=20 > I'd just like to point out that if numerical values of these enums are yo= ur > concern, then you're (or perhaps I am ;) already breaking this by adding = new > modes in patch 33/41 in this series. >=20 > And the values (and names!) added by that patch (33/41) don't match those > currently used by the downstream version > (https://github.com/raspberrypi/linux/blob/rpi-5.15.y/drivers/gpu/drm/vc4= /vc4_vec.c). > If any userspace software is manipulating this property, it's most likely > targeting the downstream code. But since you're not aiming for consistenc= y with > that, I was under the impression that compatibility isn't a concern. I'm not really concerned about the compatibility with the downstream tree, if only because you already broke that compatibility with your patch :) So you're right, I'll reorganize that patch to keep the backward compatibility. Maxime --tdggbbxhdgn6r5uy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYxndFwAKCRDj7w1vZxhR xZzpAQDu6178QjxcwYvkevzAeo7PrIc0OnYrnwJMv32MTXR4eQEAk5vzF3oEW4ES B3YR/wi67B2CLlhZDDEHOYE/bL80EQ8= =fmem -----END PGP SIGNATURE----- --tdggbbxhdgn6r5uy--