Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ffb7f9e5-676d-e382-11bd-8bd87c40ee0c@redhat.com>
Date:   Thu, 8 Sep 2022 14:23:30 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.0
Subject: Re: [PATCH v4 2/4] memblock tests: add top-down NUMA tests for
 memblock_alloc_try_nid*
Content-Language: en-US
To:     Rebecca Mckeever <remckee0@gmail.com>,
        Mike Rapoport <rppt@kernel.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
References: <cover.1662264560.git.remckee0@gmail.com>
 <03b434f9ccbeb059a04d5af57d69038a14c21ec6.1662264560.git.remckee0@gmail.com>
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat
In-Reply-To: <03b434f9ccbeb059a04d5af57d69038a14c21ec6.1662264560.git.remckee0@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 04.09.22 06:21, Rebecca Mckeever wrote:
> Add tests for memblock_alloc_try_nid() and memblock_alloc_try_nid_raw()
> where the simulated physical memory is set up with multiple NUMA nodes.
> Additionally, all of these tests set nid != NUMA_NO_NODE. These tests are
> run with a top-down allocation direction.
> 
> The tested scenarios are:
> 
> Range unrestricted:
> - region can be allocated in the specific node requested:
>        + there are no previously reserved regions
>        + the requested node is partially reserved but has enough space
> - the specific node requested cannot accommodate the request, but the
>    region can be allocated in a different node:
>        + there are no previously reserved regions, but node is too small
>        + the requested node is fully reserved
>        + the requested node is partially reserved and does not have
>          enough space
> 
> Range restricted:
> - region can be allocated in the specific node requested after dropping
>    min_addr:
>        + range partially overlaps with two different nodes, where the first
>          node is the requested node
>        + range partially overlaps with two different nodes, where the
>          requested node ends before min_addr
> - region cannot be allocated in the specific node requested, but it can be
>    allocated in the requested range:
>        + range overlaps with multiple nodes along node boundaries, and the
>          requested node ends before min_addr
>        + range overlaps with multiple nodes along node boundaries, and the
>          requested node starts after max_addr
> - region cannot be allocated in the specific node requested, but it can be
>    allocated after dropping min_addr:
>        + range partially overlaps with two different nodes, where the
>          second node is the requested node
> 
> Signed-off-by: Rebecca Mckeever <remckee0@gmail.com>
> ---
>   tools/testing/memblock/tests/alloc_nid_api.c | 694 ++++++++++++++++++-
>   tools/testing/memblock/tests/alloc_nid_api.h |  16 +
>   tools/testing/memblock/tests/common.h        |  18 +
>   3 files changed, 717 insertions(+), 11 deletions(-)
> 
> diff --git a/tools/testing/memblock/tests/alloc_nid_api.c b/tools/testing/memblock/tests/alloc_nid_api.c
> index 32b3c1594fdd..a639e9d3e098 100644
> --- a/tools/testing/memblock/tests/alloc_nid_api.c
> +++ b/tools/testing/memblock/tests/alloc_nid_api.c
> @@ -3,6 +3,14 @@
>   
>   static int alloc_nid_test_flags = TEST_F_NONE;
>   
> +/*
> + * contains the denominators of the fractions of MEM_SIZE contained in each node
> + * (e.g., if node_fractions[0] = SZ_8, node 0 will contain 1/8th of MEM_SIZE)
> + */
> +static const phys_addr_t node_fractions[] = {
> +	SZ_4, SZ_16, SZ_8, SZ_8, SZ_16, SZ_16, SZ_4, SZ_16
> +};
> +

Besides that part, that I consider confusing :)

Acked-by: David Hildenbrand <david@redhat.com>

-- 
Thanks,

David / dhildenb