Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp560852rwn; Thu, 8 Sep 2022 05:56:43 -0700 (PDT) X-Google-Smtp-Source: AA6agR7w+F5H/e5su8s3UIGENzpH64oipEY+NbI0eB6CDfJYMzx+Sy0OqQ49iFoBTvYSXUOWDmaQ X-Received: by 2002:a17:90b:4d8e:b0:200:73b4:4da2 with SMTP id oj14-20020a17090b4d8e00b0020073b44da2mr4221384pjb.197.1662641803053; Thu, 08 Sep 2022 05:56:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662641803; cv=none; d=google.com; s=arc-20160816; b=Rqgyh+KIclc0cnkQhdRS3mjKjnNcn8PUR1A/ap4V9/kKY/Fvq5fJ2dHXzWdyK7DV9z 4nCsakd+tWveLqG6wnnRInb3KhN698pp0hkQdTtu4gkXcbUSlhlV7mogZWaoKhkhQe1N nM6SwCenOYLPOrkW04ls7lMGGmLKNBbeTeqz+Z8NMNEFwfVuKlJlVmfpZ+g/Kij2wuLZ x9nvBRgJtECMshyTG/lZ4LZ4Y6/GOKM7ZimcC7tDdmOHrViC7KdU6I3iepsJTQqM9i/E nj309kXujmp65g8M6aedwwxOXOkXhZL0TJpCFLsUZwMNRi8MhGhIzhmwcohAT2kYzbsE VSPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=NvItkbNfICcu7g1yVv4WgDTot4PnGzFSFa7/RC5e9pw=; b=GDvvZr+wUNBpOvrjempSdC+uLLPhMH5DBNDGdVMvjP/cpkTqDkraz66vfcLfF8RUng hAz02pXsrBLUVf1Rj5Q5ZWltDAWSYmsmKTmLx40/BFJ62GwP+Rze6/kup8OyOa1/Yio5 uL8Yww/QhzZbjHM+5lgrwOU+0i51+BlUYZUukSGNf2lEL4Ddoz1vitsbcIxmPVmeKXwj S9bqB1Hjlmf2z3QxZqmsWWQC78QbvJhkWU9YwrlYmNCCIz0lt2hB6s8irfRShsZPBlhO qJuQ66FJ2YKqzGk93QY/d7Oenq45RKFAvLcWAFqNBwFluw6Xn/LVrIbbPvbTIn3BYbBU I7pg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BqBdZOd1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d13-20020a170902e14d00b00176d89d640asi6419171pla.440.2022.09.08.05.56.27; Thu, 08 Sep 2022 05:56:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BqBdZOd1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231540AbiIHMZs (ORCPT + 99 others); Thu, 8 Sep 2022 08:25:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231730AbiIHMZp (ORCPT ); Thu, 8 Sep 2022 08:25:45 -0400 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C215C6505 for ; Thu, 8 Sep 2022 05:25:44 -0700 (PDT) Received: by mail-ed1-x52d.google.com with SMTP id e18so24079800edj.3 for ; Thu, 08 Sep 2022 05:25:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=NvItkbNfICcu7g1yVv4WgDTot4PnGzFSFa7/RC5e9pw=; b=BqBdZOd1Iq5VKB5wOE7GYtx+R/htdT8tJs61gZ48R6LiLkBHqS3GYp7/3R5IN9JPxQ TExYh3bomSJkoM1qQY6rq4cA2DBNBpxc3IiOtxopwgeLzUs+EYAoaMb7JVXEp4UIwNRv 8UcF/vC/Kn2YbOCQwwjmNA8H4vTnJKbhauT6CgmM+rU9fI/bS45HgWMQUDXfK+HavJhC ZeRrl+P8mmZWh4sIPWn6v2setqsvxrMY2diGh2KH7GCsG5kEWhHu/EnwOLcQWK6B7p33 Dh6Od0GzXHg1FnmH5JZ49R8X7d9JkGULvWWxafb2FZb6GYaFWFekRwd7gY5uHcmBv/qS 9teg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=NvItkbNfICcu7g1yVv4WgDTot4PnGzFSFa7/RC5e9pw=; b=itjSXEcO2DqHJRo6l/Wjsn0n1XX0DR5lwqLvwZ32wEzKUYFIDZnj2/BzOiaZ8pQhEe ITGpatz86sPF7KsOCThqK4MkeD9K3sskzGZmS/oqdSveulGGHhgqo0yRTujhbrcVYZgr 4cLC2DJVhWCUsVS0RkyjhUhnZSGfo2u/wc1rWKyp4UyvuuyOrD476HYv0HtHEtRbFCyV DJqMsEZaHxUztIAkvTcBTnCeLX1/CV/WJCZ+9YRfkLiTfGUeAnvR7gwV/EguvYheiVXM 20FxkiEWZuuV+8Ve68YfKlFaI9e/s5Z+G6Trs/aTDn4PgAre2KyxpptQS1Q3vo0tXgH3 /yZg== X-Gm-Message-State: ACgBeo29ZVUemqoq3dgtOdwpjSSw90f0VeXx1Ax+r9yVpElVRXYep3EH nM7ZnkyZmME+vdfFv1TGaOsdTjcYsPYGMOdOtcHc4w== X-Received: by 2002:aa7:c84f:0:b0:446:2bfb:5a63 with SMTP id g15-20020aa7c84f000000b004462bfb5a63mr6979030edt.172.1662639942930; Thu, 08 Sep 2022 05:25:42 -0700 (PDT) MIME-Version: 1.0 References: <20220830092232.168561-1-manivannan.sadhasivam@linaro.org> In-Reply-To: From: Linus Walleij Date: Thu, 8 Sep 2022 14:25:31 +0200 Message-ID: Subject: Re: [PATCH v3] pinctrl: qcom: spmi-gpio: Make irqchip immutable To: Johan Hovold Cc: Manivannan Sadhasivam , bjorn.andersson@linaro.org, robimarko@gmail.com, linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, maz@kernel.org, johan+linaro@kernel.org, steev@kali.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 30, 2022 at 2:08 PM Johan Hovold wrote: > > + irq_chip_unmask_parent(data); > > + gpiochip_enable_irq(gc, data->hwirq); > > Could you set the IRQ-enabled flag before unmasking the parent here for > symmetry (and as most other implementations do)? I fixed this up while applying so no need to resend. Patch applied! Yours, Linus Walleij