Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 8 Sep 2022 20:44:11 +0800
From:   Leo Yan <leo.yan@linaro.org>
To:     carsten.haitzler@foss.arm.com
Cc:     linux-kernel@vger.kernel.org, coresight@lists.linaro.org,
        suzuki.poulose@arm.com, mathieu.poirier@linaro.org,
        mike.leach@linaro.org, linux-perf-users@vger.kernel.org,
        acme@kernel.org
Subject: Re: [PATCH v8 02/13] perf test: Add build infra for perf test tools
 for CoreSight tests
Message-ID: <Yxnjm7sA2Uit0X1M@leoy-huanghe.lan>
References: <20220906103044.761250-1-carsten.haitzler@foss.arm.com>
 <20220906103044.761250-3-carsten.haitzler@foss.arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220906103044.761250-3-carsten.haitzler@foss.arm.com>
Precedence: bulk

Hi Carsten,

On Tue, Sep 06, 2022 at 11:30:33AM +0100, carsten.haitzler@foss.arm.com wrote:

[...]

> --- /dev/null
> +++ b/tools/perf/tests/shell/coresight/Makefile
> @@ -0,0 +1,26 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +# Carsten Haitzler <carsten.haitzler@arm.com>, 2021
> +include ../../../../../tools/scripts/Makefile.include
> +include ../../../../../tools/scripts/Makefile.arch
> +include ../../../../../tools/scripts/utilities.mak
> +
> +SUBDIRS =
> +
> +all: $(SUBDIRS)
> +$(SUBDIRS):
> +	$(Q)$(MAKE) -C $@
> +
> +INSTALLDIRS = $(SUBDIRS:%=install-%)
> +
> +install-tests: $(INSTALLDIRS)
> +$(INSTALLDIRS):
> +	$(Q)$(MAKE) -C $(@:install-%=%) install-tests
> +
> +CLEANDIRS = $(SUBDIRS:%=clean-%)
> +
> +clean: $(CLEANDIRS)
> +$(CLEANDIRS):
> +	$(Q)$(MAKE) -C $(@:clean-%=%) clean >/dev/null
> +
> +.PHONY: all clean $(SUBDIRS) $(CLEANDIRS) $(INSTALLDIRS)
> +

I observed that git reports warning when applied this patch:

Applying: perf test: Add build infra for perf test tools for CoreSight tests
.git/rebase-apply/patch:107: new blank line at EOF.
+

The last blank line is redundant, it's good to drop it.  When you fix the
warning for rst doc file, you could fix this together.

P.s. at my side, git can automatically fix the redundant blink line
since I added "whitespace = fix" in my gitconfig.

Thanks,
Leo