Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760872AbXFRHgl (ORCPT ); Mon, 18 Jun 2007 03:36:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759983AbXFRHg0 (ORCPT ); Mon, 18 Jun 2007 03:36:26 -0400 Received: from mtagate8.uk.ibm.com ([195.212.29.141]:46932 "EHLO mtagate8.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759477AbXFRHgY (ORCPT ); Mon, 18 Jun 2007 03:36:24 -0400 Date: Mon, 18 Jun 2007 09:36:05 +0200 From: Heiko Carstens To: Mike Frysinger Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, Martin Schwidefsky Subject: Re: [patch] use __asm__ rather than asm in asm-s390/ptrace.h Message-ID: <20070618073605.GA3580@osiris.boeblingen.de.ibm.com> References: <200706180223.07122.vapier@gentoo.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200706180223.07122.vapier@gentoo.org> User-Agent: mutt-ng/devel-r804 (Linux) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1141 Lines: 29 On Mon, Jun 18, 2007 at 02:23:06AM -0400, Mike Frysinger wrote: > Since asm-s390/ptrace.h is exported to userspace, we need to make sure we use > __asm__() rather than asm() as the latter is disabled when gcc compiles with > GNU extensions turned off (like -std=c99). > > Signed-off-by: Mike Frysinger > --- > diff --git a/include/asm-s390/ptrace.h b/include/asm-s390/ptrace.h > index fa6ca87..4add355 100644 > --- a/include/asm-s390/ptrace.h > +++ b/include/asm-s390/ptrace.h > @@ -475,7 +475,7 @@ extern void show_regs(struct pt_regs * regs); > static inline void > psw_set_key(unsigned int key) > { > - asm volatile("spka 0(%0)" : : "d" (key)); > + __asm__ __volatile__("spka 0(%0)" : : "d" (key)); > } > > #endif /* __ASSEMBLY__ */ Hmm.. spka is a sort of priviledged instruction and shouldn't be user space visible. I will move it so it's under #ifdef __KERNEL__. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/