Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759805AbXFRHsG (ORCPT ); Mon, 18 Jun 2007 03:48:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751703AbXFRHrz (ORCPT ); Mon, 18 Jun 2007 03:47:55 -0400 Received: from pasmtpa.tele.dk ([80.160.77.114]:38138 "EHLO pasmtpA.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751877AbXFRHrz (ORCPT ); Mon, 18 Jun 2007 03:47:55 -0400 Date: Mon, 18 Jun 2007 09:48:58 +0200 From: Sam Ravnborg To: Satyam Sharma Cc: Yasunori Goto , Paul Mundt , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: More __meminit annotations. Message-ID: <20070618074858.GB21222@uranus.ravnborg.org> References: <20070618143943.B108.Y-GOTO@jp.fujitsu.com> <20070618055842.GA17858@linux-sh.org> <20070618151544.B10A.Y-GOTO@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 847 Lines: 20 On Mon, Jun 18, 2007 at 12:58:34PM +0530, Satyam Sharma wrote: > > Actually, modpost will _not_ complain precisely _because_ kernel > uses always_inline so a separate body for the function will never be > emitted at all. That has been threaten to change many times. Far far far too much are marked inline today. There has been several longer threads about it. Part of it is that some part MUST be inlined to work while other parts may be inline but not needed (and often the wrong thing). So a carefully added inline is good but the other 98% of inline markings are just wrong and ougth to go. Sam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/