Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 8 Sep 2022 15:17:01 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     Mel Gorman <mgorman@suse.de>
Cc:     Abel Wu <wuyun.abel@bytedance.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Rohit Jain <rohit.k.jain@oracle.com>,
        Ingo Molnar <mingo@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched/fair: Fix misuse of available_idle_cpu()
Message-ID: <YxnrTdwA493gIHS8@hirez.programming.kicks-ass.net>
References: <20220908080702.58938-1-wuyun.abel@bytedance.com>
 <20220908103632.yzm5boxrr3nmvhpm@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220908103632.yzm5boxrr3nmvhpm@suse.de>
Precedence: bulk

On Thu, Sep 08, 2022 at 11:36:32AM +0100, Mel Gorman wrote:
> On Thu, Sep 08, 2022 at 04:07:02PM +0800, Abel Wu wrote:
> > The function available_idle_cpu() was introduced to distinguish
> > between the code paths that cares if the vCPU is preempted and
> > the ones don't care. In general, available_idle_cpu() is used in
> > selecting cpus for immediate use, e.g. ttwu. While idle_cpu() is
> > used in the paths that only cares about the cpu is idle or not,
> > and __update_idle_core() is one of them.
> > 
> > Use idle_cpu() instead in the idle path to make has_idle_core
> > a better hint.
> > 
> > Fixes: 943d355d7fee (sched/core: Distinguish between idle_cpu() calls based on desired effect, introduce available_idle_cpu())
> > Signed-off-by: Abel Wu <wuyun.abel@bytedance.com>
> 
> Seems fair. As vCPU preemption is specific to virtualisation, it is very
> unlikely that SMT is exposed to the guest so the impact of the patch is

Right; only pinned guests typically expose such topology information
(anything else would be quite broken).

> minimal but I still think it's right so;

I'm not convinced; all of select_idle_sibling() seems to use
available_idle_cpu(), and that's the only consumer of
__update_idle_core(), so in that respect the current state makes sense.