Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <042f9e06-edae-87e9-413e-4ae4db6ab452@amd.com>
Date:   Thu, 8 Sep 2022 08:40:59 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Reply-To: babu.moger@amd.com
Subject: Re: [PATCH v4 13/13] Documentation/x86: Update resctrl_ui.rst for new
 features
Content-Language: en-US
To:     Bagas Sanjaya <bagasdotme@gmail.com>
Cc:     corbet@lwn.net, reinette.chatre@intel.com, tglx@linutronix.de,
        mingo@redhat.com, bp@alien8.de, fenghua.yu@intel.com,
        dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
        paulmck@kernel.org, akpm@linux-foundation.org,
        quic_neeraju@quicinc.com, rdunlap@infradead.org,
        damien.lemoal@opensource.wdc.com, songmuchun@bytedance.com,
        peterz@infradead.org, jpoimboe@kernel.org, pbonzini@redhat.com,
        chang.seok.bae@intel.com, pawan.kumar.gupta@linux.intel.com,
        jmattson@google.com, daniel.sneddon@linux.intel.com,
        sandipan.das@amd.com, tony.luck@intel.com, james.morse@arm.com,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        eranian@google.com
References: <166257348081.1043018.11227924488792315932.stgit@bmoger-ubuntu>
 <166257368995.1043018.8665350782054895088.stgit@bmoger-ubuntu>
 <Yxlqn0C8rDsLUHNv@debian.me> <Yxm1UJzpjW+AjXzQ@debian.me>
From:   "Moger, Babu" <babu.moger@amd.com>
In-Reply-To: <Yxm1UJzpjW+AjXzQ@debian.me>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MHJ3NTlaeUF1YnNWM1lpUVBqU3BrMzlBMHF5YzljYWsySWxXSzhiMnZPR3Br?=
 =?utf-8?B?czBDMUFmSkh2ZXpJbE0zeXVNM3huRFlWSjlMWllTZzdUWmZ3TWFxS3NVcWFy?=
 =?utf-8?B?OG1FWEwya0xnbU1uUlpEZlFLMk1nZEhUUFJUQmd6TXlESnhDT1YzU3FVZ0w1?=
 =?utf-8?B?WUQvaEJES2FGeXo5Q1Y1ckROdGhYTGJwemMxTDZ2TGplSHIwSEl1aGNBTGJX?=
 =?utf-8?B?Ymk2Qm5hZko1dU4xbWlwemE2SWUrZGtMZjVoZ2NSd1RacG1EdS9YbjVrUzFl?=
 =?utf-8?B?QmtOMDNkdmU1RUNCaEpRMk9mMS9JclR2bnMwYlQ0Vnp3RUQ1c2huQzNBWUlY?=
 =?utf-8?B?SWJRK28zV3EvV2FlMlpSV1FSbDE5TzBYZVRtZHhsSVZoVDhYNUR0UmRIaElK?=
 =?utf-8?B?M2hKMnVXYlZnaHUveWFsSFhhYzlhWHBheGV6dTBZRWxtNUU2czdrY2RWRC8w?=
 =?utf-8?B?OEZPd3hiVi9BMlJsSjExeVBqN2FJQzV0R0pmWHM3RjVCNk9YRkdDKzF2c0xH?=
 =?utf-8?B?K0JqcGRhVkZJMzFOSVJDNDg2ZDNlQ01zcGpHVGZQeWRvdnlZMG8vNXBlL0tT?=
 =?utf-8?B?UVI2aWRHRHRxeWdZVkZkbVAyQ3VYODdONTdzeVdkWnVuL1Q1K0oxMFpreEk5?=
 =?utf-8?B?UnpjT0dVdTZrMmdiZFdOY1pXVm9ra2xNWkYrbnY3anBtRzUvQjE5UnFJaFJN?=
 =?utf-8?B?aHNxd2txQlZQa2owZGI0TXAzd0pqZDdtU0lvcVVYRGp6RHdiaW9kc3ViYVM2?=
 =?utf-8?B?NzJueFE2VWJKYUtoRmRKSi85bUxyVW1xSHpMYmxZazdRREtjMjd2ZlhsTUdv?=
 =?utf-8?B?Z1FrcWphOGFlNXZOcVlUd1I1QSs1MW5SWHBLWWsrUWg1QitiSVo1TDdZOXJG?=
 =?utf-8?B?RkcxK3h2QlVLTkdMT2FtZG9xcmc3ckNGODhkSzJ0WGRlOVpieHZZKzV4bEFK?=
 =?utf-8?B?Y0J6cmovVmFBRkdlbkt6RmR0eXUyK3JEODJCZUFjL2tLdUNPZ0hxZFhITjl4?=
 =?utf-8?B?Z0pNNDR1MS9IQ3dXcis3Q0VUK2hRZGJqTCtvRlZrT3dYMnZ2MUVzdVA1MFBZ?=
 =?utf-8?B?U2tkQ2ZOcitwQWc4V0MzbFdYelIzM0ZRaU41NDhENm4vMEVkVXBGREV2eGd6?=
 =?utf-8?B?M2phS1cwaFpBUjdpWklmbXEyWjVHb1YvYjhGQ1B3TmpMVnRSeDBZZGhSRXBW?=
 =?utf-8?B?K21VdzhhTDgvS2VBZDdXWjlJUVc5cFM5TG9SUklZRGdHOEtvalkydFNXOVd5?=
 =?utf-8?B?YlNsd1AvYk0wQ0ovMDc4Mkl0bk9UbEdrcG5pNzlEZGxDc1dCUzlqcElWckFm?=
 =?utf-8?B?U0F3TkEyNnVVSnFLTDZxb0JGRUpVRFU5RjRucVdVWHQ0bGRJZk9SLzVuRDFY?=
 =?utf-8?B?MVdJVnY0bUxCRlVJNWdmeHJDdGJuejF0ZkloN0RRcjN6NWV1SkFBZzkrTUZE?=
 =?utf-8?B?dVhrY1JJSldZLytJSk4wcGQvNC9acXZvY3VtTktSYWJWS0RXOC9RMURTNnds?=
 =?utf-8?B?L2RNakRvRDhqU0hhSzI1SnY5RExZdmNMaDhjRVV0SUhPNENabC85WUJzMExp?=
 =?utf-8?B?MlZuSEVpUUVmd2c3WElLTENoS2NHUEZxdVNYdmU1b0xTSHdrQXZET2pQWCt6?=
 =?utf-8?B?S1FyRk9Uai91VitIVkVuYk9lUlJ2VVEvUEpqZGFrUXl1azdtcnJXcGx1by9t?=
 =?utf-8?B?V0NoeWc5aUkrMTFMZFU3bGFiNjBlNERVT1p3MEJTTDJBbFZMTUtxYVFudmJp?=
 =?utf-8?B?N0crNERkVllBUWRMeVU0MUUzNkR5VmpxVFZvVXVQNnNKK2lZWFZVOStRUVlq?=
 =?utf-8?B?Y3BlM3o0MUJjOEFPNXpZc2xIZml5dXY4MnNVbmkvcUNuV0FnUWx6OWR0M0JG?=
 =?utf-8?B?dkY3Z1FmNzU2ejJ3QjNLUUpZTTNPT1lsSjduS3NYbC9PUkhsM3pJVXc3K0lq?=
 =?utf-8?B?UG1HOVhFdEc4bFJ4WmdsMHlCU3lDOGErZnRqRmMvRW1mejQ3U0FicldYL0lP?=
 =?utf-8?B?TDREY3htNDFINjFwZUIyVVpFeFJaMmNrbUl5cUt3bzVvblhNWUF6RjRma1Zw?=
 =?utf-8?B?ZWliVy9vZkR5VGVBU0pITzZqUUYxaDFKT3R0eUxyNzN2QzRHSXFlMzR3eDNN?=
 =?utf-8?Q?Ycv8=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ee3645eb-d7c3-4c09-0805-08da919fc786
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2022 13:41:06.1811
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nBFceNLGErd7DthNFKO+0bAxiwkfVAyc5vuEvzYGfiWy9l3xSLmLJIC/dTuCI9gx
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5369
X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 9/8/22 04:26, Bagas Sanjaya wrote:
> On Thu, Sep 08, 2022 at 11:07:59AM +0700, Bagas Sanjaya wrote:
>> Use code blocks for terminal output above:
>>
>> ---- >8 ----
>> t a/Documentation/x86/resctrl.rst b/Documentation/x86/resctrl.rst
>> index 56581587c1a331..6474cf655792bf 100644
>> --- a/Documentation/x86/resctrl.rst
>> +++ b/Documentation/x86/resctrl.rst
>> @@ -163,23 +163,23 @@ with the following files:
>>  "mon_features":
>>  		Lists the monitoring events if
>>  		monitoring is enabled for the resource.
>> -                Example output:
>> +                Example::
>>  
>> -                # cat /sys/fs/resctrl/info/L3_MON/mon_features
>> -                llc_occupancy
>> -                mbm_total_bytes
>> -                mbm_local_bytes
>> +                   # cat /sys/fs/resctrl/info/L3_MON/mon_features
>> +                   llc_occupancy
>> +                   mbm_total_bytes
>> +                   mbm_local_bytes
>>  
>>                  If the system supports Bandwidth Monitoring Event
>>                  Configuration (BMEC), then the bandwidth events will
>> -                be configurable. Then the output will be.
>> +                be configurable. The output will be::
>>  
>> -                # cat /sys/fs/resctrl/info/L3_MON/mon_features
>> -                llc_occupancy
>> -                mbm_total_bytes
>> -                mbm_total_config
>> -                mbm_local_bytes
>> -                mbm_local_config
>> +                   # cat /sys/fs/resctrl/info/L3_MON/mon_features
>> +                   llc_occupancy
>> +                   mbm_total_bytes
>> +                   mbm_total_config
>> +                   mbm_local_bytes
>> +                   mbm_local_config
> Hi Babu,
>
> The suggestion diff above looks corrupted, so here is the proper one:

Sanjaya,

Sure, Thank you.

Babu

>
> ---- >8 ----
> diff --git a/Documentation/x86/resctrl.rst b/Documentation/x86/resctrl.rst
> index 56581587c1a331..6474cf655792bf 100644
> --- a/Documentation/x86/resctrl.rst
> +++ b/Documentation/x86/resctrl.rst
> @@ -163,23 +163,23 @@ with the following files:
>  "mon_features":
>  		Lists the monitoring events if
>  		monitoring is enabled for the resource.
> -                Example output:
> +                Example::
>  
> -                # cat /sys/fs/resctrl/info/L3_MON/mon_features
> -                llc_occupancy
> -                mbm_total_bytes
> -                mbm_local_bytes
> +                   # cat /sys/fs/resctrl/info/L3_MON/mon_features
> +                   llc_occupancy
> +                   mbm_total_bytes
> +                   mbm_local_bytes
>  
>                  If the system supports Bandwidth Monitoring Event
>                  Configuration (BMEC), then the bandwidth events will
> -                be configurable. Then the output will be.
> +                be configurable. The output will be::
>  
> -                # cat /sys/fs/resctrl/info/L3_MON/mon_features
> -                llc_occupancy
> -                mbm_total_bytes
> -                mbm_total_config
> -                mbm_local_bytes
> -                mbm_local_config
> +                   # cat /sys/fs/resctrl/info/L3_MON/mon_features
> +                   llc_occupancy
> +                   mbm_total_bytes
> +                   mbm_total_config
> +                   mbm_local_bytes
> +                   mbm_local_config
>  
>  "max_threshold_occupancy":
>  		Read/write file provides the largest value (in
>
> Thanks.
>
-- 
Thanks
Babu Moger