Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9cce17dc-2fba-d339-e88b-b76eb9a382b4@kernel.dk>
Date:   Thu, 8 Sep 2022 08:40:53 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.1
Subject: Re: [PATCH RESEND] sbitmap: Use atomic_{,long}_try_cmpxchg in
 sbitmap.c
Content-Language: en-US
To:     Uros Bizjak <ubizjak@gmail.com>, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220907182144.3245-1-ubizjak@gmail.com>
From:   Jens Axboe <axboe@kernel.dk>
In-Reply-To: <20220907182144.3245-1-ubizjak@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/7/22 12:21 PM, Uros Bizjak wrote:
> Use atomic_long_try_cmpxchg instead of
> atomic_long_cmpxchg (*ptr, old, new) == old in __sbitmap_queue_get_batch
> and atomic_try_cmpxchg instead of atomic_cmpxchg (*ptr, old, new) == old
> in __sbq_wake_up. x86 CMPXCHG instruction returns success in ZF flag, so
> this change saves a compare after cmpxchg (and related move instruction
> in front of cmpxchg).
> 
> Also, atomic_long_cmpxchg implicitly assigns old *ptr value to "old"
> when cmpxchg fails, enabling further code simplifications, e.g.
> an extra memory read can be avoided in the loop.
> 
> No functional change intended.

It doesn't apply to the current tree, can you please resend one against
for-6.1/block?

-- 
Jens Axboe