Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp798961rwn; Thu, 8 Sep 2022 08:57:14 -0700 (PDT) X-Google-Smtp-Source: AA6agR4RWMpBlnoISrQxI3M4VLlvw8geerLIk43WsLsXUBxGK2ZYUjm4uhXQH1eZPpD101vYnXNn X-Received: by 2002:a05:6512:2344:b0:497:a136:c5ea with SMTP id p4-20020a056512234400b00497a136c5eamr2829256lfu.563.1662652633898; Thu, 08 Sep 2022 08:57:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662652633; cv=none; d=google.com; s=arc-20160816; b=mu8bIqxIXehkAfpqJ4++v6gkJb4bImjbuol0bl+9CJ00awdEzujbkadgP+EQdM5f6Q lFCn+ffOraw360axbxOnNWj+C4ZD/vcWSVx+9II5mM14d+BhHG52/wMsvqzeiRhtxAty 99gFztaGd3xMeKqGD5MkRpXc7hCvCh2SmUH9DlohLqRZgMrmOtPO5VI/x5/WzggLSugG 8TiT52hdvoNy87hij2NoVTyN7KVH6LEA9KNysOdhA2ZSXjgpsy/seIwv+6D30a+q0F7A kPGZDuhrwQ8a1ce988/LHdS23Qf/lCeIHOr1KE0aV7Uni0S6nnFuVhqe/HjdotVomr6o kEvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=We7YdNWL+dA6SvrcsgfeWC+uhCMnz0P9xITf03yypx8=; b=exsuU2ZtlKqzvYXMymjWxNHG+A13oWC88eZNwOnjROoUbQFQLI3Rvscnz9OYDoPGj/ lZMrN4FalsWiLZNCLs2L1SxEdL/LktgWoN2KZHv5RBT/gqhoDKFVXbidDzsJ8D+ZrxGE 5u8wPI5AlVgqmaStHoMTe8wI2+ECRzSTYWppFL3OpZHUPMX/G5ylJKZP/0R6/oyX5QuH /yxELIfCNpa/nbUr1jxZg9XC/BEPpOYbYM4beee9OhMRmvu1ns7S850fjWWtJfSsypwv k1apHmm/eaOdQ5l3jxdRlE9xFdQ+TzjOmwE3y02YflmU43nm++xmapMxrd80BUtUUtJL Oi2g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q26-20020a2e969a000000b00261d469688fsi8754155lji.198.2022.09.08.08.56.11; Thu, 08 Sep 2022 08:57:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229736AbiIHP0e (ORCPT + 99 others); Thu, 8 Sep 2022 11:26:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232369AbiIHPZr (ORCPT ); Thu, 8 Sep 2022 11:25:47 -0400 Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com [209.85.222.177]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E84D1AE224 for ; Thu, 8 Sep 2022 08:25:38 -0700 (PDT) Received: by mail-qk1-f177.google.com with SMTP id i9so7208419qka.0 for ; Thu, 08 Sep 2022 08:25:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=We7YdNWL+dA6SvrcsgfeWC+uhCMnz0P9xITf03yypx8=; b=S6yX968R0PSQ5vvRpBoI3D+fVvYOS2cDyrN0vFbrxDCjkYTM5dHtdsB5QuuEQMDJq2 22GEdoeZIaVJp7gEDf8MrJUeos9pIEq9O0H/oJYSLbL5nEeMrRBtv/Q2pBzb4XiJpbbl QmPim36HxFhqnDtEqGqJhdz7fvaCKjnSuNQSBNtVtTsG36qJNDxDCTqXRYsMi1cxNyqs gGccXYEMJp2vlMrD8CaQsaNQAkzZWPMl4IF2AGUdYnAmoTooKlLHMCvDyWq/jJLM5EH9 nza5+wQNU4GaqUYp3IR56KRNjKUXCWo5Vqt3OMBnLhwOLdXz+OSlFpt1+PEm0MoKDBkn qKLA== X-Gm-Message-State: ACgBeo1W+0z+BwS/p95aAvZYY92YjnjE4f2gOSKh8ABwbhq4ltcw8P3O Y19upZ5692HdXlHghAJK6i84bV7ReK+L X-Received: by 2002:a05:620a:2451:b0:6cb:b4db:a3ad with SMTP id h17-20020a05620a245100b006cbb4dba3admr5003410qkn.216.1662650737962; Thu, 08 Sep 2022 08:25:37 -0700 (PDT) Received: from localhost (pool-68-160-173-162.bstnma.fios.verizon.net. [68.160.173.162]) by smtp.gmail.com with ESMTPSA id s13-20020a05620a0bcd00b006bb82221013sm17379003qki.0.2022.09.08.08.25.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Sep 2022 08:25:37 -0700 (PDT) Date: Thu, 8 Sep 2022 11:25:36 -0400 From: Mike Snitzer To: Kees Cook Cc: agk@redhat.com, mka@chromium.org, dm-devel@redhat.com, dianders@chromium.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, sarthakkukreti@chromium.org Subject: Re: dm: verity-loadpin: Only trust verity targets with enforcement Message-ID: References: <20220907133055.1.Ic8a1dafe960dc0f8302e189642bc88ebb785d274@changeid> <166259004596.4128104.7200162640366282166.b4-ty@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <166259004596.4128104.7200162640366282166.b4-ty@chromium.org> X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 07 2022 at 6:34P -0400, Kees Cook wrote: > On Wed, 7 Sep 2022 13:30:58 -0700, Matthias Kaehlcke wrote: > > Verity targets can be configured to ignore corrupted data blocks. > > LoadPin must only trust verity targets that are configured to > > perform some kind of enforcement when data corruption is detected, > > like returning an error, restarting the system or triggering a > > panic. > > > > > > [...] > > Applied to for-next/hardening, thanks! > > [1/1] dm: verity-loadpin: Only trust verity targets with enforcement > https://git.kernel.org/kees/c/2e1875c05267 Does this mean you're intending to send this upstream? I prefer to take all DM changes unless there is an external dependency. Thanks, Mike