Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220908085454.1024167-1-wenst@chromium.org>
In-Reply-To: <20220908085454.1024167-1-wenst@chromium.org>
From:   Doug Anderson <dianders@chromium.org>
Date:   Thu, 8 Sep 2022 08:35:55 -0700
Message-ID: <CAD=FV=VgyOT0eJ9eqwqaHRw2L7ypsTkiyGeSyqu-rEBURj5TCg@mail.gmail.com>
Subject: Re: [PATCH 1/2] drm/panel-edp: Fix delays for Innolux N116BCA-EA1
To:     Chen-Yu Tsai <wenst@chromium.org>
Cc:     Thierry Reding <thierry.reding@gmail.com>,
        Sam Ravnborg <sam@ravnborg.org>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi,

On Thu, Sep 8, 2022 at 1:55 AM Chen-Yu Tsai <wenst@chromium.org> wrote:
>
> Commit 52824ca4502d ("drm/panel-edp: Better describe eDP panel delays")
> clarified the various delays used for eDP panels, tying them to the eDP
> panel timing diagram.
>
> For Innolux N116BCA-EA1, .prepare_to_enable would be:
>
>     t4_min + t5_min + t6_min + max(t7_max, t8_min)
>
> Since t4_min and t5_min are both 0, the panel can use either .enable or
> .prepare_to_enable.
>
> As .enable is better defined, switch to using .enable for this panel.
>
> Also add .disable = 50, based on the datasheet's t9_min value. This
> effectively makes the delays the same as delay_200_500_e80_d50.
>
> Cc: Douglas Anderson <dianders@chromium.org>
> Fixes: 51d35631c970 ("drm/panel-simple: Add N116BCA-EA1")
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
> ---
>  drivers/gpu/drm/panel/panel-edp.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Yup, this looks like a good fix to me. Thanks! I guess that patch
you're fixing was from a time before I had analyzed the eDP panel
delays quite so closely.

Reviewed-by: Douglas Anderson <dianders@chromium.org>

Given how non-controversial these types of patches are, I typically
just apply them right away so I'll do that shortly. If this upsets
anyone then please shout and I'll change my behavior. ;-)

I've applied this one to drm-misc-fixes.

8f7115c1923c drm/panel-edp: Fix delays for Innolux N116BCA-EA1

-Doug