Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp1026424rwn; Thu, 8 Sep 2022 12:11:18 -0700 (PDT) X-Google-Smtp-Source: AA6agR7SwmVtAHq8F7U8jibTMl7rgCc9yXCyi3IMoH2jfEqpPePhMPk3+0s/4psjw8RZuGhci8ti X-Received: by 2002:a17:902:6b47:b0:172:9b8b:a3fe with SMTP id g7-20020a1709026b4700b001729b8ba3femr10150893plt.13.1662664278484; Thu, 08 Sep 2022 12:11:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662664278; cv=none; d=google.com; s=arc-20160816; b=NnGIcfOnWxlpSiZ5QZQbdco4jcS/RiFV+IHR8BPqIJkaDOOui+bhY+2403CEIQCv3I otJWN5gne9dzXqeiGfuKGAn0JXSFMkaPS/Z09EE4lvm8qL8zB+aZ1saX3kmnJ4TWTVBU 8TrU8RDAytBCY6vAvgCOL6E6m5vXemHKg6pIuyNlLdgpVKpCDPZ8tVrDtdqCHfnZGWCo 7F8vJA9Cxhc4LFQMDzAfCLcj4Svxr1aJuO6+kFZDAIeflIoxLq7EzMp+IkiAGMZ+8r3K PRvtzCQKeJmnzpGQ/xKfJmryQTyzfdaZ7mwUbo89I39oz6Dr7roO1VY0HNeWPMnNIFnU xT1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=gfIXfW5J9SVEu9o/XWeUdvEQaBXlA7mscUxlgleT6i0=; b=oS65m4ke23rclibf8J9a/mwAyp+LhtLPagmeTV8GwoKa9cDSKJtj9Xols25Vhc24pi cyEp/eUKBSGOvgvOdCO1CY4cxcjFmWpotoORTroxTAbU1MXwAagvi1HMcCgbXQZsjqrM 7Y0RHNv3kMEr9kaePAXuZvRjKqaQispu6oahgPcnZT9CDFY6+RAs8IpMjk1suzMtvt+K ZQqReHkAJB04pEAr5hC307GnfI5n+McESJ/hM3LlYJrKP1WOZcUHN7wozjr8pbJxtaQX WwCsjp2yFCUqeEoJF0RGw7V0GxVlmTFVPKdKVzwy36f5hF5PAGakz+qZGGm0eJU/VFEV Rs4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=s3kDBIOG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u2-20020a62ed02000000b0053711e43bdcsi17986322pfh.151.2022.09.08.12.11.06; Thu, 08 Sep 2022 12:11:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=s3kDBIOG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232002AbiIHSXY (ORCPT + 99 others); Thu, 8 Sep 2022 14:23:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60956 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231847AbiIHSXR (ORCPT ); Thu, 8 Sep 2022 14:23:17 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1B56F2967; Thu, 8 Sep 2022 11:23:13 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6E96AB821E1; Thu, 8 Sep 2022 18:23:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F0AE4C433D6; Thu, 8 Sep 2022 18:23:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662661391; bh=veGfQcuXT/TZaz1MGKphv5ehLEA9QrpIEJJIWFyMTPI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=s3kDBIOG4XjlB/QyzJBTb74S8Mt25ig2TjV9jtaQONJripVaVwskU5AJv4Q9iSxod 7vjwpkrp0EeYEoyJlNA9fT6717cjQ3PJTX/vyZDyyg5tjvt9FPHvgSvMwFgkLnh+nZ 0hUPOAKHNQvoK1FDgnh2HNwJiIqtcS5bebknkfNORmZXSSasUc7DZX2lfDZbmdAFJe TjH5RXkbk5iLCfkXEusDhZQLMH+kfjA7ZDbcBqE6BVit/nsf3t4eGR7ObfwUzAC9zS jbTwWf9GIyGNQud3n9sFyw9BW+9UEylaohHCBmEy53S2VNhSzrk7yQoWGgxFzdLYIs 8CP/q7fbIZvyg== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id E1916404A1; Thu, 8 Sep 2022 15:23:07 -0300 (-03) Date: Thu, 8 Sep 2022 15:23:07 -0300 From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Shang XiaoJing , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , linux-perf-users , linux-kernel Subject: Re: [PATCH 0/4] perf: Clean up by adding helpers Message-ID: References: <20220908021141.27134-1-shangxiaojing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, Sep 08, 2022 at 12:08:06AM -0700, Namhyung Kim escreveu: > Hello, > > On Wed, Sep 7, 2022 at 6:37 PM Shang XiaoJing wrote: > > > > Some clean up in builtin-lock.c, builtin-timechart.c, and > > builtin-trace.c. > > > > Shang XiaoJing (4): > > perf trace: Use zalloc to save initialization of syscall_stats > > perf lock: Add get_key_by_aggr_mode helper > > perf timechart: Add create_pidcomm helper > > perf timechart: Add p_state_end helper > > Acked-by: Namhyung Kim Thanks, applied. - Arnaldo > Thanks, > Namhyung > > > > > > tools/perf/builtin-lock.c | 129 ++++++++++++++------------------- > > tools/perf/builtin-timechart.c | 65 +++++++++-------- > > tools/perf/builtin-trace.c | 5 +- > > 3 files changed, 88 insertions(+), 111 deletions(-) > > > > -- > > 2.17.1 > > -- - Arnaldo