Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp1030332rwn; Thu, 8 Sep 2022 12:14:45 -0700 (PDT) X-Google-Smtp-Source: AA6agR4hBTWpj1rZ+bfETY1NisffxM5Ns6E+Pi20kY7Ysim6zVwIUOp2v01tbGqwvzgvrihDsQLH X-Received: by 2002:a05:6a00:b8b:b0:536:71f7:4ce3 with SMTP id g11-20020a056a000b8b00b0053671f74ce3mr10468513pfj.74.1662664485360; Thu, 08 Sep 2022 12:14:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662664485; cv=none; d=google.com; s=arc-20160816; b=UPVoZy41qdGBMhCStzs0y4tejP2SIz6YjlJSy0HDhrXwGbRb6JSYi8I+NDSLB4t0QE 3Rzn4YeqUFLwn1cGsfRCvo7mOlne92ig4NMiTzx1Zj5IDs8tVGPBRlMmX4dIP45sT2Bj KnV4INUyWt8Ktv00/KSmFhGM6csAjA0KLVXYAADQa5VJ8vLdwNrXOVkFYHCwpDS8BGrC gMIGWvtT6PxSLocxanAKYe+tHdGc3twU07PRMZT6EgZ1knuPIULcFInHnMbJ6tpwjhmY PtPXDTsZfkJOafh7lvaROY7QAQMxprP4x4ogcfsFqjMEPRI4Rdcq0INUs9se2P9wYlF8 p/Jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=yvwRDRcZM8L6JHil16m7teYV4wceQygldN8f81FISnM=; b=doZdLmzfCMyJw5hMjWm3DDYv4PvBLo138x/l5vllF/RJoTzhmEOKLBoONYrDWS+Q+Y bEEBESEMn4zOid2fzIHVKmY/794Mbk+TH1i9jvhCBG9tboAFZkep03XOSNn7UJvvYmEI tm3ua1KMU4QGkXFbAT8RlN5o+V2YD3osJxiIxRHY9snj4f/uDy3UR7XwkDD2qIZS7Z/Y 6fSYuti8+7+hNuYgrFGXxm1Paaz+79/GkUcL2432zH6AY80Br9rx1FllVneebzBjK9la 2fuR4cc1Cd6oY949BE6aPueUWXyEXu4KhYRABr3LfD/u7M3cnp7ZclGy6FAff0UdOSNQ /jEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@yocom-org.20210112.gappssmtp.com header.s=20210112 header.b=oPzs650E; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u2-20020a62ed02000000b0053711e43bdcsi17986322pfh.151.2022.09.08.12.14.33; Thu, 08 Sep 2022 12:14:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@yocom-org.20210112.gappssmtp.com header.s=20210112 header.b=oPzs650E; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231556AbiIHRhe (ORCPT + 99 others); Thu, 8 Sep 2022 13:37:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231475AbiIHRhP (ORCPT ); Thu, 8 Sep 2022 13:37:15 -0400 Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DBD3EE536 for ; Thu, 8 Sep 2022 10:37:02 -0700 (PDT) Received: by mail-pl1-x62f.google.com with SMTP id v1so5266798plo.9 for ; Thu, 08 Sep 2022 10:37:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yocom-org.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date; bh=yvwRDRcZM8L6JHil16m7teYV4wceQygldN8f81FISnM=; b=oPzs650E3cV1ZP7+ksTS6gxhzOPZ94wkyrb0zINZ+JEOAnbvatF3d37RMJojiNfYwr 8gD4dVd0ry9JfFw4gC/qS2USvq4ov8VDqrLdYPjhH7tZQmP7xesDweaAaqptzIM+RiST xYu8+yW8lO7pn1LSYoJiHENKLCne05wlSebz7gpN4ReLd0BjejGw5ZjQs4MUliszaWJx I8k998gYnzD4eYZcpLwKYiYOuxdO4CjFEYKu5YHFkYoHkGy/jih/GS0HLc6OdO7cT1lh pFyMhsA9sTAV/KUfNxqqtRORJ5b6DWHUX0I5DgoFINPtGbg0fvASBhXfxrLEuG6Jhh1f rulg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date; bh=yvwRDRcZM8L6JHil16m7teYV4wceQygldN8f81FISnM=; b=DvZecs+9ixlX/5QHUakzkJkNaeSeKcza/Ks8x05mBQ+brWu5PBt0DNx810/TgBKHFZ 21fxvOyLgaeDOv8r1iYQxl1Nz6eNMhwojX8OrJ+iG5sQVDo9d6EMjfZvP2zS8vcVkmGB JjhvktxDU1ls1yvFt0sWW+LQGXVbRxnulX6xfaw5O6By1L4HCDjnYUk60O9+cf0GNyV/ LVOyJ501KtHVm6pzdA5sQMVm4ElOU5Z/uYjdQ39v3tRd3JZJlhc3AZeyP2Vb2qx9V4kF 6Gdpxmxs5mBp/AKFyoNAITiA8e5HepavNV1r40dwi/CcJPBh9VyblVmQED1CG9Nh776Q A45w== X-Gm-Message-State: ACgBeo1DNKdsVmdQDvioCCPYvmQTB2uhO+OFp+Wqo/B0r1bk3pEX1u7t cCNDZpgwLbCeTevkwoPiBfexmA== X-Received: by 2002:a17:90b:4a91:b0:202:59ed:94d5 with SMTP id lp17-20020a17090b4a9100b0020259ed94d5mr5102190pjb.213.1662658617954; Thu, 08 Sep 2022 10:36:57 -0700 (PDT) Received: from ghaven-kernel ([2601:600:8f80:973::5f]) by smtp.gmail.com with ESMTPSA id k3-20020a628403000000b0053e5b905843sm5149847pfd.203.2022.09.08.10.36.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Sep 2022 10:36:57 -0700 (PDT) Date: Thu, 8 Sep 2022 10:36:55 -0700 From: Nate Yocom To: Dmitry Torokhov Cc: Bastien Nocera , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, benjamin.tissoires@redhat.com Subject: Re: [PATCH v5 2/4] Input: joystick: xpad: Add ABS_PROFILE axis value to uapi Message-ID: References: <20220825222420.6833-1-nate@yocom.org> <20220825222420.6833-3-nate@yocom.org> <3e48ef8d13337ce1c3ec68baffc612fde4740b0e.camel@hadess.net> <661ee8227c96aeba7aae9fff6ac9a73f1d81e765.camel@hadess.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 07, 2022 at 10:36:35PM -0700, Dmitry Torokhov wrote: > On Wed, Sep 07, 2022 at 05:41:08PM +0200, Bastien Nocera wrote: > > On Mon, 2022-08-29 at 12:07 -0700, Nate Yocom wrote: > > > On Sat, Aug 27, 2022 at 12:40:46PM +0200, Bastien Nocera wrote: > > > > On Thu, 2022-08-25 at 15:24 -0700, Nate Yocom wrote: > > > > > Add an ABS_PROFILE axis for input devices which need it, e.g. X- > > > > > Box > > > > > Adaptive Controller and X-Box Elite 2. > > > > > --- > > > > >  include/uapi/linux/input-event-codes.h | 1 + > > > > >  1 file changed, 1 insertion(+) > > > > > > > > > > diff --git a/include/uapi/linux/input-event-codes.h > > > > > b/include/uapi/linux/input-event-codes.h > > > > > index dff8e7f17074..7ad931a32970 100644 > > > > > --- a/include/uapi/linux/input-event-codes.h > > > > > +++ b/include/uapi/linux/input-event-codes.h > > > > > @@ -862,6 +862,7 @@ > > > > >  #define ABS_TOOL_WIDTH         0x1c > > > > >   > > > > >  #define ABS_VOLUME             0x20 > > > > > +#define ABS_PROFILE            0x21 > > > > >   > > > > >  #define ABS_MISC               0x28 > > > > >   > > > > > > > > > > > > You probably also want to add it to the absolutes array in > > > > drivers/hid/hid-debug.c. > > > > > > doh, roger. > > > > > > > Again, you might want to wait for confirmation from Dmitry that > > > > this is > > > > the right way to do this for the profiles. > > > > > > Makes sense.  Dmitry? > > > > Dmitry, could you please confirm whether ABS_PROFILE definition is > > correct? > > Yes, I think this makes sense. Do we have a buy in from userspace folks > (Peter H, etc) for this? > > I'd like some documentation added to Documentation/input/event-codes.rst > and potentially to Documentation/input/gamepad.rst even though profile > does not have to be gamepad specific event. > Will do, v6 incoming shortly.