Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp1041467rwn; Thu, 8 Sep 2022 12:25:30 -0700 (PDT) X-Google-Smtp-Source: AA6agR6i2iLs6eQ2mtJgfuwdEvHiiRqDvkhbdf4vmvw1IicajQX9WwwBNIlxLUBhvlm2DOZaoB6h X-Received: by 2002:a17:902:e212:b0:178:5c:8248 with SMTP id u18-20020a170902e21200b00178005c8248mr1436156plb.102.1662665129920; Thu, 08 Sep 2022 12:25:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662665129; cv=none; d=google.com; s=arc-20160816; b=g3rIdkr9isIGjW2Ag3SpIZBbriBRxiNQO6DDn8+DCD3yMzzzdMYPwN2akU0ERif/5Q V54j+1RiF1UEvIQUk92Wos5JU9qMV0KMwUUQBuH4l4Hd+0f+1PWoEXyCSpFtkK0EQyqF +0TRbGnG3TmNhXe/xAOA3GzoNUJP2KKY3OgR5cwcbQR2CCAKMtu5SseUOvdcjZ+vTpJE r8TevSwaiTr/2VWOOlYnZNTob1MgEz2ei96agQNH4hSnauM1/KV+dG3VrnBpaYlx54Tk AtGCeWs/aOHAlZY74J1/HeeQ0R483Em70Dgz1sVhlZGM7u0oUUKQK6Y1rVMSrGrD5mBx njxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=WEJ8iPiVGzM1B+W2oD4RJtEbeM915vp3bUA3kRn7JnI=; b=Q+33WLKlRBQ95yshulzDC+2V/2olg7UqF2vrczLcffRSvpe3oKjze8PZOLlvTHXCrp RCTMxu+NrXcBAfqU+aOtwtpyMSH4IgYK6rT0/EYtBxVNIFIMRr/5rUlrYAG0EdkDBwk3 RoTP+UWZ6Wrs3UTVVSyMvdnIvYOgv45rGlVdlX3z2jBzruNKFpankkxJxInU1pcgB1XZ fQwP4OgXU2o9RqFNZYeAMHgXmQhk7n2P5iejvOHVbswAmtta8SI/CQ8CM0yjNk4+dKrD JNy9WOUxGhwQmV3cuhMI8TUs28y45cjbKaMOPNvl0E6F7lOuNxpPyBopr4HzjzUyUhtB 05Vg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=baZEsFfC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s20-20020a17090ae69400b00200b224d11bsi2919343pjy.82.2022.09.08.12.25.17; Thu, 08 Sep 2022 12:25:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=baZEsFfC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230426AbiIHTSB (ORCPT + 99 others); Thu, 8 Sep 2022 15:18:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229445AbiIHTR7 (ORCPT ); Thu, 8 Sep 2022 15:17:59 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A9D0FE4B3 for ; Thu, 8 Sep 2022 12:17:59 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EAFDD61D67 for ; Thu, 8 Sep 2022 19:17:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC5CCC433D6; Thu, 8 Sep 2022 19:17:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662664678; bh=4y/gYFIK8fZNCZXf2/aoBtlgEBW3r/vu7ufnJ6SLnj4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=baZEsFfCF/BU3dYZ6PyVV/s/KTWUWw9Yx1eFiCutXR0stYn8JUfS644nK7an179BM UVXKuB/sNJyxrT2zgwrClPMQpj9NpT6J/whh/LZ1yQ+0EgGbDSrbAgHj0/1+QlKsmo LtDhyRFXWgZL/PSsuNNBVdbi+vU3FahBiOV+qeG1OVFIJHMDnA241WWOMNHrZPo8id o0EqpZoU26bRBKsNxH1WGeEQOn9Jm+mBps80/CL9Ben6hxyHYgAanl9w8s1iLYAEmx vQyc6YwndIYvXvrcul0RuZqhm3x795oaKEdj02zF5KIjsPsAY7Ww3KHJ+RjMHNRIXc dF8kQif0Rj3RA== From: SeongJae Park To: SeongJae Park Cc: Yajun Deng , akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm/damon: introduce struct damos_access_pattern Date: Thu, 8 Sep 2022 19:17:56 +0000 Message-Id: <20220908191756.129602-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220908184356.103133-1-sj@kernel.org> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 8 Sep 2022 18:43:56 +0000 SeongJae Park wrote: > Hi Yajun, > > On Thu, 8 Sep 2022 11:26:11 +0800 Yajun Deng wrote: > > > The damon_new_scheme() has too many parameters, we can introduce struct > > damos_access_pattern to simplify it. Because my previous comments are only for trivial cosmetic nits and the size of the patch is not tiny, I fixed those on my own and posted it: https://lore.kernel.org/damon/20220908191443.129534-1-sj@kernel.org/ Thanks, SJ [...]