Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 8 Sep 2022 12:47:04 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Robert Richter <rrichter@amd.com>,
        Dan Williams <dan.j.williams@intel.com>
CC:     Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        Ira Weiny <ira.weiny@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Len Brown <lenb@kernel.org>
Subject: Re: [PATCH 01/15] cxl/core: Remove duplicate declaration of
 devm_cxl_iomap_block()
Message-ID: <631a46b8a9e4f_166f294c@dwillia2-xfh.jf.intel.com.notmuch>
References: <20220831081603.3415-1-rrichter@amd.com>
 <20220831081603.3415-2-rrichter@amd.com>
 <63198120f143a_58016294a0@dwillia2-xfh.jf.intel.com.notmuch>
 <YxoBeJ4p/5oTSqrG@rric.localdomain>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <YxoBeJ4p/5oTSqrG@rric.localdomain>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?nZcy8Gq3mq3x7zoflV3asK+X8WhxlRWKTvfm/uQlPZ4VKz57wK86znXBDz6m?=
 =?us-ascii?Q?0K4RA0Hbix1t++wSty5JvUg9Ym6QiI74wxUurXDDKENtIYdB0/EWWl0ITF6c?=
 =?us-ascii?Q?tE+IIsSRg+LmMG3Wf/YdPMaDKNJA6YpTpIrNHgYttgWag7YJsyhDwxH/uaGa?=
 =?us-ascii?Q?KKFeVi2VvlhgzkXGzHdcis0QR1bMilEhEz+CdRwVedANflml6EmuRyMTA4uK?=
 =?us-ascii?Q?NTHXp1Jsp29oFuiwLu+qc0nAD+C2WhdwqlL0PEMcKM9qLKoJs+DEwEixQ6ni?=
 =?us-ascii?Q?PLoRJinyKm7SKlB+nfCK+QxSrFMR82qD7PatlhQ7DFrSc63n5udxsMS3w4VM?=
 =?us-ascii?Q?Bl2jEZ++OSh9jyo7BPsEySHdtb6a5m8zGci53XWn72emSc6NjXomk58GtR+n?=
 =?us-ascii?Q?ZqPv5VgTtvDkLc+WSegq0OwrEkAGNrYqxMkjW1ubYXZezWFSYjbd0jwFQLM7?=
 =?us-ascii?Q?jjkVY+5kVS/Njv+9wRcKyOpO09gN19iSkymzTzp4Q4XcgojWQeFJBV7+4XrL?=
 =?us-ascii?Q?26nViHy14dSVBDSi7LePPS3/ZxyNzCGZjD6q9is+FTgjWg7W6FUnc+bX7XYi?=
 =?us-ascii?Q?w/ewtijYR5hBAGJFHu0pZoFQyuh6dngbY76GlUNO3MGuEuWhOc+o2s2AwMmo?=
 =?us-ascii?Q?361S4UMsNh/9KQQIfinqeQ1wfwT1PClE/5Vhqh3Wty2h69xGKgoYp0g9LriC?=
 =?us-ascii?Q?5oUiPlhn2WoN7PW501IeZp87YYyGYbpGVaomwvbN37QWlyFSvWGsdMIni/nn?=
 =?us-ascii?Q?2HVqZe4TyRgsxvePlXnz4SX6FBfbotftgwBAS6QZap5UBEfzja4ZZsKoSV19?=
 =?us-ascii?Q?34gT8T4BYxLyMXQjWqgLNAzBUpUXXYmSp8i70ZehIhxflT0S0GtOxCuPup4r?=
 =?us-ascii?Q?G0gvmv33/s+plxxKzrsuGo5/Dhsm7R/Rd/uiASe1Goa7dw1qYJyWqUwMP3n/?=
 =?us-ascii?Q?baPCLAuNfbJJeWdOycfxIhA/BpWud7L+E2wDPrsm6xnVhLnfEn9GRyBD08AN?=
 =?us-ascii?Q?UMwgSEAjOBkYMq/RY2mmQOzarfzlUZOnDcQjoQPV+CYADO8hzaxcthqITurW?=
 =?us-ascii?Q?naRxufzMjU3UvlHLcMGYL8xF8j7bmWIqEVof0IUsONF4VlYKUxGpnt5yr9W8?=
 =?us-ascii?Q?g4GX9wpIpsRn46zfbtVW6i5iIvI/AwXGzYUW3alJrmHUtLo9QC6ESEthk5Nq?=
 =?us-ascii?Q?QzeXIs2DiZg08X+pSP2e0AYucS5vLNNaHZVwbaECF28Mejx3S27R5RjiN5w0?=
 =?us-ascii?Q?ysylPKIaDEU4/g240TYdttBGXp6JEt+c3Y/F6/VP1CLTfIP7XrwRhkatdCBv?=
 =?us-ascii?Q?Iw7lXXfh0Lyk9z6i0VfH2m3JFsUFY/budf1CYZxBq6a4tbtbJsRoeRO1Vc0L?=
 =?us-ascii?Q?rWHI/K0SguuQAc0GI98UwcSkTIqwz6Rv5m9BiNXRNh8jAq/9L1E+G9NmsMCo?=
 =?us-ascii?Q?he0AlNG+aS1JHARWKX2Q1Z2EcMcqeRCgpRfjTvgCPscJOy2lk3JafKYgmmK8?=
 =?us-ascii?Q?PF/Ngk+oQxUdkG4ELsP5c8DRpJ5oIFhHx3ZRG4cDWtj9ZbdNzpJJMJ4TCRxY?=
 =?us-ascii?Q?KNa9EZqifcordIFb1wdixXTl4fL/MxaaNEL6lbzl+ptee3ak2pqcPFnuM1cy?=
 =?us-ascii?Q?wg=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0f7b03fd-8cc9-4201-0888-08da91d2e9ba
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2126.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2022 19:47:07.8351
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: t4oPRsfbYKquF1qQz9Q2jeXzep1WPMiF98ApBPfaDxYxna8nuijrwZ9K0owe0bEDlxakY6vY5u3gjaROFdsu2O9AMJ2MoIdjlqCrJMuhz5s=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR11MB5858
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Robert Richter wrote:
> On 07.09.22 22:44:01, Dan Williams wrote:
> > Robert Richter wrote:
> > > The function devm_cxl_iomap_block() is only used in the core
> > > code. There are two declarations in header files of it, in
> > > drivers/cxl/core/core.h and drivers/cxl/cxl.h. Remove its unused
> > > declaration in drivers/cxl/cxl.h.
> > > 
> > > Signed-off-by: Robert Richter <rrichter@amd.com>
> > 
> > Looks good,
> > 
> > Reviewed-by: Dan Williams <dan.j.williams@intel.com>
> 
> Note there was a 0day build error. So I will add the inclusion of
> "core.h" to core/regs.c to this patch. I hope that is ok.

Yes, for my Reviewed-by: small fixups that don't touch the core theme of
the patch are ok.