Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp1138281rwn; Thu, 8 Sep 2022 14:10:42 -0700 (PDT) X-Google-Smtp-Source: AA6agR67OGXsd0bn3rMeFBi09PlqdQtkygwNmOIzOgMtJURiS6pCZo+mfNN7dsLXg5gnUvsxdkQZ X-Received: by 2002:a63:d754:0:b0:434:e57c:b2be with SMTP id w20-20020a63d754000000b00434e57cb2bemr9167102pgi.93.1662671442134; Thu, 08 Sep 2022 14:10:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662671442; cv=none; d=google.com; s=arc-20160816; b=GHEjUISI3ZXFsBbStHqPjtqTmpkBDTqeplUaRUUKfO54jRpQL4hNMB6Bxz1xjk7bcF K+f5Lb4x66Q1ka+WAHbbRhfhb0EVMEcDomHCHpu+8uO27JtYROZGXroUjemCOoCq6oZm E4rFVRQYF4EZQlXi1O0QuuTD0i7zBduxz+uP4PvAOXk/HSi1MHtPSwgUBVNjwpWV8cwS uvvI8Bd+L1/XkBXwBWgWI/NsCdr+CGvE9oS9/OEm3Qsxjb2ixAxlqCtguL+s5pcOX8OR VWgy1gYfHg7ZTtpTbJeNJsSnNHv8r4i44oWEBq0j9mQdLWEKgzGh8WmZZMWYmk4AeXoB 1Chw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :message-id:subject:cc:to:from:date:dkim-signature; bh=5314PQiGw7FeadUw/E4jodcX68tRb3wnK4nFjEVbtn8=; b=QKz2VLu4BueN2N39mDpVBSXBBxVnAwJZ0CURkb5LoeA0xmiJFjD4UqlwfKd6mPl9r5 keg9xwaDQvJbzH08ssXlKuiEtRkkCaSW25ivKid2U+QJxDh2w9++MrkCVJmOZl4rMnXs RLxCAqLNrKvpM0zuTbm1YNSBxrrWTrVqdk+CfeiXnCcRjOscRRQbTXb9OpH7mJXXMZTS z0hV2hjfuDGh5TPKDobecN1QT+7sXwC63F8vgTxpb62ys+lodUK2N6F151Kl155zJmWQ dZxB51DYhbRpn1N8kYwDPF0VemgvsOJL7yYiNMBwk8uPM2mhbtfh/uurQLiTjVd9AgNn rU3w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fWD4Lzd1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i189-20020a6387c6000000b00434aafc310asi8803406pge.140.2022.09.08.14.10.26; Thu, 08 Sep 2022 14:10:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fWD4Lzd1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229875AbiIHU6r (ORCPT + 99 others); Thu, 8 Sep 2022 16:58:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229456AbiIHU6p (ORCPT ); Thu, 8 Sep 2022 16:58:45 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E391DF22CB; Thu, 8 Sep 2022 13:58:44 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 96873B82295; Thu, 8 Sep 2022 20:58:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0EAA8C433C1; Thu, 8 Sep 2022 20:58:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662670722; bh=DIeAxZrVGmfNEL1VNL1hph8rWesLZ60HvIl1kbJkj+c=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=fWD4Lzd1nJHqUaFUJXtS5t+lxz+LMMvFBLdkclCpde6zarlURCTWWhDnUc/pyEcep 1W15cUG83hApgvwAtx+w+qFu60pXBgctHuVnf0cYTOnHbm5on12lzVLZmd9jzbk2iv hxTg1FrVvFGb1Yl+SNmppbGoADqHW23FwhCmWUMVrGhkM2S8lguO4p7e6MdDnQxFr8 MbUiHLaWKq40qABuHgKpu3a1RxtAr4V49uhMvdQmWXhalQO8mNBtAhxmFDkyPI2oL1 OR9vsX8rRuc/glcp7EoBi8ymtAW/NHaqp8OhI3Zq4P0U+0GvdV3rhpzW8Kcz8aG8et Ah1kHe6OHNbjg== Date: Thu, 8 Sep 2022 15:58:40 -0500 From: Bjorn Helgaas To: Sathyanarayanan Kuppuswamy Cc: Kai-Heng Feng , Rajvi Jingar , "Rafael J . Wysocki" , Koba Ko , Mika Westerberg , "David E . Box" , linux-pci@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas Subject: Re: [PATCH v3 09/10] PCI/PTM: Reorder functions in logical order Message-ID: <20220908205840.GA224952@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 08, 2022 at 01:15:12PM -0700, Sathyanarayanan Kuppuswamy wrote: > > > On 9/6/22 3:23 PM, Bjorn Helgaas wrote: > > From: Bjorn Helgaas > > > > pci_enable_ptm() and pci_disable_ptm() were separated. > > pci_save_ptm_state() and pci_restore_ptm_state() dangled at the top. Move > > them to logical places. > > > > Maybe add "No functional changes"? It will give clear meaning. Done, thanks!